0048444: Review and simplify CSSdataUri option for StyleSheetResourcesComponent

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0048444

Openbravo ERP

A. Platform

public

2022-01-20 14:34

Reporter

shuehner

Assigned To

Triage Platform Base

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

new

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0048444: Review and simplify CSSdataUri option for StyleSheetResourcesComponent

Description

The component to create the backoffice CSS sent to the browser has two modes related to i.e. images referenced from the CSS:
- Link to image itself
- Embed image content as a DataUri directly in the CSS

The later (datauri) was already used everywhere except Internet Explorer in version <8 which is not supported really for some years.

Issue 48435 now removed support for any Internet Explorer as code-cleanup to that cssDataUri is now always used.

<link rel="stylesheet" type="text/css" href="./org.openbravo.client.kernel/OBCLKER_Kernel/StyleSheetResources?_appName=OB3&_skinVersion=Default&_cssDataUri=true"/>

With that we could simplify the code in the StyleSheetResourceComponent to remove the there non dataUri case.

Note:
We should review is dataUri is still the preferred option for performance today at all as adding that option was done a long time ago

Steps To Reproduce

Proposed Solution

Additional Information