Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048415POS2POSpublic2022-01-18 11:272022-01-25 07:53
Reportershuehner 
Assigned Togorka_gil 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048415: This module is using bad logging (System.out,System.err println or printStackTrace)
DescriptionOngoing work is trying to remove all those examples of bad logging for all modules.
With the goal to eventually add a check in CI to avoid introducing new ones.

pos2 recently added new bad code in 48171 which needs to be fixed
Steps To Reproducehttps://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/src/org/openbravo/pos2/SafeboxCashupHistory.java#L112 [^]
Proposed SolutionUse proper log4j
Additional Information
TagsNo tags attached.
Relationships
caused by defect 0048171 closed prakashmurugesan88 POS2 Rel with JIRA 2419: Allow to extend cashup history query for safeboxes 
blocks design defect 0036162 acknowledged Triage Platform Base Openbravo ERP clean up openbravo.log 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-01-18 11:27shuehnerNew Issue
2022-01-18 11:27shuehnerAssigned To => Retail
2022-01-18 11:27shuehnerOBNetwork customer => No
2022-01-18 11:27shuehnerTriggers an Emergency Pack => No
2022-01-18 11:28shuehnerRelationship addedcaused by 0048171
2022-01-18 11:28shuehnerRelationship addedblocks 0036162
2022-01-24 13:30gorka_gilAssigned ToRetail => gorka_gil
2022-01-24 18:20hgbotMerge Request Status => open
2022-01-24 18:20hgbotNote Added: 0134534
2022-01-25 07:53hgbotMerge Request Statusopen => approved
2022-01-25 07:53hgbotResolutionopen => fixed
2022-01-25 07:53hgbotStatusnew => closed
2022-01-25 07:53hgbotNote Added: 0134538
2022-01-25 07:53hgbotNote Added: 0134539

Notes
(0134534)
hgbot   
2022-01-24 18:20   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/789 [^]
(0134538)
hgbot   
2022-01-25 07:53   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: d9fb95ae615626104d389b8d5ced3722c68f89f4
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 24-01-2022 18:18:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/d9fb95ae615626104d389b8d5ced3722c68f89f4 [^]

Fixed ISSUE-48415: use correct way of logging errors

---
M src/org/openbravo/pos2/SafeboxCashupHistory.java
---
(0134539)
hgbot   
2022-01-25 07:53   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/789 [^]