Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048411Retail ModulesWeb POSpublic2022-01-13 18:392022-01-20 16:44
Reportergorka_gil 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR21Q4.4Fixed in VersionRR21Q4.4 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048411: Cannot send back to the backend a paid order opened from a previous cashup
DescriptionWhen opening an order from a previous cashup and sending back to the backend it gives this error:

"The cashup related to this order has been processed"
Steps To ReproduceCreate a ticket
Do cashup
Open the previous ticket
Click on pay and done

It will produce an error while importing:
"The cashup related to this order has been processed"
Proposed SolutionWhen sending the json to the backend, in the json are included two cashup id's:
   - obposAppCashup : it is the cashup id linked to the order in the tables
   - cashUpReportInformation[id] : it is the cashup information of the pos when sending the ticket to the backend

If loading a order from a previous cashup, the cashUpReportInformation[id] will point to the current cashup, but the obposAppCashup will point to the cashup when the orded was created

So the proposal is change this check to instead of check the obposAppCashup , to check the cashUpReportInformation[id]

Attached fix proposal
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0048399 closed ranjith_qualiantech_com Cannot send back to the backend a paid order opened from a previous cashup 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-01-17 16:50marvintmTypedefect => backport
2022-01-17 16:50marvintmTarget Version => RR21Q4.4
2022-01-20 12:22hgbotMerge Request Status => open
2022-01-20 12:22hgbotNote Added: 0134409
2022-01-20 16:44hgbotMerge Request Statusopen => approved
2022-01-20 16:44hgbotResolutionopen => fixed
2022-01-20 16:44hgbotStatusscheduled => closed
2022-01-20 16:44hgbotFixed in Version => RR21Q4.4
2022-01-20 16:44hgbotNote Added: 0134424
2022-01-20 16:44hgbotNote Added: 0134425

Notes
(0134409)
hgbot   
2022-01-20 12:22   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/695 [^]
(0134424)
hgbot   
2022-01-20 16:44   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 86805e122a93a298603b10b703f44f02db1637b1
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 20-01-2022 16:47:33
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/86805e122a93a298603b10b703f44f02db1637b1 [^]

Fixed ISSUE-48411: Cashup should be validated when processing loaded order
* When processing loaded order, Cashup should be validated with cashUpReportInformation
  instead of obposAppCashup from json

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0134425)
hgbot   
2022-01-20 16:44   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/695 [^]