Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048408POS2POSpublic2022-01-17 16:062022-01-27 08:09
Reporterjmelin 
Assigned Tojorge-garcia 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048408: JIRA 2608 - Menu automatic transformation - Menu is transformed even if the menu is not in the price list linked to the schema
DescriptionOn tap or FS environment

When using “Menu automatic transformation”, a menu should be proposed only if the menu is in the price list linked to the WebPOS schema at org level
Steps To ReproduceAdd the following products to price list "OBREST The White Valley Group Terrace Price List"
- Onion Soup
- Carbonara Pizza
with a price of 10.00 for each

In POS Keymap "Main Terrace Keymap",
Create a new category and add both product Onion and Pizza

Connect to VBS-2 or refresh it

Switch to WebPOS schema "TERRACE" and to the new category
Add one of "Onion" and one of "Pizza" and go the payment page

KO => the menu is transformed into a "Repeated Product Menu" despite the menu is not in price list "OBREST The White Valley Group Terrace Price List"
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0048425TAP closed jorge-garcia JIRA 2608 - Menu automatic transformation - Menu is transformed even if the menu is not in the price list linked to the schema 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-01-17 16:06jmelinNew Issue
2022-01-17 16:06jmelinAssigned To => jmelin
2022-01-17 16:06jmelinTriggers an Emergency Pack => No
2022-01-17 16:28jmelinNote Added: 0134333
2022-01-17 16:28jmelinDescription Updatedbug_revision_view_page.php?rev_id=23526#r23526
2022-01-17 16:28jmelinSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=23528#r23528
2022-01-17 16:28jmelinAssigned Tojmelin => Retail
2022-01-19 08:40jorge-garciaAssigned ToRetail => jorge-garcia
2022-01-19 08:40jorge-garciaStatusnew => acknowledged
2022-01-19 11:30jorge-garciaStatusacknowledged => scheduled
2022-01-19 11:39hgbotNote Added: 0134382
2022-01-19 12:31jorge-garciaReview Assigned To => AugustoMauch
2022-01-27 08:09hgbotResolutionopen => fixed
2022-01-27 08:09hgbotStatusscheduled => closed
2022-01-27 08:09hgbotNote Added: 0134583
2022-01-27 08:09hgbotNote Added: 0134584

Notes
(0134333)
jmelin   
2022-01-17 16:28   
If you add the same products but from WebPOS schema "Restaurant", it sholud keep to be transformed into "Repeated Product Menu"
because no price list is linked to the WebPOS schema at org level and so the price list defined at org applied
(0134382)
hgbot   
2022-01-19 11:39   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/109 [^]
(0134583)
hgbot   
2022-01-27 08:09   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^]
Changeset: ed94187f6e44557ab035a3bd672a83d38de4a07d
Author: Jorge Garcia <jorge.garcia@openbravo.com>
Date: 19-01-2022 11:32:42
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/ed94187f6e44557ab035a3bd672a83d38de4a07d [^]

Fixed ISSUE-48408: Do not apply autodiscovery menu if schema pricelist
has no price for menu product

---
M web-jspack/org.openbravo.pos2.restaurant/src/model/food-menu/best-deal/__test__/discoverMenus.test.js
M web-jspack/org.openbravo.pos2.restaurant/src/model/food-menu/best-deal/discoverMenus.js
---
(0134584)
hgbot   
2022-01-27 08:09   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/109 [^]