Openbravo Issue Tracking System - Retail Modules
View Issue Details
0048399Retail ModulesWeb POSpublic2022-01-13 18:392022-01-19 13:14
gorka_gil 
ranjith_qualiantech_com 
normalmajoralways
closedfixed 
5
 
RR22Q2 
Production - Confirmed Stable
2021-02-09
RR21Q2
https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/39054d0461fd122a5e8d2e386d1d1cafcd82421e [^]
No
0048399: Cannot send back to the backend a paid order opened from a previous cashup
When opening an order from a previous cashup and sending back to the backend it gives this error:

"The cashup related to this order has been processed"
Create a ticket
Do cashup
Open the previous ticket
Click on pay and done

It will produce an error while importing:
"The cashup related to this order has been processed"
When sending the json to the backend, in the json are included two cashup id's:
   - obposAppCashup : it is the cashup id linked to the order in the tables
   - cashUpReportInformation[id] : it is the cashup information of the pos when sending the ticket to the backend

If loading a order from a previous cashup, the cashUpReportInformation[id] will point to the current cashup, but the obposAppCashup will point to the cashup when the orded was created

So the proposal is change this check to instead of check the obposAppCashup , to check the cashUpReportInformation[id]

Attached fix proposal
No tags attached.
depends on backport 0048410RR22Q1 closed ranjith_qualiantech_com Cannot send back to the backend a paid order opened from a previous cashup 
depends on backport 0048411RR21Q4.4 closed ranjith_qualiantech_com Cannot send back to the backend a paid order opened from a previous cashup 
caused by defect 0045579 closed ranjith_qualiantech_com Wrong cashup_id link for a ticket when doing an action 
diff fixLoadPaidOrder-posterminal.diff (1,948) 2022-01-13 18:41
https://issues.openbravo.com/file_download.php?file_id=16514&type=bug
Issue History
2022-01-13 18:39gorka_gilNew Issue
2022-01-13 18:39gorka_gilAssigned To => Retail
2022-01-13 18:39gorka_gilTriggers an Emergency Pack => No
2022-01-13 18:40gorka_gilStatusnew => acknowledged
2022-01-13 18:41gorka_gilFile Added: fixLoadPaidOrder-posterminal.diff
2022-01-13 18:41gorka_gilRelationship addedcaused by 0045579
2022-01-17 08:33ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2022-01-17 16:50marvintmStatusacknowledged => scheduled
2022-01-17 16:50marvintmRegression level => Production - Confirmed Stable
2022-01-17 16:50marvintmRegression date => 2021-02-09
2022-01-17 16:50marvintmRegression introduced in release => RR21Q2
2022-01-17 16:50marvintmRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/39054d0461fd122a5e8d2e386d1d1cafcd82421e [^]
2022-01-19 06:19hgbotNote Added: 0134372
2022-01-19 13:14hgbotResolutionopen => fixed
2022-01-19 13:14hgbotStatusscheduled => closed
2022-01-19 13:14hgbotFixed in Version => RR22Q2
2022-01-19 13:14hgbotNote Added: 0134385
2022-01-19 13:14hgbotNote Added: 0134386

Notes
(0134372)
hgbot   
2022-01-19 06:19   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/693 [^]
(0134385)
hgbot   
2022-01-19 13:14   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 570fd81f2aea280c1a638c48a14d80874d138b74
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 18-01-2022 12:51:36
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/570fd81f2aea280c1a638c48a14d80874d138b74 [^]

Fixed ISSUE-48399: Cashup should be validated when processing loaded order
* When processing loaded order, Cashup should be validated with cashUpReportInformation
  instead of obposAppCashup from json

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0134386)
hgbot   
2022-01-19 13:14   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/693 [^]