Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048396Openbravo ERP07. Sales managementpublic2022-01-13 16:382022-02-17 18:25
Reporterdromero 
Assigned ToAtulOpenbravo 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product VersionPR21Q2.3 
Target VersionFixed in VersionPR22Q2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket34578
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048396: The amount of collections ends up in a financial account for a higher amount
DescriptionHaving configured the Format.xml file with European format (decimal="," grouping=".") and then when you want to modify an existing collection, the amount of the collection appears in the associated Financial Account multiplied by 100.
Steps To Reproduce1 - Have the Format.xml configured for the treatment of amounts with European format (decimal="," grouping=".").
2 - Take any charge, observe that the amount of the charge appears in the same way in the corresponding transaction in the associated financial account.
3 - After checking this, delete this transaction.
4 - Then, we reactivate the collection in question to be able to make some modifications to it.
5 - We modify, for example, the collection date.
6 - Click on the 'Add Details' button, verify that the amount is the same since we did not modify it and we want to re-deposit the same value. We proceed to click on the 'Done' button.
7 - We return to the financial account and look for the associated transaction, click on the 'Update' button if necessary, and we will be able to see that the amount of the collection is multiplied by 100.

In the following link, you can see how the error is reproduced: https://watch.screencastify.com/v/oNZTlECyuHgl1MNRF6QB [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0044334 closed inigo_lerga Wrong amount in financial account if the currency of the payment is edited 
Attached Filesxml Format.xml (3,255) 2022-01-13 17:16
https://issues.openbravo.com/file_download.php?file_id=16511&type=bug
Issue History
Date ModifiedUsernameFieldChange
2022-01-13 16:38dromeroNew Issue
2022-01-13 16:38dromeroAssigned To => Triage Finance
2022-01-13 16:38dromeroOBNetwork customer => No
2022-01-13 16:38dromeroModules => Core
2022-01-13 16:38dromeroSupport ticket => 34578
2022-01-13 16:38dromeroTriggers an Emergency Pack => No
2022-01-13 17:00eugeniIssue Monitored: eugeni
2022-01-13 17:14eugeniNote Added: 0134290
2022-01-13 17:16eugeniFile Added: Format.xml
2022-01-13 17:46eugeniNote Edited: 0134290bug_revision_view_page.php?bugnote_id=0134290#r23513
2022-01-31 12:11plujanNote Added: 0134681
2022-01-31 16:28vmromanosAssigned ToTriage Finance => AtulOpenbravo
2022-02-01 02:22AtulOpenbravoNote Added: 0134688
2022-02-01 02:22AtulOpenbravoStatusnew => feedback
2022-02-01 12:20vmromanosAssigned ToAtulOpenbravo => dromero
2022-02-01 20:35dromeroETAnone => < 1 month
2022-02-01 20:35dromeroDescription Updatedbug_revision_view_page.php?rev_id=23604#r23604
2022-02-01 20:35dromeroSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=23606#r23606
2022-02-01 20:38dromeroNote Added: 0134720
2022-02-01 21:36AtulOpenbravoStatusfeedback => scheduled
2022-02-01 21:36AtulOpenbravoAssigned Todromero => AtulOpenbravo
2022-02-03 20:48hgbotMerge Request Status => open
2022-02-03 20:48hgbotNote Added: 0134773
2022-02-03 20:56AtulOpenbravoNote Added: 0134774
2022-02-14 12:06vmromanosOBNetwork customerNo => OBPS
2022-02-16 11:49sofidossantNote Added: 0135047
2022-02-17 18:22vmromanosRelationship addedrelated to 0044334
2022-02-17 18:24hgbotMerge Request Statusopen => approved
2022-02-17 18:25hgbotNote Added: 0135090
2022-02-17 18:25hgbotResolutionopen => fixed
2022-02-17 18:25hgbotStatusscheduled => closed
2022-02-17 18:25hgbotFixed in Version => PR22Q2
2022-02-17 18:25hgbotNote Added: 0135091
2022-02-17 18:25hgbotNote Added: 0135092

Notes
(0134290)
eugeni   
2022-01-13 17:14   
(edited on: 2022-01-13 17:46)
In order to reproduce the issue Format.xml needs to be set up as: grouping="." decimal=",". Example attached.
(0134681)
plujan   
2022-01-31 12:11   
This issue does not follow our bug reporting guidelines (available in the wiki), please fill the proper step to reproduce.
(0134688)
AtulOpenbravo   
2022-02-01 02:22   
Unable to reproduce with the information provided in the issue.
Need more exact steps to reproduce it.
(0134720)
dromero   
2022-02-01 20:38   
Issue updated with more accurate information. If you need more information to be able to reproduce the error we will try to provide it to you.
(0134773)
hgbot   
2022-02-03 20:48   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/521 [^]
(0134774)
AtulOpenbravo   
2022-02-03 20:56   
Test Plan

1 - Configure the Format.xml for amounts with European format (decimal="," grouping=".").
Compile application and start it.
2 - Login with Admin role for any client.
3 - In Financial Account Transaction, nagivate to account having transations.
4 - Select one of that could be unposted if required, reactivated and deleted.
5 - Navigate to Payment In Transaction related to.
6 - In Financial Account Transaction unpost, reactivate and delete it.
5 - In Payment In, reactivate the payment in without deleting lines option.
6 - Click on the 'Add Details' button, verify that the amount is the same, do not modify it as it should be re-deposited with the same amount. Proceed by click on the 'Done' button.
7 - Navigate to the financial account and check for the related transaction created, and check that the amount of the Payment In is correct. For eg:
Payment In Amount = 154,10
Financial Account Transaction Deposit Amount = 154,10 earlier it was showing wrongly as 15410
(0135047)
sofidossant   
2022-02-16 11:49   
Any updated?
(0135090)
hgbot   
2022-02-17 18:25   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/521 [^]
(0135091)
hgbot   
2022-02-17 18:25   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 938f4b41afa865838ad18af153c4067ec24d4296
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 17-02-2022 17:22:23
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/938f4b41afa865838ad18af153c4067ec24d4296 [^]

Fixes BUG-0048396: The amount of collections ends up in a financial
account for a higher amount

**Before setting amount in Fin Acc. Trx Amount field, convert it to
BigDecimal so that decimal & grouping in format is properly managed.

---
M src/org/openbravo/erpCommon/ad_callouts/SE_Payment_MultiCurrency.java
---
(0135092)
hgbot   
2022-02-17 18:25   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: fd2f446c8398dda26460a80afb2e09f3de84cdb2
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 17-02-2022 18:22:55
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/fd2f446c8398dda26460a80afb2e09f3de84cdb2 [^]

Related to ISSUE-48396: Fixed other scenario for String in inpfinaccTxnAmount

Inside the multicurrency branch, and only when the conversion rate is null (really weird
scenario, btw), the "inpfinaccTxnAmount" was set as a String too, which could lead to
the same problem reported in the issue.

The amount is transformed to BigDecimal like in the non-multicurrency branch.

---
M src/org/openbravo/erpCommon/ad_callouts/SE_Payment_MultiCurrency.java
---