Openbravo Issue Tracking System - Retail Modules
View Issue Details
0048388Retail ModulesSend By Emailpublic2022-01-12 14:272022-01-20 17:14
shuehner 
rqueralta 
normalminorhave not tried
closedfixed 
5
 
 
No
0048388: Sendemail module has jslint errors which should be fixed
That module has jslint errors pending to be fixed.



/srv/ci/workspace/mod-simple-ci42.18103/modules/org.openbravo.retail.sendemail/web/org.openbravo.retail.sendemail/source/obsmail_addbuttontoprintinvoices.js
  8:10 error 'OB' is already defined as a built-in global variable no-redeclare
  8:23 error '_' is already defined as a built-in global variable no-redeclare

/srv/ci/workspace/mod-simple-ci42.18103/modules/org.openbravo.retail.sendemail/web/org.openbravo.retail.sendemail/source/obsmail_hook_preordersave.js
  8:10 error 'OB' is already defined as a built-in global variable no-redeclare
  8:23 error '_' is already defined as a built-in global variable no-redeclare

/srv/ci/workspace/mod-simple-ci42.18103/modules/org.openbravo.retail.sendemail/web/org.openbravo.retail.sendemail/source/obsmail_hook_preprint.js
  8:10 error 'OB' is already defined as a built-in global variable no-redeclare

/srv/ci/workspace/mod-simple-ci42.18103/modules/org.openbravo.retail.sendemail/web/org.openbravo.retail.sendemail/source/obsmail_modalgetemailaddress.js
  8:16 error 'OB' is already defined as a built-in global variable no-redeclare
  8:29 error '_' is already defined as a built-in global variable no-redeclare

/srv/ci/workspace/mod-simple-ci42.18103/modules/org.openbravo.retail.sendemail/web/org.openbravo.retail.sendemail/source/obsmail_reprint_modalgetemailaddress.js
  8:16 error 'OB' is already defined as a built-in global variable no-redeclare
  8:29 error '_' is already defined as a built-in global variable no-redeclare

/srv/ci/workspace/mod-simple-ci42.18103/modules/org.openbravo.retail.sendemail/web/org.openbravo.retail.sendemail/source/obsmail_utils.js
  8:11 error 'OB' is already defined as a built-in global variable no-redeclare

-
No tags attached.
Issue History
2022-01-12 14:27shuehnerNew Issue
2022-01-12 14:27shuehnerAssigned To => Retail
2022-01-12 14:27shuehnerTriggers an Emergency Pack => No
2022-01-14 13:40martinsdanIssue Monitored: martinsdan
2022-01-14 21:24rqueraltaAssigned ToRetail => rqueralta
2022-01-14 21:24rqueraltaStatusnew => scheduled
2022-01-20 17:05hgbotNote Added: 0134426
2022-01-20 17:14hgbotResolutionopen => fixed
2022-01-20 17:14hgbotStatusscheduled => closed
2022-01-20 17:14hgbotNote Added: 0134427
2022-01-20 17:14hgbotNote Added: 0134428

Notes
(0134426)
hgbot   
2022-01-20 17:05   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail/-/merge_requests/9 [^]
(0134427)
hgbot   
2022-01-20 17:14   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail [^]
Changeset: 145c0ffb7763ef6928dbd94c23803b979ea82ee4
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 20-01-2022 16:05:59
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail/-/commit/145c0ffb7763ef6928dbd94c23803b979ea82ee4 [^]

Fixed BUG-48388: Fixed JSLint errors in Send By Email module


---
M web/org.openbravo.retail.sendemail/source/obsmail_addbuttontoprintinvoices.js
M web/org.openbravo.retail.sendemail/source/obsmail_hook_preordersave.js
M web/org.openbravo.retail.sendemail/source/obsmail_hook_preprint.js
M web/org.openbravo.retail.sendemail/source/obsmail_modalgetemailaddress.js
M web/org.openbravo.retail.sendemail/source/obsmail_reprint_modalgetemailaddress.js
M web/org.openbravo.retail.sendemail/source/obsmail_utils.js
---
(0134428)
hgbot   
2022-01-20 17:14   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail/-/merge_requests/9 [^]