Openbravo Issue Tracking System - Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0048379 | Modules | Advanced Warehouse Operations | public | 2022-01-11 17:31 | 2022-01-17 09:31 |
|
| Reporter | vmromanos | |
| Assigned To | vmromanos | |
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Regression date | |
| Regression introduced by commit | |
| Regression level | |
| Review Assigned To | |
| Support ticket | |
| OBNetwork customer | |
| Regression introduced in release | |
|
| Summary | 0048379: Blind Count and Initialize Qty Count with Book Qty when launching a Count/Recount from Warehouse Operations |
| Description | A count and a recount can be launched from the Warehouse Operations window, by selecting one or more storage details, and then by pressing the Count or Recount buttons.
In the case of a Count, it can be configured to be a shared or a non-shared count. A recount is always non-shared.
The new feature of Blind Count and Initialize Qty Count with Book Qty flags should be added also when launching the Count/Recount from the Warehouse Operations window. |
| Steps To Reproduce | Login in backoffice as AWO-QA admin
Select any storage detail and press Count or Recount
The Blind Count and Initialize Qty Count with Book Qty are not present. This is wrong, they should be present with the same logic as in the Inventory Count.
See http://wiki.openbravo.com/wiki/Modules:Advanced_Warehouse_Operations/Inventory_Count#Blind_counts [^] for details |
| Proposed Solution | Add the two flags Blind Count and Initialize Qty Count with Book Qty in both Count and Recount processes available at Warehouse Operations window.
Make sure they work with the preferences Force Blind Inventory Count, Create Blind Inventory Counts by default and Initialize Quantity Count with Book Quantity in the same way as in the Inventory Count window.
Make sure the quantity count is set only when the Initialize Quantity Count with Book Quantity flag is also set. This should be the behavior for both shared and non-shared counts. |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0048241 | | closed | vmromanos | "Initialize Quantity Count with Book Quantity" and manual backoffice lines | | related to | defect | 0048123 | | closed | ranjith_qualiantech_com | using not blind count -> qty counted is 0 if nothing is counted but UI shows qtyOnHand as counted |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2022-01-11 17:31 | vmromanos | New Issue | |
| 2022-01-11 17:31 | vmromanos | Assigned To | => Triage Finance |
| 2022-01-11 17:31 | vmromanos | Relationship added | related to 0048241 |
| 2022-01-11 17:32 | vmromanos | Relationship added | related to 0048123 |
| 2022-01-11 17:33 | Practics | Issue Monitored: Practics | |
| 2022-01-11 17:41 | vmromanos | Note Added: 0134232 | |
| 2022-01-11 18:05 | vmromanos | Status | new => scheduled |
| 2022-01-11 18:05 | vmromanos | Assigned To | Triage Finance => vmromanos |
| 2022-01-11 18:10 | hgbot | Note Added: 0134234 | |
| 2022-01-14 12:07 | hgbot | Resolution | open => fixed |
| 2022-01-14 12:07 | hgbot | Status | scheduled => closed |
| 2022-01-14 12:07 | hgbot | Note Added: 0134299 | |
| 2022-01-14 12:07 | hgbot | Note Added: 0134300 | |
| 2022-01-17 09:31 | hgbot | Note Added: 0134317 | |
| 2022-01-17 09:31 | hgbot | Note Added: 0134318 | |
| 2022-09-06 17:18 | caristu | Category | Advance Warehouse Operations => Advanced Warehouse Operations |
|
Notes |
|
|
|
Test plan:
Login in backoffice as system admin.
Go to Preference window and search for Force Blind Inventory Count and set it to N.
Search also for preference Initialize Quantity Count with Book Quantity and set it to Y.
This configuration allows easy testing.
Login in backoffice as AWO-QA admin.
Go to Warehouse Operations window.
Select any storage detail and press Count.
Make sure Blind Count is not set, and Initialize Qty Count with Book Qty is set to Y.
Run the following testing:
1. Non-shared, blind
2. Non-shared, non-blind, no initialize qty count
3. Shared, blind
4. Shared, non-blind, no initialize qty count
In all the tests above the generate count records should have qty count = 0
Now run the following testing:
1. Non-shared, non-blind, initialize qty count
2. Shared, non-blind, initialize qty count
In all the tests above the generate count records should have qty count = qty on hand.
Now repeat the testing with Recount (note that only non-shared is available for recounts). The same behavior should be shown here. |
|
|
|
(0134234)
|
|
hgbot
|
|
2022-01-11 18:10
|
|
|
|
|
(0134299)
|
|
hgbot
|
|
2022-01-14 12:07
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations [^]
Changeset: e6b7f3eea64c7bad5a32aa995816c7abc34d605b
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 11-01-2022 17:55:47
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/commit/e6b7f3eea64c7bad5a32aa995816c7abc34d605b [^]
Fixed ISSUE-48379: Blind Count and Init Qty Count from Warehouse Operations
Added two new parameters to the Count and Recount processes in Warehouse Operations:
* Blind Count
* Initialize Quantity Count with Book Quantity
Both have the same behavior as the equivalent flags at Inventory Count window, and they
are controlled by the same preferences.
It has been necessary to create a FilterExpression to define in Java the default value
for both flags when calling from Count/Recount. Note that the Initialize Qty Count flag
logic's have been simplified here compared to the Inventory Count window mainly because the
process is not shown in grid view, so with the display logic in this field, and with the
InventoryCountEventObserver is enough to properly control this flag.
Any previous utility method in charge of creating count related records have been deprecated,
and a new equivalent method is available to create and control both flags.
Any code using the previous methods has been adapted to use the new parameters accordingly.
The automatic tests are now using the new methods too keeping the original default behavior.
---
A src/org/openbravo/warehouse/advancedwarehouseoperations/filterexpression/BlindCountDefaultExpression.java
M src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOc_AWOFunctionalFlows.java
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOh_InventoryStatusWithAWOEnabled.java
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOrii_ReferencedInventoryImprovementBoxTest.java
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/ici/AWOici_GenerateList.java
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/ici/AWOici_PlannedCount.java
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/ici/AWOici_WeldBaseTest.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/handler/CountStockHandler.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/processors/InventoryCountProcessor.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/utils/inventorycount/InventoryCountUtils.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/utils/inventorycount/PlannedInventoryCountsCreatorHelper.java
---
|
|
|
|
(0134300)
|
|
hgbot
|
|
2022-01-14 12:07
|
|
|
|
|
(0134317)
|
|
hgbot
|
|
2022-01-17 09:31
|
|
|
|
|
(0134318)
|
|
hgbot
|
|
2022-01-17 09:31
|
|
|