Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048376POS2POSpublic2022-01-11 14:242022-01-27 18:34
Reporterprakashmurugesan88 
Assigned Toprakashmurugesan88 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048376: JIRA 2592 - Allow to open drawer if payment is marked as "cash" and flag has the flag "Open drawer before closing order"
DescriptionAllow to open drawer if payment is marked as "cash" and has the flag "Open drawer before closing order"

In such case,
The text of the button done changes to open,
so when it is pressed drawer is opened and text changes to done.
When done is pressed order is closed.

In old POS it is working
Steps To ReproduceIn BO,
Configure Hardwaremanager.
Touchpoint Type - Payment Method:
For cash payment method enable checkbox "Open Drawer Before Closing Ticket".

In POS,
Create a receipt and add cash payment.
Notice open button is not shown.

It should display open button to open drawer.
When it is pressed drawer is opened and button text changes to done.
Proposed SolutionWhen cash payment is selected with the "Open Drawer Before Closing Ticket" flag enabled.
Change Text of Done button to "Open".
When it is pressed drawer is opened and text changes to done.
When done is pressed order closed.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0048483TAP closed prakashmurugesan88 JIRA 2592 - Allow to open drawer if payment is marked as "cash" and flag has the flag "Open drawer before closing order" 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-01-11 14:24prakashmurugesan88New Issue
2022-01-11 14:24prakashmurugesan88Assigned To => prakashmurugesan88
2022-01-11 14:24prakashmurugesan88File Added: Screen Shot 2022-01-11 at 5.38.40 PM.png
2022-01-11 14:24prakashmurugesan88OBNetwork customer => No
2022-01-11 14:24prakashmurugesan88Triggers an Emergency Pack => No
2022-01-11 14:24prakashmurugesan88Statusnew => scheduled
2022-01-17 09:51prakashmurugesan88SummaryPreference 'Web POS Close Drawer Before Continue' is not working in POS2 => Drawer is not closed when order is closed
2022-01-17 09:51prakashmurugesan88Description Updatedbug_revision_view_page.php?rev_id=23517#r23517
2022-01-17 09:51prakashmurugesan88Steps to Reproduce Updatedbug_revision_view_page.php?rev_id=23519#r23519
2022-01-17 09:51prakashmurugesan88Proposed Solution updated
2022-01-17 09:52prakashmurugesan88File Deleted: Screen Shot 2022-01-11 at 5.38.40 PM.png
2022-01-18 09:59prakashmurugesan88SummaryDrawer is not closed when order is closed => Allow to open drawer if payment is marked as "cash" and flag has the flag "Open drawer before closing order"
2022-01-18 09:59prakashmurugesan88Description Updatedbug_revision_view_page.php?rev_id=23529#r23529
2022-01-18 09:59prakashmurugesan88Steps to Reproduce Updatedbug_revision_view_page.php?rev_id=23530#r23530
2022-01-18 09:59prakashmurugesan88Proposed Solution updated
2022-01-19 11:59hgbotMerge Request Status => open
2022-01-19 11:59hgbotNote Added: 0134383
2022-01-19 19:20guilleaerSummaryAllow to open drawer if payment is marked as "cash" and flag has the flag "Open drawer before closing order" => JIRA 2592 - Allow to open drawer if payment is marked as "cash" and flag has the flag "Open drawer before closing order"
2022-01-25 18:37hgbotMerge Request Statusopen => approved
2022-01-25 18:37cbernerStatusscheduled => acknowledged
2022-01-25 18:38cbernerStatusacknowledged => scheduled
2022-01-27 18:33hgbotResolutionopen => fixed
2022-01-27 18:33hgbotStatusscheduled => closed
2022-01-27 18:33hgbotNote Added: 0134627
2022-01-27 18:33hgbotNote Added: 0134628
2022-01-27 18:33hgbotNote Added: 0134629
2022-01-27 18:33hgbotNote Added: 0134630
2022-01-27 18:33hgbotNote Added: 0134631
2022-01-27 18:33hgbotNote Added: 0134632
2022-01-27 18:33hgbotNote Added: 0134633
2022-01-27 18:34hgbotNote Added: 0134634

Notes
(0134383)
hgbot   
2022-01-19 11:59   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/781 [^]
(0134627)
hgbot   
2022-01-27 18:33   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: c0826a7450cad3de24f63489e5c05f6031d2f585
Author: Prakash M <prakash@qualiantech.com>
Date: 27-01-2022 17:32:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/c0826a7450cad3de24f63489e5c05f6031d2f585 [^]

Fixed BUG-48376: Allowed to open drawer before processing receipt
* If payment is marked as cash and has the flag Open drawer before closing order
* Changed Text of Done button to Open on adding payment, it will open drawer
* Changed Text to Done after opening drawer, it will close ticket

---
A web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/OpenDrawer.test.js
A web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/OpenDrawerAction.test.js
A web-jspack/org.openbravo.pos2/src/model/user-interface/actions/OpenDrawer.js
A web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/OpenDrawer.js
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentKeypad/PaymentKeypad.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentKeypad/__test__/PaymentKeypad.test.jsx
M web-jspack/org.openbravo.pos2/src/ob-init.js
---
(0134628)
hgbot   
2022-01-27 18:33   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: bbfbaf2b57eb3659b1a9decf48c62ab4761f5f2f
Author: Prakash M <prakash@qualiantech.com>
Date: 27-01-2022 17:32:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/bbfbaf2b57eb3659b1a9decf48c62ab4761f5f2f [^]

Related to BUG-48376: Reused Create Message for OpenDrawer

---
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/OpenDrawerAction.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/OpenDrawer.js
---
(0134629)
hgbot   
2022-01-27 18:33   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 8b8525402544da198cf49eb166d281735fa72d27
Author: Prakash M <prakash@qualiantech.com>
Date: 27-01-2022 17:32:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/8b8525402544da198cf49eb166d281735fa72d27 [^]

Related to BUG-48376: Refined unsetOpenDrawerInTicket function

---
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/OpenDrawer.js
---
(0134630)
hgbot   
2022-01-27 18:33   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: af09adfb1d84958c07e506dfe8b293b61ecf263f
Author: Prakash M <prakash@qualiantech.com>
Date: 27-01-2022 17:32:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/af09adfb1d84958c07e506dfe8b293b61ecf263f [^]

Related to BUG-48376: Added user action in BO
* Refined OpenDrawer Test

---
M src-db/database/sourcedata/OBC2_USER_ACTION.xml
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/OpenDrawer.test.js
---
(0134631)
hgbot   
2022-01-27 18:33   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 826ae1737d7619755715b2b6e8e666de78227e6d
Author: Prakash M <prakash@qualiantech.com>
Date: 27-01-2022 17:32:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/826ae1737d7619755715b2b6e8e666de78227e6d [^]

Related to BUG-48376: Adapted openDrawer import as it is moved to global actions

---
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/OpenDrawerAction.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/OpenDrawer.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/OpenDrawer.js
---
(0134632)
hgbot   
2022-01-27 18:33   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 2c94f82b9586418ad7401f367c8e7105e1d63ec0
Author: Prakash M <prakash@qualiantech.com>
Date: 27-01-2022 17:32:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/2c94f82b9586418ad7401f367c8e7105e1d63ec0 [^]

Related to BUG-48376: Fixed Open drawer invoked twice
* First time on tapping open button and next on completing ticket

---
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/OpenDrawer.js
---
(0134633)
hgbot   
2022-01-27 18:33   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 15bb890601f2cd2c1030a176d3d45f344471ef40
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 27-01-2022 17:32:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/15bb890601f2cd2c1030a176d3d45f344471ef40 [^]

Related to BUG-48376: Clear the drawerOpened status in several ticket related actions

---
A web-jspack/org.openbravo.pos2/src/model/user-interface/actions/ResetDrawerOpened.js
M src-db/database/sourcedata/OBC2_USER_ACTION.xml
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentKeypad/PaymentKeypad.jsx
M web-jspack/org.openbravo.pos2/src/model/global/GlobalExtension.js
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js
---
(0134634)
hgbot   
2022-01-27 18:34   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/781 [^]