Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048375Openbravo ERP07. Sales managementpublic2022-01-11 13:422022-04-20 12:55
Reporteridiez 
Assigned Tocberner 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in VersionPR22Q2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket36689
Regression level
Regression date2022-01-19
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048375: Grid fails refresh when an element is selected and a group by applied
Descriptionplatform error in the sales order in grouping and filters

Grid shows this error grouped by a column and selecting row, the refresh button is pressed:
"For input string:" followed by:
 - NaN(in case of no filter selected when refreshing)
 - "{"Class":"Number"}" in case some filter has been selected
Steps To Reproduce### Updated steps to reproduce
1. Open livebuilds backoffice and login
2. Go to Sales Order window and clear filter
3. Right click on Business Partner and click on Group by Business Partner
4. Click on a row and then on the refresh button / It will break after this with the error mentioned.




### Old steps to reproduce
1) Enter livebuild retail translations

2)Go to the window "sales orders"

3) In the "sales order" window we must remove some filters for example: "Invoice Status", "Delivey Status", "Is canceled", "Selected strore location" and select the fields "Rouding Amount" and "Total Net Amount "

4) Select the field "Total Net Amount" and direct the filter "Set summary faction" and "sum"

5) Select the field "Business partner" and the filter "Group by Business partner"

6) We give the refresh button and we can see that it gives the following error "For input string =" NaN "

7) Filter by date in "Order Date" and refresh, we can see that it will give the following error: "For input string Class: Number}"

8) Remove the filter and continue with the same error


The link of video: https://watch.screencastify.com/v/LtwvuxGww1IXoIDtntnX [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-01-11 13:42idiezNew Issue
2022-01-11 13:42idiezAssigned To => Triage Finance
2022-01-11 13:42idiezOBNetwork customer => OBPS
2022-01-11 13:42idiezModules => Core
2022-01-11 13:42idiezSupport ticket => 36689
2022-01-11 13:42idiezRegression date => 2022-01-19
2022-01-11 13:42idiezTriggers an Emergency Pack => No
2022-01-11 13:50PracticsIssue Monitored: Practics
2022-01-11 18:15vmromanosAssigned ToTriage Finance => platform
2022-01-11 18:15vmromanosNote Added: 0134235
2022-01-11 18:15vmromanosSeveritycritical => major
2022-01-17 16:22cbernerDescription Updatedbug_revision_view_page.php?rev_id=23521#r23521
2022-01-17 16:22cbernerSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=23523#r23523
2022-01-17 16:23cbernerDescription Updatedbug_revision_view_page.php?rev_id=23524#r23524
2022-01-17 16:40cbernerStatusnew => acknowledged
2022-01-17 16:40cbernerAssigned Toplatform => cberner
2022-01-17 16:43AugustoMauchNote Added: 0134336
2022-01-18 11:42hgbotMerge Request Status => open
2022-01-18 11:42hgbotNote Added: 0134358
2022-01-25 10:02hgbotMerge Request Statusopen => approved
2022-01-25 10:59hgbotResolutionopen => fixed
2022-01-25 10:59hgbotStatusacknowledged => closed
2022-01-25 10:59hgbotFixed in Version => PR22Q2
2022-01-25 10:59hgbotNote Added: 0134547
2022-01-25 10:59hgbotNote Added: 0134548
2022-04-20 12:55cbernerSummaryURGENT: platform error in the sales order => Grid fails refresh when an element is selected and a group by applied

Notes
(0134235)
vmromanos   
2022-01-11 18:15   
Reduced severity to major
(0134336)
AugustoMauch   
2022-01-17 16:43   
Updating SLA due to severity downgrade
(0134358)
hgbot   
2022-01-18 11:42   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/502 [^]
(0134547)
hgbot   
2022-01-25 10:59   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 9bb588b21eebc0f8f8a49ad03fb946dee0ee7731
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 25-01-2022 09:58:28
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/9bb588b21eebc0f8f8a49ad03fb946dee0ee7731 [^]

Fixes ISSUE-48375: Grid fails refresh when an element is selected and a group by applied

Group by functionality doesn't generate a ResultSet when clicking the
refresh button, that means there is no data.resultSize object, it is
undefined. Because of this an error appeared when refreshing with an
element selected and with a group by applied to any column of a grid.

To fix it, the selected record check is skipped when doing a refresh
with a group by applied, as it is currently not supported to do so.
This basically results that when the refresh button is pressed, if a
record was selected(with group by applied), it will not be reselected
when the refresh finishes, if it is in the resultSet.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0134548)
hgbot   
2022-01-25 10:59   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/502 [^]