Openbravo Issue Tracking System - Retail Modules
View Issue Details
0048357Retail ModulesDiscounts and Promotionspublic2022-01-05 11:132022-10-10 09:15
AugustoMauch 
AugustoMauch 
highmajoralways
closedfixed 
5
 
RR22Q2 
No
0048357: The sorting configuration of "Add product categories" popup in "discounts and promotions" doesn't work as expected - new fix
When we set the parameters to sort the popup "Add product categories" in the "discount and promotion" window by searchkey, the table is still not sorted.

The issue is reproducable in Norauto environment (PR20Q3.1) but also in live build (Current version)

Previous fix was backed out because it broke CI
Prerequisites:
1- Log in BO with System Administrator role
2- Go to "windows, tabs and fields" page
3- Select name = "Offer Product Category Selector"
4- Go to "tabs" then "fields" subtab
5- Check that for searchkey "Record Sort No." = 1 (the others are empty)

Steps to reproduce :
1- Log in BO
2- Go to "discounts and promotions"
3- Select a discount
4- Click on the button "add product categories" in the tool bar
No tags attached.
causes defect 0050459 closed gdagnesses Openbravo ERP Cannot filter P&E grids by a field in descending criteria 
causes defect 0054091 closed Triage Platform Base Openbravo ERP "Payment Out" window - Cannot sort columns by descending order 
Issue History
2022-01-05 11:13AugustoMauchNew Issue
2022-01-05 11:13AugustoMauchAssigned To => AugustoMauch
2022-01-05 11:13AugustoMauchTriggers an Emergency Pack => No
2022-01-05 11:13AugustoMauchIssue generated from0048324
2022-01-05 13:21hgbotNote Added: 0134135
2022-01-05 13:59AugustoMauchStatusnew => scheduled
2022-03-15 11:07hgbotResolutionopen => fixed
2022-03-15 11:07hgbotStatusscheduled => closed
2022-03-15 11:07hgbotFixed in Version => PR22Q2
2022-03-15 11:07hgbotNote Added: 0135720
2022-03-15 11:07hgbotNote Added: 0135721
2022-10-10 08:48caristuIssue cloned0050459
2022-10-10 08:48caristuRelationship addedcauses 0050459
2022-10-10 09:15alostaleFixed in VersionPR22Q2 => RR22Q2
2024-01-04 04:14AtulOpenbravoRelationship addedcauses 0054091

Notes
(0134135)
hgbot   
2022-01-05 13:21   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/492 [^]
(0135720)
hgbot   
2022-03-15 11:07   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: e7487ed9e5b52d1c32013d2ca0c4bd9a16307bbd
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 15-03-2022 10:05:45
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/e7487ed9e5b52d1c32013d2ca0c4bd9a16307bbd [^]

Fixes ISSUE-48357: sortField property works properly in grids inside Parameter windows

The pick and execute windows were not setting the sortField property.

Apart from that, the datasource request must be reviewed to ensure that that the sortBy property references an existing grid field,
because due to a smartclient bug if a parameter window contains several grids and only the first one defines a sortBy field, then
the other grids will inherit the same sortBy property

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
---
(0135721)
hgbot   
2022-03-15 11:07   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/492 [^]