Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0004834Openbravo ERPA. Platformpublic2008-09-05 17:392008-12-11 13:19
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0004834: Remove unused validation-code (js & html) for WAD-generated windows
DescriptionSome of JS-code used in validation for these windows does nothing:

The inrange-check does not do anything
The valid-check does not do anything for the TextBox & TextArea widgets.

The js-script and the corresponding blocks of the HTML-code should be removed to make the pages more lightweight
Steps To Reproduce
Proposed Solution
Additional Information
Tagsperformance2.40scrum, Sprint-1
Relationships
blocks defect 0004832 closed shuehner Remove unused validation-code (js & html) for WAD-generated windows 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2008-09-05 17:39shuehnerNew Issue
2008-09-05 17:39shuehnerAssigned To => shuehner
2008-09-05 17:39shuehnerStatusnew => scheduled
2008-09-05 17:59shuehnerSummaryRemove unused validation-code (js & html) for WAD-generated windows => Remove unused validation-code (js & html) for WAD-generated windows
2008-09-05 17:59shuehnerDescription Updated
2008-09-05 18:10svnbotCheckin
2008-09-05 18:10svnbotNote Added: 0008899
2008-09-05 18:10svnbotStatusscheduled => resolved
2008-09-05 18:10svnbotResolutionopen => fixed
2008-09-05 18:10svnbotsvn_revision => 6927
2008-09-09 10:46svnbotCheckin
2008-09-09 10:46svnbotNote Added: 0008929
2008-09-09 10:46svnbotsvn_revision6927 => 7066
2008-09-09 10:51shuehnerTag Attached: performance2.40scrum
2008-10-23 07:48iperdomoTag Attached: sprint1
2008-10-24 18:05iperdomoTag Detached: sprint1
2008-10-24 18:05iperdomoTag Attached: Sprint-1
2008-12-11 13:19psarobeRegression testing => No
2008-12-11 13:19psarobeStatusresolved => closed

Notes
(0008899)
svnbot   
2008-09-05 18:10   
Repository: openbravo
Revision: 6927
Author: huehner
Date: 2008-09-05 18:10:53 +0200 (Fri, 05 Sep 2008)

Fixed 4834
Modify js-validation for WAD-generated windows
- remove isInRange validation code from all widgets (was a no-op)
- remove isValid validation from Textbox & Textarea widgets (was a no-op)
- remove (html,xml,java) support-code for the removed validations

---
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADControl.html
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADControl.java
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADControl.xml
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADDate.html
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADDate.java
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADDate.xml
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADDateTime.html
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADDateTime.java
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADDateTime.xml
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADInteger.html
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADInteger.java
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADInteger.xml
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADLink.html
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADLink.java
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADLink.xml
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADMemo.html
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADMemo.java
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADMemo.xml
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADNumber.html
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADNumber.java
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADNumber.xml
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADSearch.html
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADSearch.java
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADSearch.xml
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADString.html
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADString.java
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADString.xml
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADStringEncrypted.html
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADStringEncrypted.xml
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADTime.html
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADTime.java
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADTime.xml
U branches/r2.40/web/js/default/DateTextBox.js
U branches/r2.40/web/js/default/TimeTextBox.js
U branches/r2.40/web/js/default/UrlTextBox.js
U branches/r2.40/web/js/default/ValidationIntegerBox.js
U branches/r2.40/web/js/default/ValidationNumberBox.js
U branches/r2.40/web/js/default/ValidationTextArea.js
U branches/r2.40/web/js/default/ValidationTextBox.js
---

https://dev.openbravo.com/websvn/openbravo/?rev=6927&sc=1 [^]
(0008929)
svnbot   
2008-09-09 10:46   
Repository: openbravo
Revision: 7066
Author: huehner
Date: 2008-09-09 10:46:28 +0200 (Tue, 09 Sep 2008)

Issue 4834
Revert commit 6297 because this change will be first done in a feature branch
based on r2.40 and not in r2.40

---
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADControl.html
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADControl.java
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADControl.xml
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADDate.html
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADDate.java
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADDate.xml
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADDateTime.html
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADDateTime.java
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADDateTime.xml
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADInteger.html
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADInteger.java
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADInteger.xml
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADLink.html
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADLink.java
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADLink.xml
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADMemo.html
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADMemo.java
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADMemo.xml
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADNumber.html
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADNumber.java
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADNumber.xml
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADSearch.html
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADSearch.java
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADSearch.xml
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADString.html
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADString.java
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADString.xml
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADStringEncrypted.html
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADStringEncrypted.xml
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADTime.html
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADTime.java
U branches/r2.40/src-wad/src/org/openbravo/wad/controls/WADTime.xml
U branches/r2.40/web/js/default/DateTextBox.js
U branches/r2.40/web/js/default/TimeTextBox.js
U branches/r2.40/web/js/default/UrlTextBox.js
U branches/r2.40/web/js/default/ValidationIntegerBox.js
U branches/r2.40/web/js/default/ValidationNumberBox.js
U branches/r2.40/web/js/default/ValidationTextArea.js
U branches/r2.40/web/js/default/ValidationTextBox.js
---

https://dev.openbravo.com/websvn/openbravo/?rev=7066&sc=1 [^]