Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048335Openbravo ERPA. Platformpublic2021-12-29 09:572022-10-18 13:53
Reportercberner 
Assigned Tocberner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR23Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048335: AllJrxmlCompilation test should skip jrxml files intended to only be compiled with hwmanager functionality
Descriptionhwmanager module has a feature that allows using jrxml as printing templates. The jrxmls intended to be used with this feature, import and use hwmanager only classes and functionality, resulting in the test failing, because the test doesn't know anything related with hwmanager and only has backoffice functionality.

As such, the AllJrxmlCompilation test should skip all this files that use hwmanager classes and functionality due to it not being intended to compile this files.

It fails with the following errors when trying to compile this type of files:
- java.lang.ClassNotFoundException: com.openbravo.pos.printjrxml.JRJsonDatasource
- com.openbravo.pos.printer.ticket.PrintItemBarcode cannot be resolved to a type
Steps To ReproduceRun AllJrxmlCompilation test with at least one jrxml that has pos.printjrxml or pos.printer functionality from hwmanager.
Proposed SolutionSkip tests that include com.openbravo.pos package or classes in them, as they will never be able to fulfill these imports from this test. A patch has been provided attached here.
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff patchAllJrxmlCompilation.diff (2,413) 2021-12-29 09:57
https://issues.openbravo.com/file_download.php?file_id=16477&type=bug
Issue History
Date ModifiedUsernameFieldChange
2021-12-29 09:57cbernerNew Issue
2021-12-29 09:57cbernerAssigned To => Triage Platform Base
2021-12-29 09:57cbernerFile Added: patchAllJrxmlCompilation.diff
2021-12-29 09:57cbernerOBNetwork customer => No
2021-12-29 09:57cbernerModules => Core
2021-12-29 09:57cbernerTriggers an Emergency Pack => No
2021-12-29 09:57cbernerAssigned ToTriage Platform Base => cberner
2021-12-29 09:57cbernerStatusnew => acknowledged
2021-12-29 10:00hgbotMerge Request Status => open
2021-12-29 10:00hgbotNote Added: 0134037
2021-12-30 13:17shuehnerIssue Monitored: shuehner
2022-01-12 11:56cbernerStatusacknowledged => scheduled
2022-10-18 13:47hgbotMerge Request Statusopen => approved
2022-10-18 13:53hgbotResolutionopen => fixed
2022-10-18 13:53hgbotStatusscheduled => closed
2022-10-18 13:53hgbotFixed in Version => PR23Q1
2022-10-18 13:53hgbotNote Added: 0142230
2022-10-18 13:53hgbotNote Added: 0142231

Notes
(0134037)
hgbot   
2021-12-29 10:00   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/485 [^]
(0142230)
hgbot   
2022-10-18 13:53   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 829176af51eed85599f12c86acef5bf06d8cc538
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 18-10-2022 11:53:51
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/829176af51eed85599f12c86acef5bf06d8cc538 [^]

Fixes FR-48335: AllJrxmlCompilation test should skip hwmanager printing reports

Those type of jrxmls were including hwmanager only classes and libraries,
resulting in always generating errors when the test executed and this type of files were present,
so to deal with this part, we skip the files that include com.openbravo.pos functionality in them.

---
M src-test/src/org/openbravo/test/reporting/AllJrxmlCompilation.java
---
(0142231)
hgbot   
2022-10-18 13:53   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/485 [^]