Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048328Retail ModulesWeb POSpublic2021-12-27 09:472021-12-27 10:31
ReporterAugustoMauch 
Assigned ToRetail 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR22Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048328: CI is broken because mobile.core references method of retail.posterminal
DescriptionThere can't be any dependencies from mobile core to retail posterminal, the dependence is defined the other way around.
Steps To ReproduceSee https://builds.openbravo.com/job/mod-simple/40126/artifact/build.log: [^]

...

compileSqlc:
    [javac] Compiling 2450 source files to /srv/ci/workspace/mod-simple-ci42.18103/build/classes
    [javac] /srv/ci/workspace/mod-simple-ci42.18103/modules/org.openbravo.mobile.core/src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java:54: error: package org.openbravo.retail.posterminal does not exist
    [javac] import org.openbravo.retail.posterminal.POSUtils;
    [javac] ^
    [javac] 1 error

BUILD FAILED
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-12-27 09:47AugustoMauchNew Issue
2021-12-27 09:47AugustoMauchAssigned To => Retail
2021-12-27 09:47AugustoMauchOBNetwork customer => No
2021-12-27 09:47AugustoMauchTriggers an Emergency Pack => No
2021-12-27 09:50hgbotMerge Request Status => open
2021-12-27 09:50hgbotNote Added: 0133974
2021-12-27 09:51hgbotNote Added: 0133977
2021-12-27 10:18hgbotMerge Request Statusopen => approved
2021-12-27 10:31hgbotNote Added: 0133978
2021-12-27 10:31hgbotResolutionopen => fixed
2021-12-27 10:31hgbotStatusnew => closed
2021-12-27 10:31hgbotFixed in Version => RR22Q1
2021-12-27 10:31hgbotNote Added: 0133979
2021-12-27 10:31hgbotNote Added: 0133980
2021-12-27 10:31hgbotNote Added: 0133981

Notes
(0133974)
hgbot   
2021-12-27 09:50   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/672 [^]
(0133977)
hgbot   
2021-12-27 09:51   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/316 [^]
(0133978)
hgbot   
2021-12-27 10:31   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/316 [^]
(0133979)
hgbot   
2021-12-27 10:31   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: b0ef4773f0d6000e38c29b9e52f92d96b4e09ea2
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 27-12-2021 09:50:59
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/b0ef4773f0d6000e38c29b9e52f92d96b4e09ea2 [^]

Fixes ISSUE-48328: getPropertyInOrgTree function is now defined in OBMOBCUtils

The functionality is useful for all mobile applications, so the implementation has been moved to mobile.core and previous implementations
just reference the new one

---
M src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java
M src/org/openbravo/mobile/core/utils/OBMOBCUtils.java
---
(0133980)
hgbot   
2021-12-27 10:31   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 6fa564a99887e85792d530224e62dfa6630991d2
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 27-12-2021 10:29:58
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/6fa564a99887e85792d530224e62dfa6630991d2 [^]

Fixes ISSUE-48328: getPropertyInOrgTree function is now defined in OBMOBCUtils

The implementation in POSUtils now just forwards the invocation to the method defined in OBMOBCUtils

---
M src/org/openbravo/retail/posterminal/POSUtils.java
---
(0133981)
hgbot   
2021-12-27 10:31   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/672 [^]