Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048321POS2POSpublic2021-12-24 10:372022-01-12 07:40
Reporteraferraz 
Assigned TojavierRodriguez 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Versionpi 
Merge Request Statusapproved
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048321: Payment change is not correctly managed when overpaying with cash
DescriptionPayment change is not correctly managed when overpaying with cash
Steps To Reproduce- Create a ticket with one unit of Avalanche Transceiver (150.50€) and pay 200€ in Card. Check payment panel shows 49.50€ overpayment. This is correct.
- Complete the ticket and check in backoffice (Payment In window) the order is created with a payment with two lines: one of 150.50€ and another one of overpayment of 49.50€. This is correct.

- Create a ticket with one unit of Avalanche Transceiver (150.50€) and pay 200€ in Cash. Check payment panel shows 49.50€ change. This is correct.
- Complete the ticket and check in backoffice (Payment In window) the order is created with a payment with two lines: one of 150.50€ and another one of overpayment of 49.50€. This is not correct, the second payment line should not exists.

This flow works fine in POS1.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0048394 closed elara Payment change is not correctly managed when overpaying with cash having split payments 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-12-24 10:37aferrazNew Issue
2021-12-24 10:37aferrazAssigned To => Retail
2021-12-24 10:37aferrazOBNetwork customer => No
2021-12-24 10:37aferrazTriggers an Emergency Pack => No
2021-12-29 23:53AugustoMauchAssigned ToRetail => ablasco
2021-12-29 23:53AugustoMauchStatusnew => scheduled
2021-12-30 10:15AugustoMauchSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=23476#r23476
2022-01-04 13:40AugustoMauchAssigned Toablasco => Retail
2022-01-04 13:40AugustoMauchStatusscheduled => acknowledged
2022-01-05 14:23javierRodriguezAssigned ToRetail => javierRodriguez
2022-01-11 17:32hgbotMerge Request Status => open
2022-01-11 17:32hgbotNote Added: 0134231
2022-01-12 07:39hgbotMerge Request Statusopen => approved
2022-01-12 07:39hgbotNote Added: 0134239
2022-01-12 07:39hgbotNote Added: 0134240
2022-01-12 07:40marvintmStatusacknowledged => scheduled
2022-01-12 07:40marvintmStatusscheduled => resolved
2022-01-12 07:40marvintmFixed in Version => pi
2022-01-12 07:40marvintmResolutionopen => fixed
2022-01-12 07:40marvintmReview Assigned To => marvintm
2022-01-12 07:40marvintmStatusresolved => closed
2022-01-13 12:33aferrazRelationship addedrelated to 0048394

Notes
(0134231)
hgbot   
2022-01-11 17:32   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/773 [^]
(0134239)
hgbot   
2022-01-12 07:39   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: e9a4245d1bbe7db6160414ef807748c3f883c19e
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 11-01-2022 16:58:27
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/e9a4245d1bbe7db6160414ef807748c3f883c19e [^]

Fix ISSUE-48321: Set the split change always as true in complete ticket

The "WebPOS Split Change in Different Payment Details" preference was created to mantain the previous behaivor in old clients and, using this preference, use the new flow

- old flow: If the client pay with 200e a ticket and the total amout is 150e, the payment saved in BO is 150e
- new flow: If the client pay with 200e a ticket and the total amout is 150e, the payment saved is 200e and other payment with -50e.

This preference must be used only in the old webpos, in pos2 the only valid flow is the new one. This is the reason why pos2 does not check the preference and just set splitChange as true

---
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/CompleteTicket.js
---
(0134240)
hgbot   
2022-01-12 07:39   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/773 [^]