Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048320ModulesReportingpublic2021-12-24 10:222021-12-25 10:48
Reportershuehner 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customer
Regression introduced in release
Summary0048320: Review list of jar files copy to DataLoaderApp as several might not be needed
Description2 separate cases to look into:

a.) Issue 48282 required to update library file copying as filenames in backoffice had change yet again.
Undocumented change done instead to simplify that going ahead copy by wildcard patterns to no longer hardcode specific filenames (which include the version).

However among those the new patterns will suddenly include new files related to ant:
https://gitlab.com/openbravo/product/pmods/org.openbravo.reporting.tools/-/commit/9f5d045e8ceb9a86d6aac1c2b77a439a015299c8#bdc348bf75801c527f51cdeddc8edf027f7ef35a_247_169 [^]
File list before:
- ant-1.9.2.jar
File list now:
- ant-1.9.2.jar
- ant-launcher-1.9.2.jar
- ant-nodeps.jar

As no other code change was done requiring that + not documented probably accidental regression done in that commit.

b.) log4j-slf4j adapter files
That file is optional part of log4j to support code using the slf4j logging api but log4j as an implementation.
For that to be useful probably also the main slf4j api file would be needed as well (as done in backoffice)
slf4j-api-1.7.25.jar

Given that it is not copied + no direct slf4j reference seems to be in reporting.tools java code that looks like an unused file and if so should not be copied.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0048319 closed mtaal org.openbravo.reporting.tools compilation of dataloader does not support changed/removed libraries 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-12-24 10:22shuehnerNew Issue
2021-12-24 10:22shuehnerAssigned To => mtaal
2021-12-24 10:23shuehnerRelationship addedrelated to 0048319
2021-12-25 10:42hgbotResolutionopen => fixed
2021-12-25 10:42hgbotStatusnew => resolved
2021-12-25 10:42hgbotNote Added: 0133971
2021-12-25 10:46mtaalNote Added: 0133972
2021-12-25 10:46mtaalStatusresolved => closed
2021-12-25 10:48mtaalNote Added: 0133973

Notes
(0133971)
hgbot   
2021-12-25 10:42   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.reporting.tools [^]
Changeset: 23d6347be407ee949d04f6ad64000885a05cde27
Author: Martin Taal <martin.taal@openbravo.com>
Date: 25-12-2021 10:42:33
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.reporting.tools/-/commit/23d6347be407ee949d04f6ad64000885a05cde27 [^]

Fixes ISSUE-0048320: Review list of jar files copy to DataLoaderApp as several might not be needed

---
M build.xml
---
(0133972)
mtaal   
2021-12-25 10:46   
checked and tested
(0133973)
mtaal   
2021-12-25 10:48   
openbravo@reporting-dev:/opt/OpenbravoERP/modules/org.openbravo.reporting.tools$ ls /opt/OpenbravoReporting/DataLoaderApp/lib/
ant-1.9.2.jar ant-launcher-1.9.2.jar ant-nodeps.jar jettison-1.3-patched.jar log4j-api-2.17.0.jar log4j-core-2.17.0.jar log4j-slf4j-impl-2.17.0.jar ojdbc8-19.3.0.0.jar postgresql-42.2.20.jar
openbravo@reporting-dev:/opt/OpenbravoERP/modules/org.openbravo.reporting.tools$ git pull
Username for 'https://gitlab.com': [^] martin.taal@openbravo.com
Password for 'https://martin.taal@openbravo.com@gitlab.com': [^]
warning: redirecting to https://gitlab.com/openbravo/product/pmods/org.openbravo.reporting.tools.git/ [^]
remote: Enumerating objects: 3, done.
remote: Counting objects: 100% (3/3), done.
remote: Compressing objects: 100% (3/3), done.
remote: Total 3 (delta 0), reused 0 (delta 0), pack-reused 0
Unpacking objects: 100% (3/3), done.
From https://gitlab.com/openbravo/product/pmods/org.openbravo.reporting.tools [^]
   4c8ccc8..23d6347 master -> origin/master
Updating 4c8ccc8..23d6347
Fast-forward
 build.xml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
openbravo@reporting-dev:/opt/OpenbravoERP/modules/org.openbravo.reporting.tools$ ./generate_app
Buildfile: /opt/OpenbravoERP/modules/org.openbravo.reporting.tools/build.xml

generate.dataloader.application:
   [delete] Deleting directory /tmp/reportingSources
    [mkdir] Created dir: /tmp/reportingSources
[generateDataLoadApplication] 1874 [main] INFO org.openbravo.dal.core.DalLayerInitializer - Initializing in-memory model...
[generateDataLoadApplication] 1886 [main] INFO org.openbravo.base.model.ModelProvider - Building runtime model
[generateDataLoadApplication] 9091 [main] INFO org.openbravo.dal.core.DalLayerInitializer - Model read in-memory, generating mapping...
[generateDataLoadApplication] 19260 [main] INFO org.openbravo.dal.core.DalLayerInitializer - Dal layer initialized
[generateDataLoadApplication] 19415 [main] INFO org.openbravo.reporting.tools.task.GenerateDataLoadApplicationTask - Collecting load script definitions and jar files into /opt/OpenbravoReporting/DataLoaderApp
[generateDataLoadApplication] 19602 [main] INFO org.openbravo.reporting.tools.task.GenerateDataLoadApplicationTask - Collecting source file for the application build
[generateDataLoadApplication] 19614 [main] INFO org.openbravo.reporting.tools.task.GenerateDataLoadApplicationTask - Copied org.openbravo.reporting.tools.sales.StoreSummaryReportLoader to /tmp/reportingSources/org/openbravo/reporting/tools/sales/StoreSummaryReportLoader/StoreSummaryReportLoader.java
[generateDataLoadApplication] 19616 [main] INFO org.openbravo.reporting.tools.task.GenerateDataLoadApplicationTask - Copied org.openbravo.reporting.tools.loyalty.LoyaltyCardLoader to /tmp/reportingSources/org/openbravo/reporting/tools/loyalty/LoyaltyCardLoader/LoyaltyCardLoader.java
[generateDataLoadApplication] 19617 [main] INFO org.openbravo.reporting.tools.task.GenerateDataLoadApplicationTask - Copied org.openbravo.reporting.tools.masterdata.FiscalYearSettingLoader to /tmp/reportingSources/org/openbravo/reporting/tools/masterdata/FiscalYearSettingLoader/FiscalYearSettingLoader.java
[generateDataLoadApplication] 19619 [main] INFO org.openbravo.reporting.tools.task.GenerateDataLoadApplicationTask - Copied org.openbravo.reporting.tools.sales.CashupSummaryReportLoader to /tmp/reportingSources/org/openbravo/reporting/tools/sales/CashupSummaryReportLoader/CashupSummaryReportLoader.java
[generateDataLoadApplication] 19619 [main] INFO org.openbravo.reporting.tools.task.GenerateDataLoadApplicationTask - Copying from /opt/OpenbravoERP/modules/org.openbravo.reporting.tools/src/org/openbravo/reporting/tools/dataloader to /tmp/reportingSources/org/openbravo/reporting/tools/dataloader
[generateDataLoadApplication] 19622 [main] INFO org.openbravo.reporting.tools.task.GenerateDataLoadApplicationTask - Copied dataloader package
    [mkdir] Created dir: /tmp/reportingBuild
    [javac] Compiling 24 source files to /tmp/reportingBuild
      [jar] Building jar: /opt/OpenbravoReporting/DataLoaderApp/org.openbravo.reporting.tools.dataloader.jar
     [copy] Copying 1 file to /opt/OpenbravoReporting/DataLoaderApp
     [move] Moving 1 file to /opt/OpenbravoReporting/DataLoaderApp
     [copy] Copying 1 file to /opt/OpenbravoReporting/DataLoaderApp
     [copy] Copying 6 files to /opt/OpenbravoReporting/DataLoaderApp/lib
   [delete] Deleting directory /tmp/reportingBuild

BUILD SUCCESSFUL
Total time: 22 seconds
openbravo@reporting-dev:/opt/OpenbravoERP/modules/org.openbravo.reporting.tools$ ls /opt/OpenbravoReporting/DataLoaderApp/lib/
ant-1.9.2.jar jettison-1.3-patched.jar log4j-api-2.17.0.jar log4j-core-2.17.0.jar ojdbc8-19.3.0.0.jar postgresql-42.2.20.jar
openbravo@reporting-dev:/opt/OpenbravoERP/modules/org.openbravo.reporting.tools$