Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0004832Openbravo ERPA. Platformpublic2008-09-05 17:362009-04-21 11:05
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0004832: Remove unused validation-code (js & html) for WAD-generated windows
DescriptionSome of JS-code used in validation for these windows does nothing:

The inrange-check does not to anything
The valid-check does not do anything for the TextBox & TextArea widgets.

The js-script and the corresponding blocks of the HTML-code should be removed to make the pages more lightweight
Steps To Reproduce
Proposed Solution
Additional Information
Tagsperformance2.40scrum, Sprint-1
Relationships
depends on backport 0004834 closed shuehner Remove unused validation-code (js & html) for WAD-generated windows 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2008-09-05 17:36shuehnerNew Issue
2008-09-05 17:36shuehnerAssigned To => shuehner
2008-09-05 17:36shuehnersf_bug_id0 => 2095216
2008-09-05 17:36shuehnerOBNetwork customer => No
2008-09-05 17:36shuehnerRegression testing => No
2008-09-05 17:39shuehnerNote Added: 0008898
2008-09-05 17:39shuehnerStatusnew => scheduled
2008-09-05 17:39shuehnerfix_in_branch => trunk
2008-09-05 18:00shuehnerfix_in_branchtrunk =>
2008-09-05 18:00shuehnerDescription Updated
2008-09-05 18:31svnbotCheckin
2008-09-05 18:31svnbotNote Added: 0008900
2008-09-05 18:31svnbotStatusscheduled => resolved
2008-09-05 18:31svnbotResolutionopen => fixed
2008-09-05 18:31svnbotsvn_revision => 6928
2008-09-09 10:51shuehnerTag Attached: performance2.40scrum
2008-09-09 12:06svnbotCheckin
2008-09-09 12:06svnbotNote Added: 0008934
2008-09-09 12:06svnbotsvn_revision6928 => 7076
2008-10-23 07:48iperdomoTag Attached: sprint1
2008-10-24 18:05iperdomoTag Detached: sprint1
2008-10-24 18:05iperdomoTag Attached: Sprint-1
2009-04-21 11:05psarobeStatusresolved => closed

Notes
(0008898)
shuehner   
2008-09-05 17:39   
The proposed changes decrease the size of the generated pages by about 9mb in total and the size of i.e. the product window (form-view) by 27kb
(0008900)
svnbot   
2008-09-05 18:31   
Repository: openbravo
Revision: 6928
Author: huehner
Date: 2008-09-05 18:31:34 +0200 (Fri, 05 Sep 2008)

Fixed 4832
Modify js-validation for WAD-generated windows
- remove isInRange validation code from all widgets (was a no-op)
- remove isValid validation from Textbox & Textarea widgets (was a no-op)
- remove (html,xml,java) support-code for the removed validations

---
U trunk/src-wad/src/org/openbravo/wad/controls/WADControl.html
U trunk/src-wad/src/org/openbravo/wad/controls/WADControl.java
U trunk/src-wad/src/org/openbravo/wad/controls/WADControl.xml
U trunk/src-wad/src/org/openbravo/wad/controls/WADDate.html
U trunk/src-wad/src/org/openbravo/wad/controls/WADDate.java
U trunk/src-wad/src/org/openbravo/wad/controls/WADDate.xml
U trunk/src-wad/src/org/openbravo/wad/controls/WADDateTime.html
U trunk/src-wad/src/org/openbravo/wad/controls/WADDateTime.java
U trunk/src-wad/src/org/openbravo/wad/controls/WADDateTime.xml
U trunk/src-wad/src/org/openbravo/wad/controls/WADInteger.html
U trunk/src-wad/src/org/openbravo/wad/controls/WADInteger.java
U trunk/src-wad/src/org/openbravo/wad/controls/WADInteger.xml
U trunk/src-wad/src/org/openbravo/wad/controls/WADLink.html
U trunk/src-wad/src/org/openbravo/wad/controls/WADLink.java
U trunk/src-wad/src/org/openbravo/wad/controls/WADLink.xml
U trunk/src-wad/src/org/openbravo/wad/controls/WADMemo.html
U trunk/src-wad/src/org/openbravo/wad/controls/WADMemo.java
U trunk/src-wad/src/org/openbravo/wad/controls/WADMemo.xml
U trunk/src-wad/src/org/openbravo/wad/controls/WADNumber.html
U trunk/src-wad/src/org/openbravo/wad/controls/WADNumber.java
U trunk/src-wad/src/org/openbravo/wad/controls/WADNumber.xml
U trunk/src-wad/src/org/openbravo/wad/controls/WADSearch.html
U trunk/src-wad/src/org/openbravo/wad/controls/WADSearch.java
U trunk/src-wad/src/org/openbravo/wad/controls/WADSearch.xml
U trunk/src-wad/src/org/openbravo/wad/controls/WADString.html
U trunk/src-wad/src/org/openbravo/wad/controls/WADString.java
U trunk/src-wad/src/org/openbravo/wad/controls/WADString.xml
U trunk/src-wad/src/org/openbravo/wad/controls/WADStringEncrypted.html
U trunk/src-wad/src/org/openbravo/wad/controls/WADStringEncrypted.xml
U trunk/src-wad/src/org/openbravo/wad/controls/WADTime.html
U trunk/src-wad/src/org/openbravo/wad/controls/WADTime.java
U trunk/src-wad/src/org/openbravo/wad/controls/WADTime.xml
U trunk/web/js/default/DateTextBox.js
U trunk/web/js/default/TimeTextBox.js
U trunk/web/js/default/UrlTextBox.js
U trunk/web/js/default/ValidationIntegerBox.js
U trunk/web/js/default/ValidationNumberBox.js
U trunk/web/js/default/ValidationTextArea.js
U trunk/web/js/default/ValidationTextBox.js
---

https://dev.openbravo.com/websvn/openbravo/?rev=6928&sc=1 [^]
(0008934)
svnbot   
2008-09-09 12:06   
Repository: openbravo
Revision: 7076
Author: huehner
Date: 2008-09-09 12:06:30 +0200 (Tue, 09 Sep 2008)

Issue 4832
Removed unused validation code (js & html)

---
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADControl.html
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADControl.java
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADControl.xml
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADDate.html
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADDate.java
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADDate.xml
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADDateTime.html
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADDateTime.java
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADDateTime.xml
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADInteger.html
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADInteger.java
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADInteger.xml
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADLink.html
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADLink.java
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADLink.xml
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADMemo.html
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADMemo.java
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADMemo.xml
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADNumber.html
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADNumber.java
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADNumber.xml
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADSearch.html
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADSearch.java
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADSearch.xml
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADString.html
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADString.java
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADString.xml
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADStringEncrypted.html
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADStringEncrypted.xml
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADTime.html
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADTime.java
U branches/r2.40performance/src-wad/src/org/openbravo/wad/controls/WADTime.xml
U branches/r2.40performance/web/js/default/DateTextBox.js
U branches/r2.40performance/web/js/default/TimeTextBox.js
U branches/r2.40performance/web/js/default/UrlTextBox.js
U branches/r2.40performance/web/js/default/ValidationIntegerBox.js
U branches/r2.40performance/web/js/default/ValidationNumberBox.js
U branches/r2.40performance/web/js/default/ValidationTextArea.js
U branches/r2.40performance/web/js/default/ValidationTextBox.js
---

https://dev.openbravo.com/websvn/openbravo/?rev=7076&sc=1 [^]