Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048315Retail ModulesLoyalty Programs for Web POSpublic2021-12-23 16:052022-02-01 18:23
Reportermdubreux 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048315: Gift certificate Burn Rule not working
DescriptionWhen burning points to generate a gift certificate, the POS throw an error which doesn't indicate what is wrong
Steps To ReproduceCreate burn rule to create gift certificate
Go through a sales process
click on redeem the gift certificate
Error is displayed

Video:

https://watch.screencastify.com/v/3bvbLwPpZUf8u9W1R55s [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0048516RR22Q1.1 closed ranjith_qualiantech_com It is not possible to redeem points while doing a purchase 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-12-23 16:05mdubreuxNew Issue
2021-12-23 16:05mdubreuxAssigned To => Retail
2021-12-23 16:05mdubreuxTriggers an Emergency Pack => No
2022-01-10 15:52javierRodriguezNote Added: 0134179
2022-01-24 06:10ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2022-01-25 05:31hgbotNote Added: 0134537
2022-01-25 05:35ranjith_qualiantech_comStatusnew => scheduled
2022-01-31 09:18hgbotResolutionopen => fixed
2022-01-31 09:18hgbotStatusscheduled => closed
2022-01-31 09:18hgbotNote Added: 0134679
2022-01-31 09:18hgbotNote Added: 0134680
2022-02-01 18:23martinsdanIssue Monitored: martinsdan
2022-02-02 15:34martinsdanRelationship addedrelated to 0048516

Notes
(0134179)
javierRodriguez   
2022-01-10 15:52   
2022-01-10 15:39:00,320 [http-4] ERROR org.openbravo.mobile.core.process.JSONRowConverter - Error in JSON process: null
java.lang.NullPointerException: null
    at org.openbravo.loyalty.burn.giftcertificate.process.GenerateGiftCertificateUtils.generateGiftCard(GenerateGiftCertificateUtils.java:96) ~[classes/:?]
    at org.openbravo.retail.loyalty.burn.giftcertificate.process.ConsumeGiftCertificateAmount.generateGiftCertificate(ConsumeGiftCertificateAmount.java:96) ~[classes/:?]
    at org.openbravo.retail.loyalty.burn.giftcertificate.process.ConsumeGiftCertificateAmount.exec(ConsumeGiftCertificateAmount.java:54) ~[classes/:?]
    at org.openbravo.mobile.core.process.JSONProcessSimple.exec(JSONProcessSimple.java:48) ~[classes/:?]
    at org.openbravo.mobile.core.process.SecuredJSONProcess.secureExec(SecuredJSONProcess.java:63) [classes/:?]
    at org.openbravo.mobile.core.process.MobileServiceProcessor.execProcess(MobileServiceProcessor.java:131) [classes/:?]
    at org.openbravo.mobile.core.process.MobileServiceProcessor.execServiceName(MobileServiceProcessor.java:105) [classes/:?]
    at org.openbravo.mobile.core.process.MobileService.doGetOrPost(MobileService.java:194) [classes/:?]
    at org.openbravo.mobile.core.process.MobileService.doPost(MobileService.java:73) [classes/:?]
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:661) [tomcat8-servlet-api.jar:?]
    at org.openbravo.base.HttpBaseServlet.serviceInitialized(HttpBaseServlet.java:200) [openbravo-core.jar:?]
    at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:459) [classes/:?]
    at org.openbravo.client.kernel.BaseKernelServlet.callServiceInSuper(BaseKernelServlet.java:89) [classes/:?]
    at org.openbravo.mobile.core.process.WebServiceAuthenticatedServlet.service(WebServiceAuthenticatedServlet.java:67) [classes/:?]
    at org.openbravo.mobile.core.process.MobileService.service(MobileService.java:132) [classes/:?]
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:742) [tomcat8-servlet-api.jar:?]
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231) [tomcat8-catalina-8.5.39.jar:8.5.39]
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [tomcat8-catalina-8.5.39.jar:8.5.39]
    at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52) [tomcat8-websocket-8.5.39.jar:8.5.39]
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) [tomcat8-catalina-8.5.39.jar:8.5.39]
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [tomcat8-catalina-8.5.39.jar:8.5.39]
    at org.openbravo.utils.SessionExpirationFilter.doFilter(SessionExpirationFilter.java:66) [openbravo-core.jar:?]
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) [tomcat8-catalina-8.5.39.jar:8.5.39]
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [tomcat8-catalina-8.5.39.jar:8.5.39]
    at org.openbravo.utils.CharsetFilter.doFilter(CharsetFilter.java:38) [openbravo-core.jar:?]
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) [tomcat8-catalina-8.5.39.jar:8.5.39]
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [tomcat8-catalina-8.5.39.jar:8.5.39]
    at org.openbravo.client.kernel.KernelFilter$1.doAction(KernelFilter.java:65) [classes/:?]
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:47) [classes/:?]
    at org.openbravo.client.kernel.KernelFilter.doFilter(KernelFilter.java:74) [classes/:?]
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) [tomcat8-catalina-8.5.39.jar:8.5.39]
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [tomcat8-catalina-8.5.39.jar:8.5.39]
    at org.openbravo.dal.core.DalRequestFilter$1.doAction(DalRequestFilter.java:96) [classes/:?]
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:47) [classes/:?]
    at org.openbravo.dal.core.DalRequestFilter.doFilter(DalRequestFilter.java:118) [classes/:?]
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) [tomcat8-catalina-8.5.39.jar:8.5.39]
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [tomcat8-catalina-8.5.39.jar:8.5.39]
    at org.apache.logging.log4j.web.Log4jServletFilter.doFilter(Log4jServletFilter.java:71) [log4j-web-2.17.0.jar:2.17.0]
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) [tomcat8-catalina-8.5.39.jar:8.5.39]
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) [tomcat8-catalina-8.5.39.jar:8.5.39]
    at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:200) [tomcat8-catalina-8.5.39.jar:8.5.39]
    at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96) [tomcat8-catalina-8.5.39.jar:8.5.39]
    at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:493) [tomcat8-catalina-8.5.39.jar:8.5.39]
    at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:137) [tomcat8-catalina-8.5.39.jar:8.5.39]
    at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:81) [tomcat8-catalina-8.5.39.jar:8.5.39]
    at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87) [tomcat8-catalina-8.5.39.jar:8.5.39]
    at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343) [tomcat8-catalina-8.5.39.jar:8.5.39]
    at org.apache.coyote.ajp.AjpProcessor.service(AjpProcessor.java:476) [tomcat8-coyote-8.5.39.jar:8.5.39]
    at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66) [tomcat8-coyote-8.5.39.jar:8.5.39]
    at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:806) [tomcat8-coyote-8.5.39.jar:8.5.39]
    at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1498) [tomcat8-coyote-8.5.39.jar:8.5.39]
    at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49) [tomcat8-coyote-8.5.39.jar:8.5.39]
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
    at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) [tomcat8-util-8.5.39.jar:8.5.39]
    at java.lang.Thread.run(Thread.java:829) [?:?]
(0134537)
hgbot   
2022-01-25 05:31   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.burn.giftcertificate/-/merge_requests/5 [^]
(0134679)
hgbot   
2022-01-31 09:18   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.burn.giftcertificate [^]
Changeset: 27ac9cc90dab97a3a8143700eaaedab8f2d2e33b
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 24-01-2022 18:37:06
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.burn.giftcertificate/-/commit/27ac9cc90dab97a3a8143700eaaedab8f2d2e33b [^]

Fixed ISSUE-48315: Payment creation response should be validated when generating gift certificate

---
M src/org/openbravo/loyalty/burn/giftcertificate/process/GenerateGiftCertificateUtils.java
---
(0134680)
hgbot   
2022-01-31 09:18   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.burn.giftcertificate/-/merge_requests/5 [^]