Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048309POS2[Retail Modules] Web POSpublic2021-12-23 09:402022-02-04 12:57
Reporterguilleaer 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048309: Taxes are not correctly calculated for menus when tax is defined at price list level
DescriptionWhen tax category for products which are menu items is defined at the price list level verified returns calculations are not working fine
Steps To Reproduceyou have the following menu:

-Component A, Product tax rate = 10%, price list tax rate = 10%
-Component B, Product tax rate = 10%, price list tax rate = 20%

When ordering the menu, you will have the following (OK)

-Component A, tax rate = 10%
-Component B, tax rate = 20%

However, doing a verified return of the menu (KO)

- Component A, tax rate = 10%
- Component B, tax rate = 10%
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0048367TAP closed ranjith_qualiantech_com POS2 JIRA 2571 - Taxes are not correctly calculated for menus when tax is defined at price list level 
related to defect 0048248 closed ranjith_qualiantech_com Retail Modules Wrong ticket amount when doing a Verified Return of a ticket with discount 
related to defect 0048148 closed Retail POS2 Verified returns and discounts are not having a correct behavior (Umbrella issue) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-12-23 09:40guilleaerNew Issue
2021-12-23 09:40guilleaerAssigned To => Retail
2021-12-23 09:40guilleaerTriggers an Emergency Pack => No
2021-12-23 09:42guilleaerRelationship addedrelated to 0048248
2021-12-23 09:42guilleaerAssigned ToRetail => ranjith_qualiantech_com
2021-12-23 09:48guilleaerRelationship addedrelated to 0048148
2021-12-23 10:03guilleaerStatusnew => acknowledged
2021-12-27 14:35ranjith_qualiantech_comStatusacknowledged => scheduled
2022-01-02 18:55hgbotNote Added: 0134090
2022-01-03 14:21hgbotNote Added: 0134100
2022-01-03 14:21hgbotResolutionopen => fixed
2022-01-03 14:21hgbotStatusscheduled => closed
2022-01-03 14:21hgbotNote Added: 0134101
2022-01-10 16:38guilleaerStatusclosed => new
2022-01-10 16:38guilleaerResolutionfixed => open
2022-01-10 16:38guilleaerStatusnew => scheduled
2022-01-10 16:38guilleaerStatusscheduled => resolved
2022-01-10 16:38guilleaerResolutionopen => fixed
2022-01-10 16:38guilleaerStatusresolved => closed
2022-01-10 16:39guilleaerProjectRetail Modules => POS2
2022-01-10 16:40guilleaerStatusclosed => new
2022-01-10 16:40guilleaerResolutionfixed => open
2022-01-10 16:40guilleaerStatusnew => scheduled
2022-01-10 16:40guilleaerStatusscheduled => resolved
2022-01-10 16:40guilleaerResolutionopen => fixed
2022-01-10 16:40guilleaerStatusresolved => closed
2022-01-28 11:11jmelinAssigned Toranjith_qualiantech_com => Retail
2022-01-28 11:11jmelinNote Added: 0134647
2022-01-28 11:11jmelinStatusclosed => new
2022-01-28 11:11jmelinResolutionfixed => open
2022-01-28 11:12jmelinNote Edited: 0134647bug_revision_view_page.php?bugnote_id=0134647#r23586
2022-02-02 07:19ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2022-02-02 07:19ranjith_qualiantech_comStatusnew => scheduled
2022-02-02 07:20hgbotNote Added: 0134722
2022-02-02 07:20hgbotNote Added: 0134723
2022-02-02 14:48hgbotNote Added: 0134734
2022-02-03 09:25hgbotNote Added: 0134747
2022-02-03 09:25hgbotNote Added: 0134748
2022-02-03 09:25hgbotNote Added: 0134749
2022-02-03 09:25hgbotNote Added: 0134750
2022-02-03 15:34hgbotResolutionopen => fixed
2022-02-03 15:34hgbotStatusscheduled => closed
2022-02-03 15:34hgbotNote Added: 0134767
2022-02-03 15:34hgbotNote Added: 0134768
2022-02-04 10:29guilleaerNote Added: 0134781
2022-02-04 10:29guilleaerStatusclosed => new
2022-02-04 10:29guilleaerResolutionfixed => open
2022-02-04 10:29guilleaerStatusnew => scheduled
2022-02-04 12:50hgbotNote Added: 0134786
2022-02-04 12:57hgbotResolutionopen => fixed
2022-02-04 12:57hgbotStatusscheduled => closed
2022-02-04 12:57hgbotNote Added: 0134787
2022-02-04 12:57hgbotFixed in Version => RR22Q2
2022-02-04 12:57hgbotNote Added: 0134788

Notes
(0134090)
hgbot   
2022-01-02 18:55   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/103 [^]
(0134100)
hgbot   
2022-01-03 14:21   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/103 [^]
(0134101)
hgbot   
2022-01-03 14:21   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^]
Changeset: aca6d898134869edf0ea90ef42142050460797c4
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 02-01-2022 22:26:03
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/aca6d898134869edf0ea90ef42142050460797c4 [^]

Fixed ISSUE-48309: NetUnitAmount should be updated when loading menu items

---
M src/org/openbravo/pos2/restaurant/hook/AddMenuItemsToPaidReceipt.java
M web-jspack/org.openbravo.pos2.restaurant/src/model/food-menu/GetMenuTaxesInfo.js
---
(0134647)
jmelin   
2022-01-28 11:11   
(edited on: 2022-01-28 11:12)
The taxes are not correct when doing a verified return of a menu with 2 differents taxes

On livebuild tap,

In back-office, open the price list "The White Valley Group Sale Price List"
Open the version
Look for product "Beer 0.5L" and select it.
Change to vat to "IVA Reducido" and save

Connect to POS VBS-2
Refresh master data
Switch to schema "Restaurant" and category "Menu"
Add a "Grouped menu" and select any starter and main course, but 2 "Beer 0.5L" as beverage.
Pay the order and close it.

Open sales order history window and select the previous order to do a verifed return.
Refund the payment and close the return

Go to backoffice.
Open the "sales order" => you must have 2 taxes
Open the "Return from customer" of the previous => KO, you only have 1 tax
The tax of the returned product/menu must be the same at the time it was bought
(0134722)
hgbot   
2022-02-02 07:20   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/705 [^]
(0134723)
hgbot   
2022-02-02 07:20   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/111 [^]
(0134734)
hgbot   
2022-02-02 14:48   
Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/163 [^]
(0134747)
hgbot   
2022-02-03 09:25   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 4f97c560f7ad25dd109096d5167cee8d0b46b8a8
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 03-02-2022 08:25:22
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/4f97c560f7ad25dd109096d5167cee8d0b46b8a8 [^]

Related to ISSUE-48309: Added PriceListVersion to PaidReceipt Response

---
M src/org/openbravo/retail/posterminal/PaidReceipts.java
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/LoadTicketUtils.js
M web/org.openbravo.retail.posterminal/js/components/modal-pay-open-tickets.js
M web/org.openbravo.retail.posterminal/js/components/modalorderselector.js
M web/org.openbravo.retail.posterminal/js/utils/orderSelectorUtils.js
---
(0134748)
hgbot   
2022-02-03 09:25   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/705 [^]
(0134749)
hgbot   
2022-02-03 09:25   
Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/163 [^]
(0134750)
hgbot   
2022-02-03 09:25   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 5e0642b97281de3a389afcbf8c8f354f0a27eb23
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 03-02-2022 08:24:22
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/5e0642b97281de3a389afcbf8c8f354f0a27eb23 [^]

Verifies ISSUE-48309: Added test I48309_VerifyPropertyInLoadedReceipt

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I48309_VerifyPropertyInLoadedReceipt.java
---
(0134767)
hgbot   
2022-02-03 15:34   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^]
Changeset: 0f3cc5bfe4273235fccfe420acd0967dc2b4c88d
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 03-02-2022 14:34:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/0f3cc5bfe4273235fccfe420acd0967dc2b4c88d [^]

Fixed ISSUE-48309: Menu Item TaxCategory should be loaded based on Price TaxCategory

---
M src/org/openbravo/pos2/restaurant/hook/AddMenuItemsToPaidReceipt.java
---
(0134768)
hgbot   
2022-02-03 15:34   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/111 [^]
(0134781)
guilleaer   
2022-02-04 10:29   
reopened. Date to pick price list version should be the one of the order
(0134786)
hgbot   
2022-02-04 12:50   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/707 [^]
(0134787)
hgbot   
2022-02-04 12:57   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/707 [^]
(0134788)
hgbot   
2022-02-04 12:57   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: a45f14952c148184937443c2bb4de9af6834bcc3
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 04-02-2022 11:57:52
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/a45f14952c148184937443c2bb4de9af6834bcc3 [^]

Fixed ISSUE-48309: PaidReceipt PriceListVersion should be updated with OrderDate

---
M src/org/openbravo/retail/posterminal/PaidReceipts.java
---