Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048302POS2POSpublic2021-12-21 16:202024-03-06 19:19
Reporterjmelin 
Assigned ToRetail 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048302: JIRA 2580 - Verified Return - Its popup should set the line quantity to return and update remaining quantity
DescriptionCurrent behaviour en POS2:

- Verify returns popup works as a wizard, in terms of the user can select lines and quantities to return. These lines are added to the receipt. This flow DOES NOT override the previous value.

This behaviour is not correct. The application should override the quantity to return if there is a previous line with return any quantity of that product.

Apart from that, in the popup, for each line there is a remaining quantity. This value should be updated if some subset of the line was added before.
Steps To ReproduceDo an order and add a product with a quantity > 1
Complete the order

Look for the order and do a verified return
Select the product and a quantity of 1
=> OK; 1 line with qty 1 to return
Without closing the opened return, do a verified return of the same order and update the qty to 2.
=> KO; in the verified returns popup, the remaining line qty should be the initial quantity - 1
=> KO; 1 line with qtr 3, should be 3
Proposed SolutionTHIS FEATURE ONLY AFFECTS TO NEW POS. THE OLD VERSION WORKS AS EXPECTED

- Instead of launch an add product user action, the line quantity should be set.
- Update remaining quantity after all.
Additional Information
TagsEBE - Valid Revision
Relationships
depends on backport 0048352TAP closed javierRodriguez JIRA 2580 - Verified Return - Its popup should set the line quantity to return and update remaining quantity 
blocks defect 0048148 closed Retail Verified returns and discounts are not having a correct behavior (Umbrella issue) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-12-21 16:20jmelinNew Issue
2021-12-21 16:20jmelinAssigned To => Retail
2021-12-21 16:20jmelinTriggers an Emergency Pack => No
2021-12-23 09:59guilleaerRelationship addedblocks 0048148
2021-12-23 10:01guilleaerTarget VersionTAP =>
2021-12-23 10:03guilleaerStatusnew => acknowledged
2022-01-03 09:01jorge-garciaAssigned ToRetail => jorge-garcia
2022-01-04 13:04jorge-garciaStatusacknowledged => scheduled
2022-01-04 15:59hgbotNote Added: 0134113
2022-01-04 16:07hgbotNote Added: 0134114
2022-01-05 10:26jorge-garciaReview Assigned To => migueldejuana
2022-01-10 11:20hgbotResolutionopen => fixed
2022-01-10 11:20hgbotStatusscheduled => closed
2022-01-10 11:20hgbotNote Added: 0134163
2022-01-10 11:20hgbotFixed in Version => RR22Q2
2022-01-10 11:20hgbotNote Added: 0134164
2022-01-10 11:21hgbotNote Added: 0134165
2022-01-10 11:21hgbotNote Added: 0134166
2022-01-20 15:25jmelinNote Added: 0134416
2022-01-20 15:25jmelinStatusclosed => new
2022-01-20 15:25jmelinFixed in VersionRR22Q2 =>
2022-01-20 15:26jmelinNote Edited: 0134416bug_revision_view_page.php?bugnote_id=0134416#r23553
2022-01-20 15:27jmelinNote Edited: 0134416bug_revision_view_page.php?bugnote_id=0134416#r23554
2022-01-27 15:43elaraAssigned Tojorge-garcia => elara
2022-01-27 15:44elaraStatusnew => scheduled
2022-01-27 16:13guilleaerStatusscheduled => acknowledged
2022-01-27 16:13guilleaerStatusacknowledged => scheduled
2022-01-27 16:13guilleaerAssigned Toelara => javierRodriguez
2022-01-28 13:20javierRodriguezSummaryJIRA 2580 - Verified Return - Discount amount is not correct when updating a product qty => JIRA 2580 - Verified Return - Its popup should set the line quantity to return and update remaining quantity
2022-01-28 13:20javierRodriguezDescription Updatedbug_revision_view_page.php?rev_id=23590#r23590
2022-01-28 13:20javierRodriguezSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=23592#r23592
2022-01-28 13:20javierRodriguezProposed Solution updated
2022-01-31 13:30javierRodriguezProposed Solution updated
2022-02-01 09:19guilleaerNote Added: 0134695
2022-09-16 10:41guilleaerAssigned TojavierRodriguez => Retail
2022-09-16 10:41guilleaerStatusscheduled => acknowledged
2023-05-12 11:58ebecerraTag Attached: EBE - Valid Revision
2024-03-06 19:18Daria_ShStatusacknowledged => scheduled
2024-03-06 19:19Daria_ShReview Assigned Tomigueldejuana =>
2024-03-06 19:19Daria_ShNote Added: 0161791
2024-03-06 19:19Daria_ShStatusscheduled => closed

Notes
(0134113)
hgbot   
2022-01-04 15:59   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/768 [^]
(0134114)
hgbot   
2022-01-04 16:07   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/merge_requests/35 [^]
(0134163)
hgbot   
2022-01-10 11:20   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/merge_requests/35 [^]
(0134164)
hgbot   
2022-01-10 11:20   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns [^]
Changeset: 3fa33a6121df78de0bea3239d1647cb64ae939fa
Author: Jorge Garcia <jorge.garcia@openbravo.com>
Date: 04-01-2022 16:05:37
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/commit/3fa33a6121df78de0bea3239d1647cb64ae939fa [^]

Fixed ISSUE-48302: Calculate promotion amount and gross and net
amount of a verified line with correct quantity

Update unitary tests to include grossUnitPrice and baseNetUnitPrice
values for verified return lines.

---
M web-test/model/business-object/ticket/actions/ReturnVerifiedTicket.test.js
M web/org.openbravo.retail.returns/app/model/business-object/ticket/actions/ReturnVerifiedTicket.js
---
(0134165)
hgbot   
2022-01-10 11:21   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 8f1209948534492fabaee5e88cca2314b5514e86
Author: Jorge Garcia <jorge.garcia@openbravo.com>
Date: 10-01-2022 11:16:48
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/8f1209948534492fabaee5e88cca2314b5514e86 [^]

Related to ISSUE-48302: Send correct qty information to ticket state action

---
M web-jspack/org.openbravo.pos2/src/components/VerifiedReturns/VerifiedReturnsForm/VerifiedReturnsForm.jsx
---
(0134166)
hgbot   
2022-01-10 11:21   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/768 [^]
(0134416)
jmelin   
2022-01-20 15:25   
(edited on: 2022-01-20 15:27)
On livebuild,
create an order
add 10 “Avalanche receiver”
click on the product in the order and apply a discount of 5%
pay by Cash


Do a verified return and select a qty of 2
=> OK

Keep the order opened, and execute verified return again, but change the quantity from 2 to 4
=> KO, expect quantity to be 4 and not 6 and discount should be 30.10

(note : there a double negative before the discount amount, I think this should be removed if the discount is positive in a return)
(0134695)
guilleaer   
2022-02-01 09:19   
On 28/01 we have updated issue details to match with the investigation done
(0161791)
Daria_Sh   
2024-03-06 19:19   
Tested in livebuilds master and confirmed the issue is not reproducible