Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048297Retail ModulesDiscounts and Promotionspublic2021-12-21 15:002022-09-08 16:02
Reporterpsanjuan 
Assigned Topsanjuan 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048297: Discount filter enhancement : Filter by “summary level” product categories - NOE 5219 and 5351 - Jira RM-114
DescriptionOpenbravo should enhance the product categories filter of the discounts. Currently, the filter doesn’t use the product category tree to filter the products of a promotion. It means, the product has to be affected to this specific category.
Steps To ReproduceN/A
Proposed SolutionSee:
https://docs.google.com/document/d/1bsARPNIV5K2EQyx91HgV2OPuPDQFCdvoLcd29wdchHI/edit#heading=h.pptg8m3qzp7u [^]
Additional Information
TagsNOR
Relationships
related to defect 0050197 closed rtoledano Error handling duplicated records for add organization, product and product categories in Discount and Promotion windows 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-12-21 15:00psanjuanNew Issue
2021-12-21 15:00psanjuanAssigned To => Retail
2021-12-21 15:00psanjuanOBNetwork customer => No
2021-12-21 15:00psanjuanTriggers an Emergency Pack => No
2021-12-21 15:01psanjuanDescription Updatedbug_revision_view_page.php?rev_id=23440#r23440
2021-12-21 15:03psanjuanSummaryDiscount filter enhancement : Filter by “summary level” product categories - NOE 5219 and 5351 => Discount filter enhancement : Filter by “summary level” product categories - NOE 5219 and 5351 - Jira RM-114
2021-12-21 15:27psanjuanAssigned ToRetail => psanjuan
2021-12-23 00:20rafarodaTag Attached: NOR
2022-08-29 02:56hgbotMerge Request Status => open
2022-08-29 02:56hgbotNote Added: 0140444
2022-08-29 02:57hgbotNote Added: 0140445
2022-09-06 07:15hgbotMerge Request Statusopen => approved
2022-09-06 07:17hgbotNote Added: 0140729
2022-09-06 07:17hgbotNote Added: 0140730
2022-09-06 07:17hgbotResolutionopen => fixed
2022-09-06 07:17hgbotStatusnew => closed
2022-09-06 07:17hgbotNote Added: 0140731
2022-09-06 07:17hgbotFixed in Version => PR22Q4
2022-09-06 07:17hgbotNote Added: 0140732
2022-09-06 07:17hgbotNote Added: 0140733
2022-09-06 07:17hgbotNote Added: 0140734
2022-09-08 16:02rafarodaRelationship addedrelated to 0050197

Notes
(0140444)
hgbot   
2022-08-29 02:56   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/695 [^]
(0140445)
hgbot   
2022-08-29 02:57   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/17 [^]
(0140729)
hgbot   
2022-09-06 07:17   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 5f9088833681521c6be587d0aa5e3d1c69e6b596
Author: Roberto Carlos Toledano Gómez <rctg82@gmail.com>
Date: 05-09-2022 15:07:25
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/5f9088833681521c6be587d0aa5e3d1c69e6b596 [^]

Related to ISSUE-48297: Discount window Product Category filter enhancement.

Now if user select a summary level product category, all non-summary level child product categories are added to the subtab

---
M src/org/openbravo/common/actionhandler/OfferPickProductCategoryActionHandler.java
---
(0140730)
hgbot   
2022-09-06 07:17   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 4fdbe5c32131c216ac1fa8f387c77dc6c2a2d404
Author: Roberto Carlos Toledano Gómez <rctg82@gmail.com>
Date: 05-09-2022 15:07:25
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/4fdbe5c32131c216ac1fa8f387c77dc6c2a2d404 [^]

Related to ISSUE-48297: Added new preference "Add Last Level Children in Add button" to filter the Product categories shown on Discount window when user click on Add Product category button.

  When "Add Last Level Children in Add button" = 'Y' (Default value) all Product categories are shown.

    When "Add Last Level Children in Add button" = 'N' (Default value) Product category with summaryLevel = true are shown

---
M src-db/database/sourcedata/AD_PREFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-db/database/sourcedata/AD_TAB.xml
---
(0140731)
hgbot   
2022-09-06 07:17   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/695 [^]
(0140732)
hgbot   
2022-09-06 07:17   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: d7fca866a581b7515851614963d0b32240612d68
Author: Roberto Carlos Toledano Gómez <rctg82@gmail.com>
Date: 05-09-2022 12:35:05
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/d7fca866a581b7515851614963d0b32240612d68 [^]

Fixed ISSUE-48297: Added new preference "Add Last Level Children in Add button" to filter the Product categories shown on Discount window when user click on Add Product category button.

---
M src-db/database/sourcedata/AD_PREFERENCE.xml
M src-db/database/sourcedata/AD_TAB.xml
M src/org/openbravo/common/actionhandler/OfferPickProductCategoryActionHandler.java
---
(0140733)
hgbot   
2022-09-06 07:17   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf [^]
Changeset: 0ad53a1466320d45edda75a198b3c9f3e3491a97
Author: Roberto Carlos Toledano Gómez <rctg82@gmail.com>
Date: 06-09-2022 05:17:29
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/commit/0ad53a1466320d45edda75a198b3c9f3e3491a97 [^]

Related to ISSUE-48297: OTF Rule window Product Category filter enhancement.

---
M src-db/database/sourcedata/AD_TAB.xml
M src/org/openbravo/retail/discounts/coupons/otf/handler/PickProductCategoryActionHandler.java
---
(0140734)
hgbot   
2022-09-06 07:17   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/17 [^]