Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048248Retail ModulesWeb POSpublic2021-12-14 12:192021-12-29 06:33
Reporteraferraz 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR22Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2021-07-07
Regression introduced in releaseRR21Q4
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/47c20b2a17f30c967126313c475d1c79e903c047 [^]
Triggers an Emergency PackNo
Summary0048248: Wrong ticket amount when doing a Verified Return of a ticket with discount
DescriptionWrong ticket amount when doing a Verified Return of a ticket with discount.

Jest tests should be added for 0047254 and 0048248.
Steps To Reproduce- In Backoffice, Create a Discount and Promotion of type Fixed Discount per Total Amount and amount 10.
- In POS2, create a ticket with one unit of Avalanche transceiver, add previously created Order Discount and complete. Check ticket amount is 140.50€.
- In POS2, create verified return for previously created ticket. Check ticket amount is 130.50€. This is not correct.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0048309 closed ranjith_qualiantech_com POS2 Taxes are not correctly calculated for menus when tax is defined at price list level 
depends on backport 0048318RR21Q4.3 closed ranjith_qualiantech_com Retail Modules Wrong ticket amount when doing a Verified Return of a ticket with discount 
caused by defect 0047254 closed rqueralta Retail Modules Error when making a verified return when there is a promotion 
related to defect 0048234 closed sntgreale POS2 Verified returns and discounts are not having a correct behavior - Case 3 
related to defect 0048273 closed ranjith_qualiantech_com POS2 Jira 2579 [TAP] The rounding calculation is not always correct in verified return with discount 
blocks defect 0048148 closed Retail POS2 Verified returns and discounts are not having a correct behavior (Umbrella issue) 
blocks backport 0048368TAP closed ranjith_qualiantech_com POS2 Backport issue 48248 to TAP - JIRA 2588 - Wrong ticket amount when doing a Verified Return of a ticket with discount 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-12-14 12:19aferrazNew Issue
2021-12-14 12:19aferrazAssigned To => Retail
2021-12-14 12:19aferrazRegression level => Production - Confirmed Stable
2021-12-14 12:19aferrazRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/47c20b2a17f30c967126313c475d1c79e903c047 [^]
2021-12-14 12:19aferrazTriggers an Emergency Pack => No
2021-12-14 12:21aferrazDescription Updatedbug_revision_view_page.php?rev_id=23402#r23402
2021-12-14 12:21aferrazRelationship addedcaused by 0047254
2021-12-14 12:22aferrazRelationship addedrelated to 0048234
2021-12-15 15:49aferrazProjectPOS2 => Retail Modules
2021-12-15 15:50aferrazCategoryPOS => Web POS
2021-12-16 08:12ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2021-12-23 09:33guilleaerNote Added: 0133928
2021-12-23 09:42guilleaerRelationship addedrelated to 0048309
2021-12-23 09:49guilleaerRelationship addedblocks 0048148
2021-12-23 10:03guilleaerStatusnew => acknowledged
2021-12-24 08:47hgbotNote Added: 0133939
2021-12-24 09:10ranjith_qualiantech_comRegression date => 2021-07-07
2021-12-24 09:10ranjith_qualiantech_comRegression introduced in release => RR21Q4
2021-12-24 09:11marvintmStatusacknowledged => scheduled
2021-12-29 06:33hgbotResolutionopen => fixed
2021-12-29 06:33hgbotStatusscheduled => closed
2021-12-29 06:33hgbotNote Added: 0134033
2021-12-29 06:33hgbotFixed in Version => RR22Q1
2021-12-29 06:33hgbotNote Added: 0134034
2022-01-10 16:44guilleaerRelationship addedblocks 0048368
2022-01-12 08:42ranjith_qualiantech_comRelationship addedrelated to 0048273

Notes
(0133928)
guilleaer   
2021-12-23 09:33   
JIRA from AGP associated

https://openbravo.atlassian.net/browse/FLUN-2588 [^]
(0133939)
hgbot   
2021-12-24 08:47   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/669 [^]
(0134033)
hgbot   
2021-12-29 06:33   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/669 [^]
(0134034)
hgbot   
2021-12-29 06:33   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 9e1b767aa106a44935d5f591bbc3f3f2a0a4eff0
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 29-12-2021 05:33:24
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/9e1b767aa106a44935d5f591bbc3f3f2a0a4eff0 [^]

Fixed ISSUE-48248: DiscountAmount should not be used to calculate line Gross Amount
* When calculating line gross amount with skipPromotion enabled,
  discount amount should not be used to calculate line Gross Amount,
  since gross amount already adjusted with discount amount

---
M web-test/model/business-object/ticket/CalculateTotalsModelHook.test.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/TicketUtils.js
---