Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048234POS2POSpublic2021-12-13 12:232021-12-15 08:55
Reporteraferraz 
Assigned Tosntgreale 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048234: Verified returns and discounts are not having a correct behavior - Case 3
DescriptionThanks to byTotal discount module POS2 is able to manage different types of discounts; By Line and by total.
A new flag was created in organization to show by total modules in a separated section

Needs to be checked this combination of configurations because they are not working well

case 3: order discount - different section flag enabled
Create an order - OK
Prepare Verified Return - KO
-> price not shown
-> discount not shown (in this popup different section flag should not appear)
LOADED VR as a ticket - KO
-> price not shown
Simply load order - OK
Steps To ReproduceCreate an order
apply discount (depending on the example to reproduce)
pay the order
go to orders window
click three dots button and press verified return

More detailed info and screenshots in this document
https://docs.google.com/document/d/1sW4beJvcushwwNXiPLY4LEk33xic6Z7DhZCh-XC94fc [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0048247 closed prakashmurugesan88 POS2 JIRA 2490 - Wrong behavior when external system discount are applied 
related to defect 0048248 closed ranjith_qualiantech_com Retail Modules Wrong ticket amount when doing a Verified Return of a ticket with discount 
depends on backport 0048240TAP closed sntgreale POS2 Verified returns and discounts are not having a correct behavior - Case 3 
related to defect 0048187TAP closed guilleaer POS2 JIRA 2534 (Custom) - Blocking error when returning a ticket 
blocks defect 0048148 closed Retail POS2 Verified returns and discounts are not having a correct behavior (Umbrella issue) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-12-13 12:23aferrazNew Issue
2021-12-13 12:23aferrazAssigned To => sntgreale
2021-12-13 12:23aferrazTriggers an Emergency Pack => No
2021-12-13 12:23aferrazIssue generated from0048148
2021-12-13 12:23aferrazRelationship addedblocks 0048148
2021-12-13 13:14hgbotNote Added: 0133646
2021-12-13 16:34aferrazSummaryVerified returns and discounts are not having a correct behavior (diferent combinations) => Verified returns and discounts are not having a correct behavior - Case 3
2021-12-13 16:34aferrazDescription Updatedbug_revision_view_page.php?rev_id=23396#r23396
2021-12-13 16:35aferrazStatusnew => scheduled
2021-12-13 18:03hgbotNote Added: 0133664
2021-12-14 12:08aferrazRelationship addedrelated to 0048247
2021-12-14 12:22aferrazRelationship addedrelated to 0048248
2021-12-15 08:54hgbotResolutionopen => fixed
2021-12-15 08:54hgbotStatusscheduled => closed
2021-12-15 08:54hgbotNote Added: 0133710
2021-12-15 08:54hgbotNote Added: 0133711
2021-12-15 08:55hgbotNote Added: 0133712
2021-12-15 08:55hgbotNote Added: 0133713
2021-12-17 09:55caristuRelationship addedrelated to 0048187

Notes
(0133646)
hgbot   
2021-12-13 13:14   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/656 [^]
(0133664)
hgbot   
2021-12-13 18:03   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/751 [^]
(0133710)
hgbot   
2021-12-15 08:54   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 51cddf1c59855f458fdc3e14e2251c438e79957d
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 15-12-2021 07:54:01
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/51cddf1c59855f458fdc3e14e2251c438e79957d [^]

Fixed ISSUE-48234: Correct calculation of the amounts required for Verified Return.

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/TicketUtils.js
---
(0133711)
hgbot   
2021-12-15 08:54   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/656 [^]
(0133712)
hgbot   
2021-12-15 08:55   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/751 [^]
(0133713)
hgbot   
2021-12-15 08:55   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 7b2a6d9722ace944bcaf387a5283ab2f1c26decd
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 15-12-2021 07:55:24
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/7b2a6d9722ace944bcaf387a5283ab2f1c26decd [^]

Fixes ISSUE-48234: Display line price correctly when doing a return of an...

---
A web-jspack/org.openbravo.pos2/src/components/VerifiedReturns/VerifiedReturnsGrid/VerifiedReturnTicketLine.config.json
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLineDiscount/TicketLineDiscount.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePrice/TicketLinePrice.jsx
M web-jspack/org.openbravo.pos2/src/components/TicketLineRenderCell/TicketLineRenderCell.jsx
M web-jspack/org.openbravo.pos2/src/components/TicketLineRenderCell/__test__/TicketLineRenderCell.test.jsx
M web-jspack/org.openbravo.pos2/src/components/VerifiedReturns/VerifiedReturnsGrid/VerifiedReturnsGrid.jsx
M web-jspack/org.openbravo.pos2/src/components/VerifiedReturns/VerifiedReturnsGrid/__test__/VerifiedReturnsGrid.test.jsx
M web-jspack/org.openbravo.pos2/src/components/VerifiedReturns/VerifiedReturnsGrid/stories/VerifiedReturnsGrid.stories.jsx
M web-jspack/org.openbravo.pos2/src/ob-init.js
---