Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048206Openbravo ERPA. Platformpublic2021-12-08 14:552021-12-09 15:23
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR22Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048206: Delete long obsolete OpenPentaho integration code
DescriptionIntegration code exists for marking an ad_process entry as:
- isexternalservice
- server_type=PS (Pentaho Sevice)
- and specifying an service_source URL

Defined as such it allows to load that external url inside Openbravo.

That long is long obsolete and should be removed
Steps To Reproducegrep -Iir OpenPentaho
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0048209 closed alostale Openbravo ERP API change: removed OpenPentaho integration 
related to defect 0048207 closed shuehner Retail Modules mobile.core: Delete long obsolete OpenPentaho integration code 
related to defect 0048214 new Triage Platform Base Openbravo ERP Simplify SeguridadData.selectAccess method 
blocks design defect 0032688 acknowledged Triage Platform Base Openbravo ERP remove unused resources 
blocks defect 0048208 closed shuehner Openbravo ERP Cleanup left over code from 2.50 UI (WindowsTabs,LeftTabsBar,NavigationBar) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-12-08 14:55shuehnerNew Issue
2021-12-08 14:55shuehnerAssigned To => Triage Platform Base
2021-12-08 14:55shuehnerOBNetwork customer => No
2021-12-08 14:55shuehnerModules => Core
2021-12-08 14:55shuehnerTriggers an Emergency Pack => No
2021-12-08 14:55shuehnerRelationship addedblocks 0032688
2021-12-08 14:55shuehnerAssigned ToTriage Platform Base => shuehner
2021-12-08 14:57shuehnerIssue cloned0048207
2021-12-08 14:57shuehnerRelationship addedrelated to 0048207
2021-12-08 15:06hgbotMerge Request Status => open
2021-12-08 15:06hgbotNote Added: 0133520
2021-12-08 17:30shuehnerRelationship addedblocks 0048208
2021-12-09 09:18alostaleRelationship addeddepends on 0048209
2021-12-09 14:17alostaleRelationship addedrelated to 0048214
2021-12-09 15:14hgbotMerge Request Statusopen => approved
2021-12-09 15:15hgbotNote Added: 0133572
2021-12-09 15:15hgbotNote Added: 0133573
2021-12-09 15:23alostaleStatusnew => scheduled
2021-12-09 15:23alostaleStatusscheduled => resolved
2021-12-09 15:23alostaleFixed in Version => PR22Q1
2021-12-09 15:23alostaleFixed in SCM revision => https://gitlab.com/openbravo/product/openbravo/-/commit/00f7d371dfeb7c122dec427c4241a88d4176dda6 [^]
2021-12-09 15:23alostaleResolutionopen => fixed
2021-12-09 15:23alostaleStatusresolved => closed

Notes
(0133520)
hgbot   
2021-12-08 15:06   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/466 [^]
(0133572)
hgbot   
2021-12-09 15:15   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 00f7d371dfeb7c122dec427c4241a88d4176dda6
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-12-09T13:26:47+01:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/00f7d371dfeb7c122dec427c4241a88d4176dda6 [^]

Fix ISSUE-48206: Remove obsolete pentaho integration code.

That code is long obsolete and unused. Remove it:
- GlobalMenu to build links to OpenPentaho servlet
- OpenPentaho servlet and xsql file
- Openbravo.properties.template pentahoServer entry
  - HttpSecureAppServlet storing that in http session
    - Related issue 48207 does cleanup in mobile.core
- ad_process columns related to this
  - service_source column
  - service_type column (and ad_ref_list entry)

---
M config/Openbravo.properties.template
M modules/org.openbravo.client.application/src/org/openbravo/client/application/GlobalMenu.java
M src-db/database/model/tables/AD_PROCESS.xml
M src-db/database/model/triggers/AD_PROCESS_MOD_TRG.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-db/database/sourcedata/AD_TEXTINTERFACES.xml
M src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
R src/org/openbravo/erpCommon/utility/OpenPentaho.html
R src/org/openbravo/erpCommon/utility/OpenPentaho.java
R src/org/openbravo/erpCommon/utility/OpenPentaho.xml
R src/org/openbravo/erpCommon/utility/OpenPentaho_data.xsql
---
(0133573)
hgbot   
2021-12-09 15:15   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/466 [^]