Openbravo Issue Tracking System - Localization Pack: Spain
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048184Localization Pack: SpainAEAT 349public2021-12-01 11:302022-01-25 12:45
Reporterpsanjuan 
Assigned Tomgonzalezh 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary0048184: It is required to remove the logic that add "Country ISO Code" to the BP Tax ID
DescriptionIt is required to remove the logic that add "Country ISO Code" to the BP Tax ID
Steps To ReproduceCreate a BP located in Irlanda del Norte.
According to SII rules its Tax ID must start by XI to highlight it continues being part of EU.

349 module adds on top of that TAX ID (ie. XI123456789) UK country code, therefore final BP Tax ID is set to GBXI123456789 wich is wrong.

OB customers are now conscious that it is required to fill NOIs correctly as that is a must for other features such as SII.

Proposed SolutionIt is required to remove the logic that add "Country ISO Code" to the BP Tax ID.
An email will be sent to the partner to inform about this change.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-12-01 11:30psanjuanNew Issue
2021-12-01 11:30psanjuanAssigned To => Jorge Bravo
2021-12-01 11:30psanjuanOBNetwork customer => No
2021-12-07 08:25Jorge BravoAssigned ToJorge Bravo => mgonzalezh
2022-01-11 20:39hgbotMerge Request Status => open
2022-01-11 20:39hgbotNote Added: 0134236
2022-01-19 09:27Jorge BravoNote Added: 0134375
2022-01-25 12:45hgbotMerge Request Statusopen => approved
2022-01-25 12:45hgbotResolutionopen => fixed
2022-01-25 12:45hgbotStatusnew => closed
2022-01-25 12:45hgbotNote Added: 0134551
2022-01-25 12:45hgbotNote Added: 0134552

Notes
(0134236)
hgbot   
2022-01-11 20:39   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.aeat349.es/-/merge_requests/2 [^]
(0134375)
Jorge Bravo   
2022-01-19 09:27   
TEST PLAN:
1 - Crear un BP ubicado en Irlanda del Norte.
De acuerdo con las reglas del SII, su identificación fiscal debe comenzar por XI para resaltar que continúa siendo parte de la UE.

2 - Generar el fichero del modelo 349, el cual ya no agrega agrega además de esa identificación fiscal (es decir, XI123456789) el código de país del Reino Unido.
(0134551)
hgbot   
2022-01-25 12:45   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.aeat349.es [^]
Changeset: b978a7c42ae86f7f3ad1a4b0e8192d13ca0950b5
Author: Maykel Gonzalez <maykel.gonzalez@smfconsulting.es>
Date: 25-01-2022 11:45:56
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.aeat349.es/-/commit/b978a7c42ae86f7f3ad1a4b0e8192d13ca0950b5 [^]

Fixes BUG-48184: It is required to remove the logic that add "Country ISO Code" to the BP Tax ID

---
M src-db/database/sourcedata/AD_MODULE.xml
M src/org/openbravo/module/aeat349/es/AEAT3492010Report.java
M src/org/openbravo/module/aeat349/es/AEAT3492010ReportDao.java
M src/org/openbravo/module/aeat349/es/AEAT349Report.java
M src/org/openbravo/module/aeat349/es/AEAT349ReportDao.java
---
(0134552)
hgbot   
2022-01-25 12:45   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.aeat349.es/-/merge_requests/2 [^]