Openbravo Issue Tracking System - POS2 |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0048161 | POS2 | POS | public | 2021-11-25 13:00 | 2023-01-09 18:59 |
|
| Reporter | caristu | |
| Assigned To | cberner | |
| Priority | high | Severity | minor | Reproducibility | have not tried |
| Status | scheduled | Resolution | open | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0048161: Still some UI properties added to the product when it is included into the ticket |
| Description | When adding a product into the ticket, it is still added with extra (unneeded) properties coming from the UI components. This information should not be included as part of the Ticket (business logic)
Note that this was partially solved with issue 0046594 where keymap specific properties are being removed. |
| Steps To Reproduce | 1- Add a product into the ticket
2- In dev tools type "OB.App.State.getState().Ticket.lines[0].product" in order to check the information of the added product. Note it contains some properties which are coming from the ProductButton component itself: "variantClass", "variantStyle", "leftAction" etc. |
| Proposed Solution | - Ideally the component should receive a product object with just the specific product information
- Note that some components are affected by this change: the ProductPopoverButtonBar component does: payload.product.leftAction, the product is received from the state (state.UI.productPopOverInformation) where previously it has been stored in the state including the UI specific properties. |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0046594 | | closed | Retail | UI properties added to the product when it is included into the ticket | | related to | defect | 0048188 | | acknowledged | Triage Platform Base | Replace ProductPopoverButtonBar global state usage with a React context |
|
| Attached Files |  props.png (31,292) 2021-11-25 13:01
https://issues.openbravo.com/file_download.php?file_id=16400&type=bug
|
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2021-11-25 13:00 | caristu | New Issue | |
| 2021-11-25 13:00 | caristu | Assigned To | => Retail |
| 2021-11-25 13:00 | caristu | Triggers an Emergency Pack | => No |
| 2021-11-25 13:00 | caristu | Issue generated from | 0046594 |
| 2021-11-25 13:00 | caristu | Relationship added | related to 0046594 |
| 2021-11-25 13:01 | caristu | File Added: props.png | |
| 2021-12-01 12:20 | caristu | Description Updated | bug_revision_view_page.php?rev_id=23375#r23375 |
| 2021-12-01 12:20 | caristu | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=23377#r23377 |
| 2021-12-01 17:51 | caristu | Proposed Solution updated | |
| 2021-12-01 17:59 | caristu | Issue cloned | 0048188 |
| 2021-12-01 17:59 | caristu | Relationship added | related to 0048188 |
| 2021-12-01 18:00 | caristu | Proposed Solution updated | |
| 2021-12-08 22:43 | elara | Assigned To | Retail => elara |
| 2021-12-08 22:43 | elara | Status | new => scheduled |
| 2021-12-09 19:41 | hgbot | Note Added: 0133587 | |
| 2021-12-14 13:23 | cberner | Assigned To | elara => cberner |
| 2023-01-09 18:59 | hgbot | Note Added: 0145225 | |