Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048153Openbravo ERPE. Translationpublic2021-11-24 12:482022-01-05 10:15
Reporterjetxarri 
Assigned ToAugustoMauch 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in VersionPR22Q2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048153: Error translating a discount and promotion
DescriptionError translating a discount and promotion after editing in grid view
Steps To Reproduce-Go to discount and promotions
-Create a translation in form view
-Go to grid view
-Edit and remove the language
-Press save --> you will see red rectangle with the error
-Press Edit
-You will see Albanian as selected
-Press save

The error appears again

You need to select manually the lang to avoid the error
Proposed Solution
Additional Information
TagsNOR
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-11-24 12:48jetxarriNew Issue
2021-11-24 12:48jetxarriAssigned To => platform
2021-11-24 12:48jetxarriOBNetwork customer => OBPS
2021-11-24 12:48jetxarriModules => Core
2021-11-24 12:48jetxarriTriggers an Emergency Pack => No
2021-11-24 12:48jetxarriTag Attached: NOR
2021-12-14 10:32sebastien_lironIssue Monitored: sebastien_liron
2021-12-27 10:58AugustoMauchAssigned Toplatform => AugustoMauch
2021-12-27 14:14hgbotMerge Request Status => open
2021-12-27 14:14hgbotNote Added: 0133987
2021-12-27 16:58AugustoMauchStatusnew => scheduled
2021-12-28 10:52hgbotMerge Request Statusopen => approved
2021-12-28 10:54hgbotResolutionopen => fixed
2021-12-28 10:54hgbotStatusscheduled => closed
2021-12-28 10:54hgbotNote Added: 0134003
2021-12-28 10:54hgbotFixed in Version => PR22Q1
2021-12-28 10:54hgbotNote Added: 0134004
2022-01-05 09:30hgbotFixed in VersionPR22Q1 => PR22Q2
2022-01-05 09:30hgbotNote Added: 0134127
2022-01-05 10:15AugustoMauchIssue cloned0048354

Notes
(0133987)
hgbot   
2021-12-27 14:14   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/483 [^]
(0134003)
hgbot   
2021-12-28 10:54   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/483 [^]
(0134004)
hgbot   
2021-12-28 10:54   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 990fdf0637d46addd3d8bfb8874df4d590d496fa
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 28-12-2021 10:53:54
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/990fdf0637d46addd3d8bfb8874df4d590d496fa [^]

Fixes ISSUE-48153: Validating error cleared when no mandatory fields are empty

To reproduce the issue, the user had to:
- create a record, filling in all mandatory fields
- empty one of the mandatory fields and save, an expected validation error was raised
- edit the line in grid view, mandatory field is given a default value (the FIC does it), but
after trying to save the validation error does not go away and the new value is not saved

The problem was that even though the FIC was providing a valid default value for the empty
mandatory field, the save process was not trying to save the record because it mistakingly
thought that the edit form had not been changed. To fix this, when processing the FIC return the
setHasChanged function is invoked if the FIC has provided a not-null value for a field that used
to be empty.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0134127)
hgbot   
2022-01-05 09:30   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 4aa9945c68b21f31b6ecacd55cf63a1aa5ec7ed4
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 05-01-2022 09:24:27
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/4aa9945c68b21f31b6ecacd55cf63a1aa5ec7ed4 [^]

Revert "Fixes ISSUE-48153: Validating error cleared when no mandatory fields are empty"

This reverts commit 990fdf0637d46addd3d8bfb8874df4d590d496fa.

Fix is suspect of breaking CI, will be backed out until the cause is clear

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---