Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048143POS2Corepublic2021-11-23 15:212021-12-24 10:17
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048143: Support expiring credentials data in mobile applications
DescriptionWhen a user enters his credentals on a mobile application (i.e. by logging in or by doing an approval), his credentials are stored in a cache so that they will be available if the user needs to enter them when the application is offline.

We would like to be able to define an expiration date for credentials, so credentials in that offline cache are only available if they have not expired.

Functional Specification: https://docs.google.com/document/d/1DpxZz25EKoxBADWIqblzBRQgsr6W7O6UN9Ou526Zql4/edit# [^]
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-11-23 15:21AugustoMauchNew Issue
2021-11-23 15:21AugustoMauchAssigned To => AugustoMauch
2021-11-23 15:21AugustoMauchOBNetwork customer => No
2021-11-23 15:21AugustoMauchTriggers an Emergency Pack => No
2021-11-23 15:25hgbotMerge Request Status => open
2021-11-23 15:25hgbotNote Added: 0133303
2021-11-23 15:25hgbotNote Added: 0133304
2021-11-24 10:57AugustoMauchStatusnew => scheduled
2021-11-25 15:17hgbotMerge Request Statusopen => approved
2021-11-27 13:52hgbotNote Added: 0133398
2021-11-27 13:53hgbotNote Added: 0133399
2021-12-24 10:16hgbotNote Added: 0133942
2021-12-24 10:16hgbotResolutionopen => fixed
2021-12-24 10:16hgbotStatusscheduled => closed
2021-12-24 10:16hgbotFixed in Version => RR22Q1
2021-12-24 10:16hgbotNote Added: 0133943
2021-12-24 10:16hgbotNote Added: 0133944
2021-12-24 10:16hgbotNote Added: 0133945
2021-12-24 10:16hgbotNote Added: 0133946
2021-12-24 10:16hgbotNote Added: 0133947
2021-12-24 10:16hgbotNote Added: 0133948
2021-12-24 10:17hgbotNote Added: 0133949
2021-12-24 10:17hgbotNote Added: 0133950
2021-12-24 10:17hgbotNote Added: 0133951
2021-12-24 10:17hgbotNote Added: 0133952

Notes
(0133303)
hgbot   
2021-11-23 15:25   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/302 [^]
(0133304)
hgbot   
2021-11-23 15:25   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/636 [^]
(0133398)
hgbot   
2021-11-27 13:52   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/674 [^]
(0133399)
hgbot   
2021-11-27 13:53   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/636 [^]
(0133942)
hgbot   
2021-12-24 10:16   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: ab446bdf6ed9b17fceb1ac0bb55323fffeecf8fa
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 23-12-2021 13:58:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/ab446bdf6ed9b17fceb1ac0bb55323fffeecf8fa [^]

Related to ISSUE-48143: Adds EM_OBMOBC_CREDENTIAL_TIMEOUT to AD_ORG

---
A src-db/database/model/modifiedTables/AD_ORG.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
---
(0133943)
hgbot   
2021-12-24 10:16   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: ac83824afdb0c3f76541e638cff47f9fa66ee1ff
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 23-12-2021 13:58:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/ac83824afdb0c3f76541e638cff47f9fa66ee1ff [^]

Fixes ISSUE-48143: Expiration date is taken into account when entering credentials in offline mode

If user credential data is configured to expire after X days, that information is now taken into account:
- When a user enters his credentials, the updated expiration date is stored on the offline cache
- When a user logs in in offline mode, the cached credentials will be used only if they have not expired

---
M web-test/model/login/OfflineUser.test.js
M web/org.openbravo.mobile.core/app/model/login/OfflineSession.js
---
(0133944)
hgbot   
2021-12-24 10:16   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: b0fd22d051827ef9f5a2387a67e26af350c47643
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 23-12-2021 13:58:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/b0fd22d051827ef9f5a2387a67e26af350c47643 [^]

Related to ISSUE-48143: Improves tests, makes functions private

---
M src-db/database/model/modifiedTables/AD_ORG.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-test/model/login/OfflineUser.test.js
M web/org.openbravo.mobile.core/app/model/login/OfflineSession.js
---
(0133945)
hgbot   
2021-12-24 10:16   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 6e92316f2a66b2844474149e0cdeb35cbb2b17d7
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 23-12-2021 13:58:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/6e92316f2a66b2844474149e0cdeb35cbb2b17d7 [^]

Related to ISSUE-48143: Wraps file content in a function to prevent the aux functions from being public

---
M web/org.openbravo.mobile.core/app/model/login/OfflineSession.js
---
(0133946)
hgbot   
2021-12-24 10:16   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 39b0ede12075ddf2b84637025bc449c4201a027d
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 23-12-2021 13:58:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/39b0ede12075ddf2b84637025bc449c4201a027d [^]

Related to ISSUE-48143: Include new property in data loaded on login, store it in LocalStorage

---
M src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java
M web-test/model/login/OfflineUser.test.js
M web/org.openbravo.mobile.core/app/model/login/OfflineSession.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0133947)
hgbot   
2021-12-24 10:16   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/302 [^]
(0133948)
hgbot   
2021-12-24 10:16   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 5d282603ae26ae1b851657d11b1ea83a03e9805d
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 23-12-2021 13:58:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/5d282603ae26ae1b851657d11b1ea83a03e9805d [^]

Related to ISSUE-48143: Code review comments, will be squashed

---
M web-test/model/login/OfflineUser.test.js
---
(0133949)
hgbot   
2021-12-24 10:17   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: e11e0e9fae95c4f8ab9074c1564018a494dddfce
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 23-12-2021 13:54:44
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/e11e0e9fae95c4f8ab9074c1564018a494dddfce [^]

Related to ISSUE-48143: Include credential expiration timeout when initializing app

---
M src/org/openbravo/core2/login/Core2LoginUtilsServlet.java
M web-jspack/org.openbravo.core2/src/core/authentication/InitializeAppData.js
---
(0133950)
hgbot   
2021-12-24 10:17   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: ca7839eb1ff26b7a487e027e96afd1c24376c459
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 23-12-2021 13:54:44
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/ca7839eb1ff26b7a487e027e96afd1c24376c459 [^]

Related to ISSUE-48143: Code review comments, will be squashed

---
M src/org/openbravo/core2/login/Core2LoginUtilsServlet.java
M web-jspack/org.openbravo.core2/src/core/authentication/InitializeAppData.js
---
(0133951)
hgbot   
2021-12-24 10:17   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 0ad66362b7330358dfe865284f360b4db5f6434c
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 23-12-2021 13:54:44
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/0ad66362b7330358dfe865284f360b4db5f6434c [^]

Related to ISSUE-48143: add new test

---
A web-jspack/org.openbravo.core2/src/core/authentication/__test__/InitializeAppData.test.js
M web-jspack/org.openbravo.core2/src/core/__mock__/localStorage.js
M web-jspack/org.openbravo.core2/src/core/authentication/InitializeAppData.js
---
(0133952)
hgbot   
2021-12-24 10:17   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/674 [^]