Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048133Retail ModulesWeb POS Hardware Managerpublic2021-11-23 10:422021-11-24 09:04
Reporteradrianromero 
Assigned Toadrianromero 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR22Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048133: Fix ESLINT and PRETTIER warnings
DescriptionThere are two javascript files in the Hardware Manager that have js warnings:

Checking formatting...
modules/org.openbravo.retail.poshwmanager.sources/project/src/com/openbravo/poshw/www/handlebars.min.js
modules/org.openbravo.retail.poshwmanager.sources/project/src/com/openbravo/poshw/www/processtemplate.js
Code style issues found in the above file(s). Forgot to run Prettier?

Lint check for Core files
/srv/ci/workspace/mod-simple-ci34.52016/modules/org.openbravo.retail.poshwmanager.sources/project/src/com/openbravo/poshw/www/handlebars.min.js
 27:2 error Replace `function(a,b){"object"==typeof·exports&&"object"==typeof·module?module.exports=b():"function"==typeof·define&&define.amd?define([],b):"object"==typeof·exports?exports.Handlebars=b():a.Handlebars=b()}
...
/srv/ci/workspace/mod-simple-ci34.52016/modules/org.openbravo.retail.poshwmanager.sources/project/src/com/openbravo/poshw/www/processtemplate.js
  11:10 warning 'processTemplate' is defined but never used no-unused-vars
  12:1 error Replace `⏎··fetch(url,·'GET')⏎··.then(function·` with `··fetch(url,·'GET').then(function` prettier/prettier
  16:39 error Replace `document.getElementById('data-template').innerHTML` with `⏎······document.getElementById('data-template').innerHTML⏎····` prettier/prettier
  17:73 error Replace `context` with `⏎······context⏎····` prettier/prettier
  21:10 error 'fetch' is already defined as a built-in global variable no-redeclare
  22:30 error Delete `·` prettier/prettier
  24:46 error Delete `·` prettier/prettier
  36:2 error Insert `⏎` prettier/prettier

Steps To ReproduceRun ESLINT and PRETTIER using these two js files as parameters
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-11-23 10:42adrianromeroNew Issue
2021-11-23 10:42adrianromeroAssigned To => Retail
2021-11-23 10:42adrianromeroTriggers an Emergency Pack => No
2021-11-24 07:01hgbotResolutionopen => fixed
2021-11-24 07:01hgbotStatusnew => resolved
2021-11-24 07:01hgbotFixed in Version => RR22Q1
2021-11-24 07:01hgbotNote Added: 0133315
2021-11-24 07:07alostaleAssigned ToRetail => adrianromero
2021-11-24 07:07alostaleReview Assigned To => alostale
2021-11-24 07:07alostaleStatusresolved => closed
2021-11-24 09:04hgbotNote Added: 0133325

Notes
(0133315)
hgbot   
2021-11-24 07:01   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager.sources [^]
Changeset: 966d628ecd567bb2c3933684d039341aee0cfc7e
Author: Adrián Romero <adrian.romero@openbravo.com>
Date: 2021-11-24T06:01:52+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager.sources/-/commit/966d628ecd567bb2c3933684d039341aee0cfc7e [^]

Fixes ISSUE-0048133: Fix ESLINT and PRETTIER warnings

---
A .eslintignore
A .prettierignore
M project/src/com/openbravo/poshw/www/processtemplate.js
---
(0133325)
hgbot   
2021-11-24 09:04   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager [^]
Changeset: dbbb84acce7671a2868447dfc5d8b8b0c95d37d5
Author: Adrián Romero <adrian.romero@openbravo.com>
Date: 2021-11-24T09:04:14+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager/-/commit/dbbb84acce7671a2868447dfc5d8b8b0c95d37d5 [^]

Related ISSUE-0048133: Fix ESLINT and PRETTIER warnings

---
M bin/poshw.jar
M bin/rev.id
---