Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048126Retail ModulesWeb POSpublic2021-11-22 17:272024-07-15 16:29
Reportermarvintm 
Assigned Toeugen_hamuraru 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR24Q2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048126: ExternalOrderLoader is not working because of CSRF token check
DescriptionCorrect requests to ExternalOrderLoader fail, because the CSRF Token check is performed there, and it doesn't pass, so the request is rejected.
Steps To ReproduceThe problem can be reproduced in livebuilds just using the Swagger documentation example:

https://livebuilds.openbravo.com/retail_modules_pgsql_pi/api?urls.primaryName=orderloader [^]

It can also be reproduced by using the Postman example of the RetailAPI module:

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api/-/blob/master/examples/Retail%20API.postman_collection.json [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to backport 0055218RR24Q1 closed adrianromero ExternalOrderLoader is not working because of CSRF token check 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-11-22 17:27marvintmNew Issue
2021-11-22 17:27marvintmAssigned To => Retail
2021-11-22 17:27marvintmOBNetwork customer => No
2021-11-22 17:27marvintmTriggers an Emergency Pack => No
2021-11-25 07:17ivancaceresIssue Monitored: ivancaceres
2022-07-21 12:12radhakrishnanAssigned ToRetail => radhakrishnan
2022-07-21 12:13radhakrishnanStatusnew => scheduled
2023-05-08 15:56marvintmAssigned Toradhakrishnan => Retail
2023-05-20 12:36ranjith_qualiantech_comStatusscheduled => feedback
2024-02-08 09:22rafademiguelOBNetwork customerNo => Gold
2024-02-08 09:22rafademiguelPrioritynormal => high
2024-02-08 09:22rafademiguelStatusfeedback => new
2024-02-12 09:40guillermogilAssigned ToRetail => Triage Platform Conn
2024-02-16 10:33adrianromeroAssigned ToTriage Platform Conn => eugen_hamuraru
2024-02-21 14:17hgbotMerge Request Status => open
2024-02-21 14:17hgbotNote Added: 0161030
2024-02-21 14:19hgbotNote Added: 0161031
2024-02-29 16:29hgbotMerge Request Statusopen => approved
2024-02-29 16:41hgbotNote Added: 0161447
2024-02-29 16:41hgbotNote Added: 0161448
2024-02-29 16:41hgbotResolutionopen => fixed
2024-02-29 16:41hgbotStatusnew => closed
2024-02-29 16:41hgbotFixed in Version => RR24Q2
2024-02-29 16:41hgbotNote Added: 0161449
2024-02-29 16:41hgbotNote Added: 0161450
2024-04-17 12:00adrianromeroIssue cloned0055218
2024-04-17 12:00adrianromeroRelationship addedrelated to 0055218
2024-07-15 16:24meriem_azafStatusclosed => new
2024-07-15 16:24meriem_azafResolutionfixed => open
2024-07-15 16:24meriem_azafFixed in VersionRR24Q2 =>
2024-07-15 16:24meriem_azafStatusnew => scheduled
2024-07-15 16:24meriem_azafStatusscheduled => resolved
2024-07-15 16:24meriem_azafResolutionopen => fixed
2024-07-15 16:24meriem_azafStatusresolved => closed
2024-07-15 16:27meriem_azafFixed in Version => RR24Q2
2024-07-15 16:29meriem_azafRelationship addedrelated to 0056017

Notes
(0161030)
hgbot   
2024-02-21 14:17   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1483 [^]
(0161031)
hgbot   
2024-02-21 14:19   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/665 [^]
(0161447)
hgbot   
2024-02-29 16:41   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/665 [^]
(0161448)
hgbot   
2024-02-29 16:41   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: d14d9ea59e93a40422310cc8434440723aa94fb7
Author: Eugen Hamuraru <eugen.hamuraru@openbravo.com>
Date: 29-02-2024 15:41:01
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/d14d9ea59e93a40422310cc8434440723aa94fb7 [^]

Related to BUG-48126: ability to skip CSRF token check for SecuredJSONProcess

---
A src-test/org/openbravo/mobile/core/process/MobileServiceTest.java
M src-test/org/openbravo/mobile/core/StandaloneTestSuite.java
M src/org/openbravo/mobile/core/process/MobileService.java
M src/org/openbravo/mobile/core/process/MobileServiceProcessor.java
M src/org/openbravo/mobile/core/process/SecuredJSONProcess.java
---
(0161449)
hgbot   
2024-02-29 16:41   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 653c3a7c365c967e16e034ea67db463ab673db9a
Author: Eugen Hamuraru <eugen.hamuraru@openbravo.com>
Date: 29-02-2024 07:49:26
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/653c3a7c365c967e16e034ea67db463ab673db9a [^]

Fixes ISSUE-48126: skip CSRF token check for the ExternalOrderLoader

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0161450)
hgbot   
2024-02-29 16:41   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1483 [^]