Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048103Retail ModulesWeb POSpublic2021-11-18 14:102021-12-16 08:47
Reporterdromero 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product VersionRR21Q4.1 
Target VersionFixed in VersionRR22Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048103: Problem with displaying/editing customer 21q4.1
DescriptionExplanatory video:

https://watch.screencastify.com/v/2rA3M0TM3BUQ96pZVpI0 [^]

Reproduced on:

https://livebuilds.openbravo.com/retail_mp_3.0RR21Q4.1/web/org.openbravo.retail.posterminal/?terminal=VBS-1#retail.pointofsale [^]
Steps To ReproduceSteps to reproduce:

1.- Create a Business Partner and assign a Contact
2.- Remove First and Last name in user associated with above Business Partner
3.- Go to WEB POS, select the customer created, and click on View Details, where we see that it does not show any information
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-11-18 14:10dromeroNew Issue
2021-11-18 14:10dromeroAssigned To => Retail
2021-11-18 14:10dromeroRegression date => 2021-12-02
2021-11-18 14:10dromeroTriggers an Emergency Pack => No
2021-11-18 14:26PracticsIssue Monitored: Practics
2021-11-29 19:26dromeroNote Added: 0133403
2021-12-01 10:41ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2021-12-01 11:51ranjith_qualiantech_comStatusnew => scheduled
2021-12-02 16:42ivazquezOBNetwork customer => OBPS
2021-12-02 16:42ivazquezRegression date2021-12-02 =>
2021-12-06 16:26ivazquezNote Added: 0133506
2021-12-07 11:02ranjith_qualiantech_comSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=23383#r23383
2021-12-09 07:03hgbotMerge Request Status => open
2021-12-09 07:03hgbotNote Added: 0133523
2021-12-09 09:12marvintmNote Added: 0133539
2021-12-09 09:12hgbotMerge Request Statusopen => approved
2021-12-09 09:12hgbotResolutionopen => fixed
2021-12-09 09:12hgbotStatusscheduled => closed
2021-12-09 09:12hgbotFixed in Version => RR22Q1
2021-12-09 09:12hgbotNote Added: 0133540
2021-12-09 09:12hgbotNote Added: 0133541
2021-12-09 16:41PracticsNote Added: 0133578
2021-12-15 13:21ranjith_qualiantech_comStatusclosed => new
2021-12-15 13:21ranjith_qualiantech_comResolutionfixed => open
2021-12-15 13:21ranjith_qualiantech_comFixed in VersionRR22Q1 =>
2021-12-16 06:38hgbotNote Added: 0133746
2021-12-16 07:01ranjith_qualiantech_comStatusnew => scheduled
2021-12-16 08:47hgbotResolutionopen => fixed
2021-12-16 08:47hgbotStatusscheduled => closed
2021-12-16 08:47hgbotFixed in Version => RR22Q1
2021-12-16 08:47hgbotNote Added: 0133751
2021-12-16 08:47hgbotNote Added: 0133752

Notes
(0133403)
dromero   
2021-11-29 19:26   
Hello team,

Any update?
(0133506)
ivazquez   
2021-12-06 16:26   
Hello Team,

Will you have any news?

Regards,
Ignacio Vazquez
(0133523)
hgbot   
2021-12-09 07:03   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/651 [^]
(0133539)
marvintm   
2021-12-09 09:12   
Normally the first and last name columns should be set. In case they are not, then we assume it is not necessary to properly separate the first and last name information. Therefore, our fix just use whatever the contact information has as "first name", and ignore the last name. The first name will then be reset in the backend whenever the customer is updated from the POS.
(0133540)
hgbot   
2021-12-09 09:12   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: ae12dd98d026014e17035647ccb12faf2cdab094
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-12-09T08:12:19+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/ae12dd98d026014e17035647ccb12faf2cdab094 [^]

Fixed ISSUE-48103: Customer name should be loaded with user name if first name is not present

---
M src/org/openbravo/retail/posterminal/master/BusinessPartnerProperties.java
---
(0133541)
hgbot   
2021-12-09 09:12   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/651 [^]
(0133578)
Practics   
2021-12-09 16:41   
Hi

The second part of the issue that we indicated in our video remains to be resolved, if you remove the contact from the customer.

The customer gets on the POS, you look for it, you go to the details and nothing comes out in the name field.

It should be a triple coalesce

add(new HQLProperty("coalesce(ulist.firstName, ulist.name, bp.name)", "firstName"));
(0133746)
hgbot   
2021-12-16 06:38   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/660 [^]
(0133751)
hgbot   
2021-12-16 08:47   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 7a920c9d7d0b4e7af28070cf04b00a555564004c
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 16-12-2021 07:47:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/7a920c9d7d0b4e7af28070cf04b00a555564004c [^]

Fixed ISSUE-48103: Customer name should be loaded with name if contact is not present

---
M src/org/openbravo/retail/posterminal/master/BusinessPartnerProperties.java
---
(0133752)
hgbot   
2021-12-16 08:47   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/660 [^]