Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048102Retail ModulesWeb POSpublic2021-11-18 13:362021-12-23 08:20
Reporterdromero 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product VersionRR21Q4.1 
Target VersionFixed in VersionRR22Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048102: Verified returns with attributes 21Q4.1
DescriptionWhen you make a sale of two products, you go to the "Verified Returns" section and select one of the two products, it asks you to scan the attribute of the two products as well.

Explanatory video:

https://watch.screencastify.com/v/ARzFwObq9bV7qlc11fOz [^]
Steps To ReproduceSteps to reproduce:

1.- Check the preference "Web POS Enable support for product attributes" where the field "Value" has to be "Y"
2.- Create an "Attribute Set" with the configuration shown in the video and with an "Attribute" that is of type "Instance Attribute" and has the "Mandatory" checkbox checked.
3.- Go to a product that has not been in stock before and uncheck the "Grouped Product" checkbox.
4.- Make a "Physical Inventory" for that product and at the end enter stock for it. (Update: Make a 2 "Physical Inventory" for that product (1 Qty for Vall Blanca Store Warehouse and 1 qty for White Valley Spain Distribution Center).)
5.- Go to the Web POS, add the product twice and assign it an attribute
6.- Sale is made
7.- Go to "Verified Returns" and choose the sale made
8.- Select one of the two items and press the "Apply" button

Then we can see that we are asked to scan the attribute of two products when we select only one product.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-11-18 13:36dromeroNew Issue
2021-11-18 13:36dromeroAssigned To => Retail
2021-11-18 13:36dromeroRegression date => 2021-12-02
2021-11-18 13:36dromeroTriggers an Emergency Pack => No
2021-11-18 13:45PracticsIssue Monitored: Practics
2021-11-28 13:24PracticsNote Added: 0133400
2021-12-01 11:49ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2021-12-01 11:51ranjith_qualiantech_comStatusnew => scheduled
2021-12-02 16:43ivazquezRegression date2021-12-02 =>
2021-12-06 16:26ivazquezNote Added: 0133507
2021-12-07 11:04ranjith_qualiantech_comSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=23385#r23385
2021-12-15 05:39hgbotNote Added: 0133708
2021-12-20 07:44hgbotResolutionopen => fixed
2021-12-20 07:44hgbotStatusscheduled => closed
2021-12-20 07:44hgbotFixed in Version => RR22Q1
2021-12-20 07:44hgbotNote Added: 0133819
2021-12-20 07:44hgbotNote Added: 0133820
2021-12-20 13:18ivazquezNote Added: 0133846
2021-12-20 13:19ivazquezStatusclosed => new
2021-12-20 13:19ivazquezResolutionfixed => open
2021-12-22 06:53ranjith_qualiantech_comNote Edited: 0133846bug_revision_view_page.php?bugnote_id=0133846#r23450
2021-12-22 06:57hgbotNote Added: 0133892
2021-12-22 07:02ranjith_qualiantech_comStatusnew => scheduled
2021-12-23 08:20hgbotNote Added: 0133922
2021-12-23 08:20hgbotNote Added: 0133923
2021-12-23 08:20marvintmStatusscheduled => resolved
2021-12-23 08:20marvintmResolutionopen => fixed
2021-12-23 08:20marvintmReview Assigned To => marvintm
2021-12-23 08:20marvintmStatusresolved => closed

Notes
(0133400)
Practics   
2021-11-28 13:24   
Any Update?
(0133507)
ivazquez   
2021-12-06 16:26   
Hello Team

Will you have any news?

Regards,
Ignacio Vazquez
(0133708)
hgbot   
2021-12-15 05:39   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/merge_requests/33 [^]
(0133819)
hgbot   
2021-12-20 07:44   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns [^]
Changeset: 1d157397252f795c9085551d0c008b052813d112
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 16-12-2021 15:56:11
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/commit/1d157397252f795c9085551d0c008b052813d112 [^]

Fixed ISSUE-48102: Attribute should be shown based on Return line selection
* If lines are splitted due to shipment lines, attribute list should be shown based on lines

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
M web/org.openbravo.retail.returns/js/modalproductattributeverifiedreturns.js
---
(0133820)
hgbot   
2021-12-20 07:44   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/merge_requests/33 [^]
(0133846)
ivazquez   
2021-12-20 13:18   
(edited on: 2021-12-22 06:53)
Hello Team

I am reopening the issue since a bug was found after applying the patch:

-Create 2 different product with attribute value
-Select all the Items and hit apply, in this case, it works fine,
-Uncheck 2 items, hit apply and it works correctly,
-When you select again all the items and click on apply now only one item can be scanned.

Explanatory video:

https://watch.screencastify.com/v/KT8xYq3SjwcxlrnEO2Qm [^]
(0133892)
hgbot   
2021-12-22 06:57   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/merge_requests/34 [^]
(0133922)
hgbot   
2021-12-23 08:20   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns [^]
Changeset: fd4ef2822763085ba9b4ad126776e86e4eb3b9fe
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 22-12-2021 11:24:15
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/commit/fd4ef2822763085ba9b4ad126776e86e4eb3b9fe [^]

Related to ISSUE-48102: Return Lines should be updated based on Original OrderLines
* When adding returnLines, receiptLines should be reset from original OrderLines.
  This will allow to retain the original order Lines if hook/attribute validation is cancelled
* For New State Actions, If lines are splitted due to shipment lines,
  attribute list should be shown based on lines

---
M web/org.openbravo.retail.returns/app/model/business-object/ticket/actions/ReturnVerifiedTicket.js
M web/org.openbravo.retail.returns/js/modalReturnLines.js
M web/org.openbravo.retail.returns/js/modalproductattributeverifiedreturns.js
---
(0133923)
hgbot   
2021-12-23 08:20   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/merge_requests/34 [^]