Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048096ModulesExternal Data Integrationpublic2021-11-17 17:172022-03-18 11:35
Reportershuehner 
Assigned ToAugustoMauch 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary0048096: DirectPropertyMapping.executeQueryForReferencedRecord/getHqlQueryForReferencedRecord is not using bind-params
DescriptionThe getHqlQueryForReferencedRecord method is constructing dynamic HQL without using bind params.

This concrete case looks like it could be rewritten using OBCriteria instead.

Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0048035 closed meriem_azaf Apply HQL style guide to service.externaldata.integration module 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-11-17 17:17shuehnerNew Issue
2021-11-17 17:17shuehnerAssigned To => platform
2021-11-17 17:17shuehnerOBNetwork customer => No
2021-11-17 17:17shuehnerRelationship addedrelated to 0048035
2022-01-11 17:54AugustoMauchAssigned Toplatform => AugustoMauch
2022-01-11 17:55AugustoMauchStatusnew => scheduled
2022-01-11 17:57hgbotMerge Request Status => open
2022-01-11 17:57hgbotNote Added: 0134233
2022-03-18 11:35hgbotMerge Request Statusopen => approved
2022-03-18 11:35hgbotResolutionopen => fixed
2022-03-18 11:35hgbotStatusscheduled => closed
2022-03-18 11:35hgbotNote Added: 0135840
2022-03-18 11:35hgbotNote Added: 0135842

Notes
(0134233)
hgbot   
2022-01-11 17:57   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.external.integration/-/merge_requests/9 [^]
(0135840)
hgbot   
2022-03-18 11:35   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.external.integration [^]
Changeset: 29cc000f93ecc895d2cc89f4dfc539f87070120f
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 18-03-2022 11:34:31
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.external.integration/-/commit/29cc000f93ecc895d2cc89f4dfc539f87070120f [^]

Fixes ISSUE-48096: Uses OBCriteria instead of injecting entity and property name

We can use OBCriteria to build the query instead of injecting the entity and property names

---
M src/org/openbravo/service/external/integration/mapping/DirectPropertyMapping.java
---
(0135842)
hgbot   
2022-03-18 11:35   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.external.integration/-/merge_requests/9 [^]