Openbravo Issue Tracking System - Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0048091 | Modules | Tax Report Launcher | public | 2021-11-17 14:31 | 2022-01-24 15:07 |
|
| Reporter | vmromanos | |
| Assigned To | mgonzalezh | |
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Regression date | |
| Regression introduced by commit | |
| Regression level | |
| Review Assigned To | |
| Support ticket | |
| OBNetwork customer | |
| Regression introduced in release | |
|
| Summary | 0048091: SPLP: Several modules from functional/omni team are using bad logging (System.out,System.err println or printStackTrace) |
| Description | This issue focus only on the SPLP related modules:
2 mods/org.openbravo.module.taxreportlauncher
3 pmods/org.openbravo.module.aeat190.es
3 pmods/org.openbravo.module.aeat347apr.es
7 pmods/org.openbravo.module.aeat390.es
1 pmods/org.openbravo.module.intrastat
23 pmods/org.openbravo.module.sii
|
| Steps To Reproduce | In any workspace having the relevant modules run to get the overview:
grep -IrE "System.out|System.err|printStackTrace" | grep -v buildvalidation | grep -v modulescript | grep -v src-test | cut -d'/' -f1-2 | sort | uniq -c
To get the full list (including code in question):
grep -IrE "System.out|System.err|printStackTrace" | grep -v buildvalidation | grep -v modulescript | grep -v src-test | cut -d'/' -f1-2 | sort | uniq -c
|
| Proposed Solution | Review and move the logging to proper log4j usage.
While doing that check if:
- stackTrace is really wanted
- Logging is really useful (and not developer leftover)
|
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0047974 | | closed | francisco_ofarril | Modules | Several modules from functional/omni team are using bad logging (System.out,System.err println or printStackTrace) | | blocks | design defect | 0036162 | | acknowledged | Triage Platform Base | Openbravo ERP | clean up openbravo.log |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2021-11-17 14:31 | vmromanos | New Issue | |
| 2021-11-17 14:31 | vmromanos | Assigned To | => Triage Finance |
| 2021-11-17 14:31 | vmromanos | Issue generated from | 0047974 |
| 2021-11-17 14:31 | vmromanos | Relationship added | related to 0047974 |
| 2021-11-17 14:31 | vmromanos | Relationship added | blocks 0036162 |
| 2021-11-17 15:01 | psanjuan | Assigned To | Triage Finance => Jorge Bravo |
| 2021-11-19 10:07 | Jorge Bravo | Assigned To | Jorge Bravo => juabaez |
| 2021-11-26 00:51 | hgbot | Note Added: 0133378 | |
| 2021-11-26 01:06 | hgbot | Note Added: 0133379 | |
| 2021-11-26 01:07 | hgbot | Note Added: 0133380 | |
| 2021-11-26 01:08 | hgbot | Note Added: 0133381 | |
| 2021-11-26 01:09 | hgbot | Note Added: 0133382 | |
| 2021-11-26 13:35 | hgbot | Note Added: 0133390 | |
| 2021-12-07 14:13 | Jorge Bravo | Assigned To | juabaez => mgonzalezh |
| 2021-12-07 14:13 | Jorge Bravo | Assigned To | mgonzalezh => juabaez |
| 2021-12-07 14:13 | Jorge Bravo | Assigned To | juabaez => mgonzalezh |
| 2022-01-24 14:40 | hgbot | Resolution | open => fixed |
| 2022-01-24 14:40 | hgbot | Status | new => resolved |
| 2022-01-24 14:40 | hgbot | Note Added: 0134516 | |
| 2022-01-24 14:40 | hgbot | Note Added: 0134517 | |
| 2022-01-24 14:45 | hgbot | Note Added: 0134518 | |
| 2022-01-24 14:45 | hgbot | Note Added: 0134519 | |
| 2022-01-24 14:52 | hgbot | Note Added: 0134520 | |
| 2022-01-24 14:52 | hgbot | Note Added: 0134521 | |
| 2022-01-24 14:52 | hgbot | Note Added: 0134522 | |
| 2022-01-24 14:52 | hgbot | Note Added: 0134523 | |
| 2022-01-24 14:56 | hgbot | Note Added: 0134524 | |
| 2022-01-24 14:56 | hgbot | Note Added: 0134525 | |
| 2022-01-24 15:07 | hgbot | Status | resolved => closed |
| 2022-01-24 15:07 | hgbot | Note Added: 0134526 | |
| 2022-01-24 15:07 | hgbot | Note Added: 0134527 | |
|
Notes |
|
|
(0133378)
|
|
hgbot
|
|
2021-11-26 00:51
|
|
|
|
|
(0133379)
|
|
hgbot
|
|
2021-11-26 01:06
|
|
|
|
|
(0133380)
|
|
hgbot
|
|
2021-11-26 01:07
|
|
|
|
|
(0133381)
|
|
hgbot
|
|
2021-11-26 01:08
|
|
|
|
|
(0133382)
|
|
hgbot
|
|
2021-11-26 01:09
|
|
|
|
|
(0133390)
|
|
hgbot
|
|
2021-11-26 13:35
|
|
|
|
|
(0134516)
|
|
hgbot
|
|
2022-01-24 14:40
|
|
|
|
|
(0134517)
|
|
hgbot
|
|
2022-01-24 14:40
|
|
|
|
|
(0134519)
|
|
hgbot
|
|
2022-01-24 14:45
|
|
|
|
|
(0134518)
|
|
hgbot
|
|
2022-01-24 14:45
|
|
|
|
|
(0134520)
|
|
hgbot
|
|
2022-01-24 14:52
|
|
|
|
|
(0134521)
|
|
hgbot
|
|
2022-01-24 14:52
|
|
|
|
|
(0134522)
|
|
hgbot
|
|
2022-01-24 14:52
|
|
|
|
|
(0134523)
|
|
hgbot
|
|
2022-01-24 14:52
|
|
|
|
|
(0134524)
|
|
hgbot
|
|
2022-01-24 14:56
|
|
|
|
|
(0134525)
|
|
hgbot
|
|
2022-01-24 14:56
|
|
|
|
|
(0134526)
|
|
hgbot
|
|
2022-01-24 15:07
|
|
|
|
|
(0134527)
|
|
hgbot
|
|
2022-01-24 15:07
|
|
|