Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048068Retail ModulesDiscounts and Promotionspublic2021-11-16 01:502022-01-04 12:16
Reportercollazoandy4 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR22Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048068: Wrong User Defined Line Amount discount after create a Sales Order from Quotation
DescriptionIf a Sales Order is created from a quotation which have a User Defined Line Amount discount applied the amounts of the receipt is not properly calculated when the product quantity is increased
Steps To ReproduceLog in the backoffice as White Valley Group Admin role
Go to Discount and Promotions and create a new record:
  Discount promotion type: User Defined Line Amount
  Name: Line Amount Discount
  Starting date: First date of the month
Log in YS-11 Pos terminal and create a new Quotation
  Product: Avalanche Transceiver
Add the previous discount created and set as final price 140
A new discount line is created with an amount of -10.50
Check the total amount of receipt is 140.0
Syncronize the Quotation to the backoffice
Open the previous quotation and create a sales order from it
Check the new receipt total amount is 140.0 and the discount amount is -10.50
If more quantity to the product is added to the line the discount amount is not calculated and the total amount is also wrong.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0047948 closed ranjith_qualiantech_com Wrong User Defined Line Amount discount after C&R 
Attached Filesdiff 48068_20Q1_discounts.diff (1,573) 2022-01-04 12:16
https://issues.openbravo.com/file_download.php?file_id=16491&type=bug
diff 48068_20Q1_posterminal.diff (1,403) 2022-01-04 12:16
https://issues.openbravo.com/file_download.php?file_id=16492&type=bug
Issue History
Date ModifiedUsernameFieldChange
2021-11-16 01:50collazoandy4New Issue
2021-11-16 01:50collazoandy4Assigned To => Retail
2021-11-16 01:50collazoandy4Triggers an Emergency Pack => No
2021-11-16 01:51collazoandy4Relationship addedrelated to 0047948
2021-11-25 16:21ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2021-12-01 08:01ranjith_qualiantech_comStatusnew => scheduled
2021-12-02 09:50hgbotNote Added: 0133473
2021-12-02 09:50hgbotNote Added: 0133474
2021-12-02 09:50hgbotNote Added: 0133475
2021-12-09 11:43hgbotNote Added: 0133551
2021-12-09 11:43hgbotNote Added: 0133552
2021-12-09 11:43hgbotResolutionopen => fixed
2021-12-09 11:43hgbotStatusscheduled => closed
2021-12-09 11:43hgbotFixed in Version => RR22Q1
2021-12-09 11:43hgbotNote Added: 0133553
2021-12-09 11:43hgbotNote Added: 0133554
2021-12-09 11:43hgbotNote Added: 0133555
2021-12-09 11:43hgbotNote Added: 0133556
2022-01-04 12:16ranjith_qualiantech_comFile Added: 48068_20Q1_discounts.diff
2022-01-04 12:16ranjith_qualiantech_comFile Added: 48068_20Q1_posterminal.diff

Notes
(0133473)
hgbot   
2021-12-02 09:50   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/646 [^]
(0133474)
hgbot   
2021-12-02 09:50   
Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/150 [^]
(0133475)
hgbot   
2021-12-02 09:50   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/46 [^]
(0133551)
hgbot   
2021-12-09 11:43   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: c73e28e7736c5d7ec579f25405b7e62c6aaa5347
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-12-09T10:43:25+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/c73e28e7736c5d7ec579f25405b7e62c6aaa5347 [^]

Related to ISSUE-48068: Order should be created from quotation with promotion
* When creating order from quotation, promotion should be recalculated if user changes the ticket

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CreateTicketFromQuotation.js
---
(0133552)
hgbot   
2021-12-09 11:43   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/646 [^]
(0133553)
hgbot   
2021-12-09 11:43   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: d1149d710f49fb64604dd8e5f0fc39478a51d24d
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-12-09T10:43:34+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/d1149d710f49fb64604dd8e5f0fc39478a51d24d [^]

Fixed ISSUE-48068: Discount should be recalculated when creating order from quotation

---
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/interface/discount-posinterface.js
---
(0133554)
hgbot   
2021-12-09 11:43   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/46 [^]
(0133555)
hgbot   
2021-12-09 11:43   
Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/150 [^]
(0133556)
hgbot   
2021-12-09 11:43   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 80b2fb083f05999178fb2a150e67b29d4d877cd9
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-12-02T14:04:07+05:30
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/80b2fb083f05999178fb2a150e67b29d4d877cd9 [^]

Verifies ISSUE-48068: Added test I48068_CreateOrderFromQuotation

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/quotations/I48068_CreateOrderFromQuotation.java
---