Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048046Retail ModulesGift cards and gift voucherspublic2021-11-11 16:072021-11-18 15:57
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048046: Apply HQL style guide to giftcards
DescriptionApply HQL style guide

src/org/openbravo/retail/giftcards/process/ExpirationDateProcess.java:109
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-11-11 16:07shuehnerNew Issue
2021-11-11 16:07shuehnerAssigned To => Retail
2021-11-11 16:07shuehnerTriggers an Emergency Pack => No
2021-11-11 16:07shuehnerIssue generated from0048045
2021-11-11 16:07shuehnerRelationship addedblocks 0041287
2021-11-12 11:32hgbotNote Added: 0132992
2021-11-18 15:55shuehnerAssigned ToRetail => shuehner
2021-11-18 15:57hgbotResolutionopen => fixed
2021-11-18 15:57hgbotStatusnew => closed
2021-11-18 15:57hgbotNote Added: 0133190
2021-11-18 15:57hgbotNote Added: 0133191

Notes
(0132992)
hgbot   
2021-11-12 11:32   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/102 [^]
(0133190)
hgbot   
2021-11-18 15:57   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 5d95fdfe8ad7a2f4414cb266bef27b23be071bd1
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-11-18T15:57:06+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/5d95fdfe8ad7a2f4414cb266bef27b23be071bd1 [^]

Fixes ISSUE-48046: Apply HQL Style

Don't use StringBuilder to build query

---
M src/org/openbravo/retail/giftcards/process/ExpirationDateProcess.java
---
(0133191)
hgbot   
2021-11-18 15:57   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/102 [^]