Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048044Retail ModulesCopy Retail Storepublic2021-11-11 16:042021-11-18 15:53
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048044: Apply HQL style guide to copystore
DescriptionApply HQL style guide


src/org/openbravo/retail/copystore/process/CopyStoreProcess.java:907:
src/org/openbravo/retail/copystore/process/POSTerminalsProcess.java:154:
src/org/openbravo/retail/copystore/process/POSTerminalsProcess.java:98:
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-11-11 16:04shuehnerNew Issue
2021-11-11 16:04shuehnerAssigned To => Retail
2021-11-11 16:04shuehnerTriggers an Emergency Pack => No
2021-11-11 16:04shuehnerIssue generated from0048043
2021-11-11 16:04shuehnerRelationship addedblocks 0041287
2021-11-11 16:06shuehnerIssue cloned0048045
2021-11-12 11:46hgbotNote Added: 0132994
2021-11-18 15:51shuehnerAssigned ToRetail => shuehner
2021-11-18 15:53hgbotResolutionopen => fixed
2021-11-18 15:53hgbotStatusnew => closed
2021-11-18 15:53hgbotNote Added: 0133185
2021-11-18 15:53hgbotNote Added: 0133186

Notes
(0132994)
hgbot   
2021-11-12 11:46   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/merge_requests/23 [^]
(0133185)
hgbot   
2021-11-18 15:53   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore [^]
Changeset: 81a4fbb15e547deb085bfa87e974eb4494c8fa4e
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-11-12T11:46:04+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/commit/81a4fbb15e547deb085bfa87e974eb4494c8fa4e [^]

Fixes ISSUE-48044 Apply HQL Style

- Don't use StringBuilder to construct query text
- Inline some src-gen constants to improve readability

---
M src/org/openbravo/retail/copystore/process/CopyStoreProcess.java
M src/org/openbravo/retail/copystore/process/POSTerminalsProcess.java
---
(0133186)
hgbot   
2021-11-18 15:53   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/merge_requests/23 [^]