Openbravo Issue Tracking System - Retail Modules
View Issue Details
0048043Retail ModulesAuto BOM For Retailpublic2021-11-11 16:022021-11-18 15:51
shuehner 
shuehner 
normalminorhave not tried
closedfixed 
5
 
 
approved
No
No
0048043: Apply HQL style guide to autobom module
Apply HQL style guide

src/org/openbravo/retail/autobom/BOMProcess.java:471:
src/org/openbravo/retail/autobom/BOMProcess.java:496:
src/org/openbravo/retail/autobom/process/BOMProcess.java:397:
src/org/openbravo/retail/autobom/process/BOMProcess.java:422:
-
No tags attached.
blocks design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Issue History
2021-11-11 16:02shuehnerNew Issue
2021-11-11 16:02shuehnerAssigned To => Retail
2021-11-11 16:02shuehnerOBNetwork customer => No
2021-11-11 16:02shuehnerTriggers an Emergency Pack => No
2021-11-11 16:02shuehnerIssue generated from0048039
2021-11-11 16:02shuehnerRelationship addedblocks 0041287
2021-11-11 16:04shuehnerIssue cloned0048044
2021-11-12 12:06hgbotMerge Request Status => open
2021-11-12 12:06hgbotNote Added: 0132996
2021-11-16 07:55hgbotMerge Request Statusopen => approved
2021-11-18 15:51hgbotResolutionopen => fixed
2021-11-18 15:51hgbotStatusnew => closed
2021-11-18 15:51hgbotNote Added: 0133183
2021-11-18 15:51hgbotNote Added: 0133184
2021-11-18 15:51shuehnerAssigned ToRetail => shuehner

Notes
(0132996)
hgbot   
2021-11-12 12:06   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.autobom/-/merge_requests/17 [^]
(0133183)
hgbot   
2021-11-18 15:51   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.autobom [^]
Changeset: f7748962b15d0c6f2757dfb4d10404824fe65918
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-11-12T12:05:37+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.autobom/-/commit/f7748962b15d0c6f2757dfb4d10404824fe65918 [^]

Fixes ISSUE-48043 Apply HQL Style

- Don't use StringBuilder to create HQL query
- inline src-gen constants to improve readability

---
M src/org/openbravo/retail/autobom/BOMProcess.java
M src/org/openbravo/retail/autobom/process/BOMProcess.java
---
(0133184)
hgbot   
2021-11-18 15:51   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.autobom/-/merge_requests/17 [^]