Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048042ModulesResource and Reservation Managementpublic2021-11-11 15:592021-11-17 15:50
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customer
Regression introduced in release
Summary0048042: Apply HQL Style in resources module
DescriptionHQL style should be applied in the module:

src/org/openbravo/module/resources/calendar/ResourcesCalendarActionHandler.java:592:
src/org/openbravo/module/resources/event/ReservationEventObserver.java:387: (extra toString())
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-11-11 15:59shuehnerNew Issue
2021-11-11 15:59shuehnerAssigned To => Triage Finance
2021-11-11 15:59shuehnerIssue generated from0048041
2021-11-11 15:59shuehnerRelationship addedblocks 0041287
2021-11-11 16:13shuehnerIssue cloned0048048
2021-11-11 16:43hgbotNote Added: 0132984
2021-11-17 14:05hgbotNote Added: 0133150
2021-11-17 14:05hgbotResolutionopen => fixed
2021-11-17 14:05hgbotStatusnew => closed
2021-11-17 14:05hgbotNote Added: 0133151
2021-11-17 15:50shuehnerAssigned ToTriage Finance => shuehner

Notes
(0132984)
hgbot   
2021-11-11 16:43   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.resources/-/merge_requests/3 [^]
(0133150)
hgbot   
2021-11-17 14:05   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.resources/-/merge_requests/3 [^]
(0133151)
hgbot   
2021-11-17 14:05   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.resources [^]
Changeset: 0854c3920a7184ef3b4d581fa4d89192a31c117f
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-11-11T16:41:57+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.resources/-/commit/0854c3920a7184ef3b4d581fa4d89192a31c117f [^]

Fixes ISSUE-48042 Apply HQL Style

- ResourcesCalendarActionHandler
  Don't use Stringbuilder to build the query string
- ReservationEventObserver remove extra toString()

---
M src/org/openbravo/module/resources/calendar/ResourcesCalendarActionHandler.java
M src/org/openbravo/module/resources/event/ReservationEventObserver.java
---