Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048039Retail ModulesLoyalty Management for Retailpublic2021-11-11 15:452024-05-06 09:02
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048039: Apply HQL style guide to org.openbravo.loyalty.earn.buyxearny
DescriptionApply HQL style guide


src/org/openbravo/loyalty/earn/buyxearny/process/BuyXEARNYPointsRule.java:113:
src/org/openbravo/loyalty/earn/buyxearny/process/BuyXEARNYPointsRule.java:131:
src/org/openbravo/loyalty/earn/buyxearny/process/BuyXEARNYPointsRule.java:239:
src/org/openbravo/loyalty/earn/buyxearny/process/BuyXEARNYPointsRule.java:77:
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks design defect 0041287 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-11-11 15:45shuehnerNew Issue
2021-11-11 15:45shuehnerAssigned To => platform
2021-11-11 15:45shuehnerIssue generated from0048037
2021-11-11 15:46shuehnerProjectModules => Retail Modules
2021-11-11 15:47shuehnerTriggers an Emergency Pack => No
2021-11-11 15:47shuehnerAssigned Toplatform => Retail
2021-11-11 15:47shuehnerCategoryLoyalty Programs => Loyalty Management for Retail
2021-11-11 15:47shuehnerRelationship addedblocks 0041287
2021-11-11 16:02shuehnerIssue cloned0048043
2021-11-12 11:55shuehnerDescription Updatedbug_revision_view_page.php?rev_id=23312#r23312
2021-11-12 11:57hgbotNote Added: 0132995
2021-11-18 15:43shuehnerAssigned ToRetail => shuehner
2021-11-18 15:44hgbotResolutionopen => fixed
2021-11-18 15:44hgbotStatusnew => closed
2021-11-18 15:44hgbotNote Added: 0133175
2021-11-18 15:44hgbotNote Added: 0133176
2024-05-06 09:02beautifulcravatNote Added: 0164091

Notes
(0132995)
hgbot   
2021-11-12 11:57   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.earn.buyxearny/-/merge_requests/5 [^]
(0133175)
hgbot   
2021-11-18 15:44   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.earn.buyxearny [^]
Changeset: 531492e9013506e1c0901c10ad56efe30be02686
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-11-12T11:56:43+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.earn.buyxearny/-/commit/531492e9013506e1c0901c10ad56efe30be02686 [^]

Fixes ISSUE-48039 Apply HQL Style

Don't use StringBuilder to build query string

---
M src/org/openbravo/loyalty/earn/buyxearny/process/BuyXEARNYPointsRule.java
---
(0133176)
hgbot   
2021-11-18 15:44   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.earn.buyxearny/-/merge_requests/5 [^]
(0164091)
beautifulcravat   
2024-05-06 09:02   
Code examined and confirmed

https://supermariobros.io [^]