Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048031Retail ModulesRetail API Gift Cardspublic2021-11-11 09:202021-11-22 13:39
Reportercaristu 
Assigned Tomigueldejuana 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048031: Support importing gift cards with the Retail API
DescriptionIt would be nice to have an entity mapping for the Retail API (Masterdata) connector that allows to import gift cards
Steps To Reproduce.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on feature request 0047887 closed caristu Support exporting Retail API documentation to external modules 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-11-11 09:20caristuNew Issue
2021-11-11 09:20caristuAssigned To => Retail
2021-11-11 09:20caristuOBNetwork customer => No
2021-11-11 09:20caristuTriggers an Emergency Pack => No
2021-11-11 09:21caristuRelationship addeddepends on 0047887
2021-11-11 09:22caristuAssigned ToRetail => migueldejuana
2021-11-15 10:49hgbotMerge Request Status => open
2021-11-15 10:49hgbotNote Added: 0133010
2021-11-15 16:18caristuRelationship deleteddepends on 0047887
2021-11-15 16:18caristuRelationship addeddepends on 0047887
2021-11-15 16:28hgbotMerge Request Statusopen => approved
2021-11-15 18:27hgbotNote Added: 0133083
2021-11-15 18:27hgbotNote Added: 0133084
2021-11-18 15:57hgbotNote Added: 0133189
2021-11-19 08:51hgbotNote Added: 0133209
2021-11-19 08:51hgbotNote Added: 0133210
2021-11-22 13:39hgbotResolutionopen => fixed
2021-11-22 13:39hgbotStatusnew => closed
2021-11-22 13:39hgbotNote Added: 0133256

Notes
(0133010)
hgbot   
2021-11-15 10:49   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api/-/merge_requests/19 [^]
(0133083)
hgbot   
2021-11-15 18:27   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api [^]
Changeset: 38cc73008292d6486354b7ce056dc44b03c80784
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 2021-11-15T16:26:34+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api/-/commit/38cc73008292d6486354b7ce056dc44b03c80784 [^]

related to ISSUE-48031: test infrastructure improvements

  Prepare some features of the testing infrastructure so they can be
reused in other modules that depend on the Retail API module.

  1- Provide a base class which provides basic infrastructure for testing
Retail API import entity mappings. This class can be extended by test
classes present in other modules that define this kind of mappings in
order to test them, avoiding the need of duplicating code.

  2- Support getting in RetailApiTestUtils to retrieve json files
present in other modules.

---
A src-test/org/openbravo/retail/api/importer/RetailAPIImportMappingBaseTest.java
M src-test/org/openbravo/retail/api/importer/RetailApiImportMappingsTest.java
M src-test/org/openbravo/retail/api/util/RetailApiTestUtils.java
---
(0133084)
hgbot   
2021-11-15 18:27   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api/-/merge_requests/19 [^]
(0133189)
hgbot   
2021-11-18 15:57   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api/-/merge_requests/21 [^]
(0133209)
hgbot   
2021-11-19 08:51   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api/-/merge_requests/21 [^]
(0133210)
hgbot   
2021-11-19 08:51   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api [^]
Changeset: 9a39a76b06c60d83be8acf796b1daefb498e4a60
Author: miguel.dejuana <miguel.dejuana@openbravo.com>
Date: 2021-11-19T08:12:19+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api/-/commit/9a39a76b06c60d83be8acf796b1daefb498e4a60 [^]

related to ISSUE-48031: test infrastructure improvements

     Prepare assertExpectedResult method of the testing infrastructure so it can be reused in other modules that depend on the Retail API module. Allow to pass dataPath in order to use the dependant module.

---
M src-test/org/openbravo/retail/api/mappings/RetailApiMappingBaseTest.java
M src-test/org/openbravo/retail/api/util/RetailApiTestUtils.java
---
(0133256)
hgbot   
2021-11-22 13:39   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api.giftcards [^]
Changeset: d1eb9e5c050a004ea98ccd8df7e88262bb6c38bb
Author: miguel.dejuana <miguel.dejuana@openbravo.com>
Date: 2021-11-22T13:37:14+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api.giftcards/-/commit/d1eb9e5c050a004ea98ccd8df7e88262bb6c38bb [^]

fixes ISSUE-48031: test infrastructure improvements

---
A api/org.openbravo.retail.api.giftcards-Masterdata - Retail API for Gift cards.json
A examples/README
A examples/Retail API GiftCard.postman_collection.json
A src-db/database/sourcedata/AD_MODULE.xml
A src-db/database/sourcedata/AD_MODULE_DBPREFIX.xml
A src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
A src-db/database/sourcedata/OBEI_ENTITY_MAPPING.xml
A src-db/database/sourcedata/OBEI_PROP_MAP_INSTANCE.xml
A src-db/database/sourcedata/RETAPCO_EXPORT_FILTER.xml
A src-db/database/sourcedata/RETAPCO_EXPORT_FILTER_PARAM.xml
A src-test/data/export/filter/giftcards/GiftCardByBusinessPartner.json
A src-test/data/export/filter/giftcards/GiftCardByOwner.json
A src-test/data/export/filter/giftcards/GiftCardBySearchKey.json
A src-test/data/importer/GiftCard.json
A src-test/org/openbravo/retail/api/giftcards/StandaloneTestSuite.java
A src-test/org/openbravo/retail/api/giftcards/export/RetailApiExportGiftCardFilters.java
A src-test/org/openbravo/retail/api/giftcards/importer/RetailApiGiftCardImportMappingsTest.java
---