Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048024Retail ModulesGift cards and gift voucherspublic2021-11-10 09:532022-02-28 10:09
Reportershuehner 
Assigned Torqueralta 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR22Q2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048024: Remove obsolete usage of MultiServerJSONProcess (storeserver) from giftcards module
DescriptionThe AbstractSimpleGiftCardProcess class extends the MultiServerJSONProcess which is part of the obsolete storeserver project.

Any use of it should be removed.

Note that this is a base-class for 8 individual classes in the giftcards module.
So any check what needs to be changes + tests need to look at all those 8.
Steps To Reproducegrep -r MultiServerJSONProcess
Proposed SolutionProbably
- Extend JSONProcessSimple instead
- Adjust
    protected JSONObject execute(JSONObject json) {
  to be
    public JSONObject exec(JSONObject json) {
- protected void createArchiveEntry
  Remove and replace by equivalent in the matching ImportEntryProcessor
Additional Information
TagsNo tags attached.
Relationships
related to defect 0048023 closed rqueralta Remove obsolete usage of MultiServerJSONProcess (storeserver) from sessions module 
related to defect 0048025 closed rqueralta Remove obsolete usage of MultiServerJSONProcess (storeserver) from posterminal module 
blocks defect 0048220 closed rqueralta mobile:core: Delete the MultiServerJSONProcess class which is part of obsolete storeserver code. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-11-10 09:53shuehnerNew Issue
2021-11-10 09:53shuehnerAssigned To => Retail
2021-11-10 09:53shuehnerOBNetwork customer => No
2021-11-10 09:53shuehnerTriggers an Emergency Pack => No
2021-11-10 09:53shuehnerIssue generated from0048023
2021-11-10 09:53shuehnerRelationship addedrelated to 0048023
2021-11-10 09:55shuehnerIssue cloned0048025
2021-11-10 09:55shuehnerRelationship addedrelated to 0048025
2021-11-10 09:55shuehnerRelationship addedblocks 0048000
2021-12-10 13:36shuehnerRelationship addedblocks 0048220
2021-12-10 13:37shuehnerRelationship deletedblocks 0048000
2021-12-17 00:29rqueraltaAssigned ToRetail => rqueralta
2021-12-17 00:29rqueraltaStatusnew => scheduled
2022-02-16 21:41hgbotMerge Request Status => open
2022-02-16 21:41hgbotNote Added: 0135063
2022-02-16 21:42hgbotNote Added: 0135064
2022-02-16 21:44hgbotNote Added: 0135065
2022-02-16 21:45hgbotNote Added: 0135066
2022-02-17 07:58hgbotMerge Request Statusopen => approved
2022-02-17 18:07hgbotNote Added: 0135087
2022-02-17 21:54hgbotNote Added: 0135102
2022-02-18 08:08hgbotResolutionopen => fixed
2022-02-18 08:08hgbotStatusscheduled => closed
2022-02-18 08:08hgbotFixed in Version => RR22Q2
2022-02-18 08:08hgbotNote Added: 0135110
2022-02-18 08:08hgbotNote Added: 0135111
2022-02-18 08:08hgbotNote Added: 0135112
2022-02-18 08:08hgbotNote Added: 0135113
2022-02-18 08:08hgbotNote Added: 0135114
2022-02-18 08:08hgbotNote Added: 0135115
2022-02-18 08:08hgbotNote Added: 0135116
2022-02-18 08:08hgbotNote Added: 0135117
2022-02-21 11:46hgbotNote Added: 0135170
2022-02-24 15:17hgbotNote Added: 0135285
2022-02-25 16:51hgbotNote Added: 0135326
2022-02-28 10:09hgbotNote Added: 0135333
2022-02-28 10:09hgbotNote Added: 0135334

Notes
(0135063)
hgbot   
2022-02-16 21:41   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/334 [^]
(0135064)
hgbot   
2022-02-16 21:42   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/722 [^]
(0135065)
hgbot   
2022-02-16 21:44   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/19 [^]
(0135066)
hgbot   
2022-02-16 21:45   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/109 [^]
(0135087)
hgbot   
2022-02-17 18:07   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/334 [^]
(0135102)
hgbot   
2022-02-17 21:54   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/336 [^]
(0135110)
hgbot   
2022-02-18 08:08   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 201318692dab1d5a1a4edaa912910293f51ff2a4
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 17-02-2022 20:57:01
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/201318692dab1d5a1a4edaa912910293f51ff2a4 [^]

Fixed BUG-48024: Added createSuccessResponse method and removed deprecate ignoreTransitioningStatus method

---
M src/org/openbravo/mobile/core/process/JSONProcessSimple.java
---
(0135111)
hgbot   
2022-02-18 08:08   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/336 [^]
(0135113)
hgbot   
2022-02-18 08:08   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/109 [^]
(0135112)
hgbot   
2022-02-18 08:08   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 7e6febbe5bc1999f5fe29425d7bad4c7981b2a14
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 15-02-2022 08:33:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/7e6febbe5bc1999f5fe29425d7bad4c7981b2a14 [^]

Fixed BUG-48024: Remove obsolete usage of MultiServerJSONProcess

---
M src/org/openbravo/retail/giftcards/CancelGiftCard.java
M src/org/openbravo/retail/giftcards/CancelGiftCardTransaction.java
M src/org/openbravo/retail/giftcards/CloseGiftCard.java
M src/org/openbravo/retail/giftcards/ConsumeGiftCardAmount.java
M src/org/openbravo/retail/giftcards/ConsumeGiftCardLines.java
M src/org/openbravo/retail/giftcards/FindGiftCard.java
M src/org/openbravo/retail/giftcards/GiftCardCertificate.java
M src/org/openbravo/retail/giftcards/RevertGiftCardAmount.java
R src/org/openbravo/retail/giftcards/AbstractSimpleGiftCardProcess.java
---
(0135114)
hgbot   
2022-02-18 08:08   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata [^]
Changeset: fbe11bc3f5a1c2ff3ea94869de8ff412798e72cb
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 14-02-2022 14:24:59
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/commit/fbe11bc3f5a1c2ff3ea94869de8ff412798e72cb [^]

Fixed BUG-48024: Added access to The White Valley Group annd White Valley Spain S.A org to VallBlancaUser role

---
M referencedata/sampledata/The_White_Valley_Group/AD_ROLE_ORGACCESS.xml
---
(0135115)
hgbot   
2022-02-18 08:08   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/19 [^]
(0135116)
hgbot   
2022-02-18 08:08   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: acf91d1989dcd8e7bfc1acac324791774150ac66
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 18-02-2022 07:08:24
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/acf91d1989dcd8e7bfc1acac324791774150ac66 [^]

Fixed BUG-48024: Move creteSuccessResponse function to parent class

---
M src/org/openbravo/retail/posterminal/JSONProcessSimple.java
M src/org/openbravo/retail/posterminal/process/IsOrderCancelled.java
---
(0135117)
hgbot   
2022-02-18 08:08   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/722 [^]
(0135170)
hgbot   
2022-02-21 11:46   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 0705210d75e3dbae60028a21f70d1560791edea1
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 21-02-2022 11:46:06
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/0705210d75e3dbae60028a21f70d1560791edea1 [^]

Fixed BUG-48024: Added createSuccessResponse method and removed deprecate ignoreTransitioningStatus method

---
M src/org/openbravo/mobile/core/process/JSONProcessSimple.java
---
(0135285)
hgbot   
2022-02-24 15:17   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: f7c776a582b4ec3d71fd8ec3627809b8643c58bf
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 17-02-2022 15:46:53
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/f7c776a582b4ec3d71fd8ec3627809b8643c58bf [^]

Fixed BUG-48024: Added createSuccessResponse method and removed deprecate ignoreTransitioningStatus method

---
---
(0135326)
hgbot   
2022-02-25 16:51   
Merge Request created: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail.giftcard/-/merge_requests/2 [^]
(0135333)
hgbot   
2022-02-28 10:09   
Repository: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail.giftcard [^]
Changeset: 915ff92ce6b0ee8150f1bbe34aec8f484d7bb84d
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 25-02-2022 10:50:13
URL: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail.giftcard/-/commit/915ff92ce6b0ee8150f1bbe34aec8f484d7bb84d [^]

Related to ISSUE-48024: Replace execute call by exec

---
M src/com/practicsbs/saftpt/retail/giftcard/master/SaftrgcCancelGiftCard.java
---
(0135334)
hgbot   
2022-02-28 10:09   
Merge request merged: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt.retail.giftcard/-/merge_requests/2 [^]