Openbravo Issue Tracking System - Retail Modules |
View Issue Details |
|
ID | Project | Category | View Status | Date Submitted | Last Update |
0048015 | Retail Modules | Tests Stabilization | public | 2021-11-09 13:55 | 2021-11-11 15:32 |
|
Reporter | shuehner | |
Assigned To | shuehner | |
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | closed | Resolution | fixed | |
Platform | | OS | 5 | OS Version | |
Product Version | | |
Target Version | | Fixed in Version | | |
Merge Request Status | |
Review Assigned To | marvintm |
OBNetwork customer | |
Support ticket | |
Regression level | |
Regression date | |
Regression introduced in release | |
Regression introduced by commit | |
Triggers an Emergency Pack | No |
|
Summary | 0048015: Remove obsolete multiserver/storeserver tests from mobile-test repo |
Description | Storeserver project is obsolete but the mobile-test repo still contains all the functional tests for it + parts of infrastructure only used for it (store1,store2 config + talking to different databases etc)
That code is obsolete and should be removed |
Steps To Reproduce | Example searches to find related code:
grep -r storeserver
grep -r multiserver
grep -r store2
grep -r store1
|
Proposed Solution | |
Additional Information | |
Tags | No tags attached. |
Relationships | related to | defect | 0048000 | | closed | shuehner | Remove obsolete storeserver related code from mobile.core |
|
Attached Files | |
|
Issue History |
Date Modified | Username | Field | Change |
2021-11-09 13:55 | shuehner | New Issue | |
2021-11-09 13:55 | shuehner | Assigned To | => Retail |
2021-11-09 13:55 | shuehner | Triggers an Emergency Pack | => No |
2021-11-09 13:55 | shuehner | Relationship added | related to 0048000 |
2021-11-09 14:41 | hgbot | Note Added: 0132919 | |
2021-11-10 09:57 | shuehner | Status | new => scheduled |
2021-11-11 15:31 | shuehner | Assigned To | Retail => shuehner |
2021-11-11 15:31 | hgbot | Note Added: 0132969 | |
2021-11-11 15:31 | hgbot | Note Added: 0132970 | |
2021-11-11 15:31 | hgbot | Note Added: 0132971 | |
2021-11-11 15:31 | hgbot | Note Added: 0132972 | |
2021-11-11 15:31 | hgbot | Note Added: 0132973 | |
2021-11-11 15:31 | hgbot | Note Added: 0132974 | |
2021-11-11 15:31 | hgbot | Note Added: 0132975 | |
2021-11-11 15:31 | hgbot | Note Added: 0132976 | |
2021-11-11 15:31 | hgbot | Note Added: 0132977 | |
2021-11-11 15:31 | hgbot | Note Added: 0132978 | |
2021-11-11 15:31 | hgbot | Note Added: 0132979 | |
2021-11-11 15:31 | shuehner | Note Added: 0132980 | |
2021-11-11 15:31 | shuehner | Status | scheduled => resolved |
2021-11-11 15:31 | shuehner | Resolution | open => fixed |
2021-11-11 15:32 | shuehner | Review Assigned To | => marvintm |
2021-11-11 15:32 | shuehner | Note Added: 0132981 | |
2021-11-11 15:32 | shuehner | Status | resolved => closed |
Notes |
|
(0132919)
|
hgbot
|
2021-11-09 14:41
|
|
|
|
(0132969)
|
hgbot
|
2021-11-11 15:31
|
|
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 99db931bbd6d7be8646c8045e34fee82b43bffa1
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-11-09T14:36:50+01:00
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/99db931bbd6d7be8646c8045e34fee82b43bffa1 [^]
Related to ISSUE-48015: Remove obsolete storeserver tests (store1 part)
Part: "store2" tests
- Removes main ant target: test.retail.multiserver.store2
- Removes the 3 testsuites related to it
- Removes 3 All* files
- Removes the individual tests related to store2
- Removes the WebPOSStore2TerminalHelper
- Remove the ant utility targets relatedt to store2
---
M build.xml
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/suites/store2/MultiserverStore2SuiteHighVolumeMode.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/suites/store2/MultiserverStore2SuiteNormalMode.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/suites/store2/MultiserverStore2SuiteSynchronizedMode.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/terminals/WebPOSStore2TerminalHelper.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/logoutStore2/MSS2LogoutAndCloseBrowser.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store2/AllMultiserverStore2TestsHighVolumeMode.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store2/AllMultiserverStore2TestsNormalMode.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store2/AllMultiserverStore2TestsSynchronizedMode.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store2/MSS2001_SalesFlow.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store2/MSS2002_UpdateProduct.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store2/MSS2003_UpdateBPartner.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store2/MSS2004_Cashup.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store2/MSS2005_Cashmanagement.java
---
|
|
|
(0132970)
|
hgbot
|
2021-11-11 15:31
|
|
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: d97f0abdc867ceb83c179d8ef423752967a3c641
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-11-09T15:01:34+01:00
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/d97f0abdc867ceb83c179d8ef423752967a3c641 [^]
Related to ISSUE-48015: Remove obsolete storeserver tests (store1 part)
Part: "dbsynch, functionaldbsynch" or test.replication.infrastructure
- Removes main ant target test.replication.infrastructure
- Removes the dbsynch javapackage and content (suites + individual
tests)
- Removes the functionaldbsynch javapackage and content (only 2 tests)
---
M build.xml
R src-test/org/openbravo/test/mobile/retail/multiserver/unittests/suites/dbsynch/DatabaseSynchronizationSuite.java
R src-test/org/openbravo/test/mobile/retail/multiserver/unittests/tests/dbsynch/BidirectionalSynchronization.java
R src-test/org/openbravo/test/mobile/retail/multiserver/unittests/tests/dbsynch/ExcludedColumnsSynchronization.java
R src-test/org/openbravo/test/mobile/retail/multiserver/unittests/tests/dbsynch/MultiserverDatabaseCount.java
R src-test/org/openbravo/test/mobile/retail/multiserver/unittests/tests/dbsynch/PartialSynchronization.java
R src-test/org/openbravo/test/mobile/retail/multiserver/unittests/tests/dbsynch/SynchronizationChannels.java
R src-test/org/openbravo/test/mobile/retail/multiserver/unittests/tests/dbsynch/SynchronizationRouters.java
R src-test/org/openbravo/test/mobile/retail/multiserver/unittests/tests/dbsynch/TestTriggerDisabling.java
R src-test/org/openbravo/test/mobile/retail/multiserver/unittests/tests/dbsynch/UnidirectionalBasicSynchronization.java
R src-test/org/openbravo/test/mobile/retail/multiserver/unittests/tests/functionaldbsynch/LocationSynchronization.java
R src-test/org/openbravo/test/mobile/retail/multiserver/unittests/tests/functionaldbsynch/ProductServiceSynchronization.java
---
|
|
|
(0132971)
|
hgbot
|
2021-11-11 15:31
|
|
|
|
(0132972)
|
hgbot
|
2021-11-11 15:31
|
|
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: b19e98961750aee492286f5548a123d79505af31
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-11-09T15:35:29+01:00
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/b19e98961750aee492286f5548a123d79505af31 [^]
Related to ISSUE-48015: Remove obsolete storeserver tests (store1 part)
Part: related to store1 suites
- Remove main ant target test.retail.multiserver
- Remove suites in suite1 package and its contents
- multiserver offline package
- multiserver store1 package
- store1 terminal helpers
- ant utility targets related to store1
---
M build.xml
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/suites/store1/MultiserverSuiteHighVolumeMode.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/suites/store1/MultiserverSuiteNormalMode.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/suites/store1/MultiserverSuiteSynchronizedMode.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/suites/store1/OfflineMultiserverSuiteHighVolumeMode.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/suites/store1/OfflineMultiserverSuiteNormalMode.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/suites/store1/OfflineMultiserverSuiteSynchronizedMode.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/terminals/WebPOSCentralOfflineTerminalHelper.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/terminals/WebPOSLAYVBSStore1TerminalHelper.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/terminals/WebPOSStore1OfflineTerminalHelper.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/terminals/WebPOSStore1TerminalHelper.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/logoutStore1/MSS1LogoutAndCloseBrowser.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/offline/AllOfflineMultiserverTestsHighVolumeMode.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/offline/AllOfflineMultiserverTestsNormalMode.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/offline/AllOfflineMultiserverTestsSynchronizedMode.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/offline/OfflineMS001_SalesFlow.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/offline/OfflineMS002_SaleWithTwentyLines.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/offline/OfflineMS003_CreateMultiorder.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/offline/OfflineMS004_Cashup.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/offline/OfflineMS005_Cashmanagement.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/offline/OfflineMS006_LAWa010_CreateLayaway.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/offline/OfflineMS007_I31323_LayawayPayOpenTicket.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/offline/OfflineMS008_RejectQuotations.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/offline/OfflineMS009_MS020_ReturnServiceTests.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/offline/OfflineMS010_I27476_SameDocumentNoAfterPayAndReload.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/offline/OfflineMSCentral001_SalesFlow.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/offline/OfflineMSCentral002_SaleWithTwentyLines.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/offline/OfflineMSCentral003_CreateMultiorder.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/offline/OfflineMSCentral004_Cashup.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/offline/OfflineMSCentral005_Cashmanagement.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/offline/OfflineMSCentral006_LAWa010_CreateLayaway.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/offline/OfflineMSCentral007_I31323_LayawayPayOpenTicket.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/offline/OfflineMSCentral008_RejectQuotations.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/offline/OfflineMSCentral009_MS020_ReturnServiceTests.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/offline/OfflineMSCentral010_I27476_SameDocumentNoAfterPayAndReload.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/AllMultiserverTestsHighVolumeMode.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/AllMultiserverTestsNormalMode.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/AllMultiserverTestsSynchronizedMode.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS001_SalesFlow.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS002_UpdateProduct.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS003_UpdateBPartner.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS004_Cashup.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS005_Cashmanagement.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS006_CMGa10_CashManagementDeposit.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS007_CashUpPartialWithSale.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS008_I30997_NewCustomerForReceipt.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS009_SaleAndCashupVerifyingDatabaseI.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS010_SaleAndCashupVerifyingDatabaseII.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS011_LAWa010_CreateLayaway.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS012_I31462_VoidLayaway.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS013_VerifyLayawayToReceipt.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS014_I31323_LayawayPayOpenTicket.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS015_MPLSaleAndReturn.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS016_ReceiptsSearchExample.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS017_CreateSaleAndReturn.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS018_SaleWithTwentyLines.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS019_CreateMultiorder.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS020_ReturnServiceTests.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS021_I31019_SalesFromQuotationSessionId.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS022_RejectQuotations.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS023_I27476_SameDocumentNoAfterPayAndReload.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS024_CashupWithSaleAndReturn.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS025_NewDocumentnoAfterSale.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS026_SameDocumentnoAfterDeletingReceipt.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS027_SameDocumentnoAfterRefresh.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS028_SameDocumentnoAfterRefreshWithCreatedOrder.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS030_I35744_PayOpenTickets.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/StatelessMultiServerOrderLoaderTest.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/VerifyServersSynchronization.java
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/message-order-minimal-1.json
R src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/message-order-multiline-1.json
---
|
|
|
(0132973)
|
hgbot
|
2021-11-11 15:31
|
|
|
|
(0132974)
|
hgbot
|
2021-11-11 15:31
|
|
|
|
(0132975)
|
hgbot
|
2021-11-11 15:31
|
|
|
|
(0132976)
|
hgbot
|
2021-11-11 15:31
|
|
|
|
(0132977)
|
hgbot
|
2021-11-11 15:31
|
|
|
|
(0132978)
|
hgbot
|
2021-11-11 15:31
|
|
|
|
(0132979)
|
hgbot
|
2021-11-11 15:31
|
|
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 61ced17b254385a181338cfc453cb1adadc0bd6d
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-11-09T18:05:42+01:00
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/61ced17b254385a181338cfc453cb1adadc0bd6d [^]
Related to ISSUE-48015: Remove ServerType.{CENTRAL,STORE1,STORE2}
The ServerType enum was used to 'point' several methods to the correct
server to (mostly) run database queries against.
With storeserver tests being removed the options:
- CENTRAL (of a storeserver)
- STORE1+STORE2 (of a storeserver)
are obsolete.
Remove:
- The enum values which are not even set to those values anymore after
previous cleanup
- The 'usage' inside ConnectionHelper.
Note those methods have a default-section which will fail for any
unknown values as a safe-guard already
- Usage in MobileCoreTerminalHelper for store cases
- ConfigurationProperties & OpenbravoERPTest.properties.template
- Example values + code to read them and getters to retrieve all
properties related to central, store1 & store2
- Also remove job.routing.period.time.ms and job.push.period.time.ms
which are now unused
- Simplify if-condition in SequentialTestInfo as with this cleanup the
condition !(serverType = CENTRAL) will be always true
---
M config/OpenbravoERPTest.properties.template
M src-test/org/openbravo/test/mobile/core/junit/SequentialTestInfo.java
M src-test/org/openbravo/test/mobile/core/utils/ConfigurationProperties.java
M src-test/org/openbravo/test/mobile/retail/mobilecore/database/ConnectionHelper.java
M src-test/org/openbravo/test/mobile/retail/mobilecore/selenium/terminals/MobileCoreTerminalHelper.java
M src-test/org/openbravo/test/mobile/retail/pack/database/ServerType.java
---
|
|
|
|
Marking as resolved manually (commit was missing 'Fixes') |
|
|
|
Marking as closed manually (MR was approved, but commit missing 'Fixes') |
|