Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047978Retail ModulesDiscounts and Promotionspublic2021-11-03 19:152021-12-23 08:33
Reporterlbressan 
Assigned Torqueralta 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in VersionRR22Q1 
Merge Request Statusapproved
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket31675
Regression level
Regression date2021-11-17
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047978: Does not allow discounts from keyboard configuring touch point ui
DescriptionDoes not allow discounts from the keyboard by configuring the user interface of the point of contact when you deactivate the promotions
Steps To Reproduce1) Go to the "Discount and promotions" window and deactivate all promotions

2) Go to the window "Touchpoint Type" of the terminal that we are going to connect

3) They are in the "Touchpoint Type" window, Go to the "Touchpoint UI Configuration" field and add "Default POS UI Configuration"

4) Go to the "Preference" window and select the property "WEB POS Open Discounts From Keyboard"

5) Go to the POS and select a product, when selecting it you will try to add a "Discount" but we can see that the "Discount" button is disabled
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0050451 closed ranjith_qualiantech_com WEB POS Open Discounts From Keyboard preference is affecting the Receipt Discounts menu entry 
Attached Files? TIcket31675.mp4 (2,715,239) 2021-11-03 19:15
https://issues.openbravo.com/file_download.php?file_id=16327&type=bug
Issue History
Date ModifiedUsernameFieldChange
2021-11-03 19:15lbressanNew Issue
2021-11-03 19:15lbressanAssigned To => Retail
2021-11-03 19:15lbressanFile Added: TIcket31675.mp4
2021-11-03 19:15lbressanOBNetwork customer => OBPS
2021-11-03 19:15lbressanSupport ticket => 31675
2021-11-03 19:15lbressanRegression date => 2021-11-17
2021-11-03 19:15lbressanTriggers an Emergency Pack => No
2021-11-03 19:18PracticsIssue Monitored: Practics
2021-11-08 17:51rqueraltaAssigned ToRetail => rqueralta
2021-11-16 16:43rqueraltaStatusnew => scheduled
2021-11-24 16:45dromeroNote Added: 0133331
2021-12-14 15:13hgbotMerge Request Status => open
2021-12-14 15:13hgbotNote Added: 0133695
2021-12-16 08:45hgbotMerge Request Statusopen => approved
2021-12-16 08:46hgbotNote Added: 0133749
2021-12-16 08:46hgbotResolutionopen => fixed
2021-12-16 08:46hgbotStatusscheduled => closed
2021-12-16 08:46hgbotFixed in Version => RR22Q1
2021-12-16 08:46hgbotNote Added: 0133750
2021-12-16 15:38ivazquezNote Added: 0133770
2021-12-16 15:38ivazquezStatusclosed => new
2021-12-16 15:38ivazquezResolutionfixed => open
2021-12-17 17:00hgbotNote Added: 0133808
2021-12-20 08:24hgbotNote Added: 0133825
2021-12-20 08:24marvintmNote Added: 0133826
2021-12-20 08:25marvintmStatusnew => scheduled
2021-12-20 08:25marvintmStatusscheduled => resolved
2021-12-20 08:25marvintmResolutionopen => fixed
2021-12-20 08:25marvintmReview Assigned To => marvintm
2021-12-20 08:25marvintmStatusresolved => closed
2021-12-21 10:48hgbotNote Added: 0133867
2021-12-21 11:05hgbotNote Added: 0133868
2021-12-21 11:05hgbotNote Added: 0133869
2021-12-22 16:38hgbotNote Added: 0133909
2021-12-23 08:33hgbotNote Added: 0133926
2021-12-23 08:33hgbotNote Added: 0133927
2022-10-10 11:36ranjith_qualiantech_comRelationship addedrelated to 0050451

Notes
(0133331)
dromero   
2021-11-24 16:45   
any update?
(0133695)
hgbot   
2021-12-14 15:13   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/658 [^]
(0133749)
hgbot   
2021-12-16 08:46   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/658 [^]
(0133750)
hgbot   
2021-12-16 08:46   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 48e23b7e4e4de8e62134e7f531e9d0e826b4c5e6
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 16-12-2021 07:10:06
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/48e23b7e4e4de8e62134e7f531e9d0e826b4c5e6 [^]

Fixed BUG-47978: Allow discounts from the keyboard by configuring the user interface

---
M web/org.openbravo.retail.posterminal/js/actions/discount.js
---
(0133770)
ivazquez   
2021-12-16 15:38   
Hello team,

I will re-open the issue because the client detects a new error after applying the patch.

There are the explanatory video: https://watch.screencastify.com/v/weTphqHU3ENkzX1PAr8z [^]

And the Steps to Reproduce are the next:

-Follow the steps indicated in the steps to reproduce of the issue
-After adding a product, without having put anything, click on the Discount button and an error box appears in the upper left corner, and in the google chrome console an error appears saying the following: 'Uncaught BigDecimal(): Not a number: N,a,N'.
-If you add a discount number and click on the Discount button, the discount is applied but the number remains written on the terminal.
(0133808)
hgbot   
2021-12-17 17:00   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/661 [^]
(0133825)
hgbot   
2021-12-20 08:24   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/661 [^]
(0133826)
marvintm   
2021-12-20 08:24   
Fixed by this subsequent commit:

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/661/diffs?commit_id=bb9298e59b79515255de95febed0e15d51033bbd [^]
(0133867)
hgbot   
2021-12-21 10:48   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/663 [^]
(0133868)
hgbot   
2021-12-21 11:05   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 9d89a8875569d95ea3bc6902f03c235828948f1e
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 21-12-2021 12:31:04
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/9d89a8875569d95ea3bc6902f03c235828948f1e [^]

Related to ISSUE-47978: Keyboard content should not validated when opening discounts

---
M web/org.openbravo.retail.posterminal/js/actions/discount.js
---
(0133869)
hgbot   
2021-12-21 11:05   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/663 [^]
(0133909)
hgbot   
2021-12-22 16:38   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/666 [^]
(0133926)
hgbot   
2021-12-23 08:33   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/666 [^]
(0133927)
hgbot   
2021-12-23 08:33   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: ae5778fe4d8656f74c7c5cface5584c2072afd72
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 23-12-2021 07:32:27
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/ae5778fe4d8656f74c7c5cface5584c2072afd72 [^]

Related to ISSUE-47978: if Keyboard content is empty percentage value will be equal to 0

---
M web/org.openbravo.retail.posterminal/js/actions/discount.js
---