Openbravo Issue Tracking System - Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0047974 | Modules | Tax Report Launcher | public | 2021-11-03 16:28 | 2022-12-27 16:23 |
|
| Reporter | shuehner | |
| Assigned To | francisco_ofarril | |
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Regression date | |
| Regression introduced by commit | |
| Regression level | |
| Review Assigned To | aferraz |
| Support ticket | |
| OBNetwork customer | |
| Regression introduced in release | |
|
| Summary | 0047974: Several modules from functional/omni team are using bad logging (System.out,System.err println or printStackTrace) |
| Description | This issue is to track all leftover cases which have not been reported earlier
Modules in functional team:
9 mods/org.openbravo.module.einvoice
3 mods/org.openbravo.module.validto
3 mods/org.openbravo.utility.multiplebpselector
11 pmods/com.practicsbs.saftpt
4 pmods/com.practicsbs.saftpt.retail
1 pmods/org.openbravo.document.massinvoicing
167 pmods/org.openbravo.idl
3 pmods/org.openbravo.module.invoicematchingalgorithm
4 pmods/org.openbravo.module.resources
3 pmods/org.openbravo.sepa.iso20022.camt |
| Steps To Reproduce | In any workspace having the relevant modules run to get the overview:
grep -IrE "System.out|System.err|printStackTrace" | grep -v buildvalidation | grep -v modulescript | grep -v src-test | cut -d'/' -f1-2 | sort | uniq -c
To get the full list (including code in question):
grep -IrE "System.out|System.err|printStackTrace" | grep -v buildvalidation | grep -v modulescript | grep -v src-test | cut -d'/' -f1-2 | sort | uniq -c
|
| Proposed Solution | Review and move the logging to proper log4j usage.
While doing that check if:
- stackTrace is really wanted
- Logging is really useful (and not developer leftover)
|
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0048091 | | closed | mgonzalezh | Modules | SPLP: Several modules from functional/omni team are using bad logging (System.out,System.err println or printStackTrace) | | related to | defect | 0048092 | | closed | mtaal | Modules | org.openbravo.reporting.tools module is using bad logging (printStackTrace) | | blocks | design defect | 0036162 | | acknowledged | Triage Platform Base | Openbravo ERP | clean up openbravo.log |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2021-11-03 16:28 | shuehner | New Issue | |
| 2021-11-03 16:28 | shuehner | Assigned To | => Triage Finance |
| 2021-11-03 16:28 | shuehner | Relationship added | blocks 0036162 |
| 2021-11-03 16:58 | vmromanos | Note Added: 0132816 | |
| 2021-11-17 14:31 | vmromanos | Issue cloned | 0048091 |
| 2021-11-17 14:31 | vmromanos | Relationship added | related to 0048091 |
| 2021-11-17 14:33 | vmromanos | Note Added: 0133153 | |
| 2021-11-17 14:33 | vmromanos | Description Updated | bug_revision_view_page.php?rev_id=23331#r23331 |
| 2021-11-17 14:39 | vmromanos | Issue cloned | 0048092 |
| 2021-11-17 14:39 | vmromanos | Relationship added | related to 0048092 |
| 2021-11-17 14:41 | vmromanos | Note Added: 0133154 | |
| 2021-11-17 14:41 | vmromanos | Description Updated | bug_revision_view_page.php?rev_id=23332#r23332 |
| 2021-11-17 14:44 | vmromanos | Assigned To | Triage Finance => aferraz |
| 2022-07-26 18:29 | hgbot | Note Added: 0139619 | |
| 2022-07-26 18:39 | hgbot | Note Added: 0139620 | |
| 2022-07-26 18:55 | hgbot | Note Added: 0139622 | |
| 2022-07-27 09:51 | hgbot | Note Added: 0139628 | |
| 2022-07-27 10:05 | hgbot | Note Added: 0139629 | |
| 2022-07-27 10:08 | hgbot | Note Added: 0139630 | |
| 2022-07-27 10:14 | hgbot | Note Added: 0139631 | |
| 2022-07-27 10:32 | hgbot | Note Added: 0139632 | |
| 2022-07-27 10:58 | hgbot | Note Added: 0139634 | |
| 2022-08-02 09:24 | hgbot | Note Added: 0139785 | |
| 2022-08-02 09:24 | hgbot | Note Added: 0139786 | |
| 2022-08-02 09:25 | hgbot | Note Added: 0139787 | |
| 2022-08-02 09:25 | hgbot | Note Added: 0139788 | |
| 2022-08-02 09:26 | hgbot | Note Added: 0139789 | |
| 2022-08-02 09:26 | hgbot | Note Added: 0139790 | |
| 2022-08-02 09:28 | hgbot | Note Added: 0139791 | |
| 2022-08-02 09:28 | hgbot | Note Added: 0139792 | |
| 2022-08-02 09:29 | hgbot | Note Added: 0139793 | |
| 2022-08-02 09:29 | hgbot | Note Added: 0139794 | |
| 2022-08-02 09:59 | hgbot | Note Added: 0139795 | |
| 2022-08-02 09:59 | hgbot | Note Added: 0139796 | |
| 2022-08-02 10:00 | hgbot | Note Added: 0139797 | |
| 2022-08-02 10:00 | hgbot | Note Added: 0139798 | |
| 2022-08-02 10:01 | hgbot | Note Added: 0139799 | |
| 2022-08-02 10:01 | hgbot | Note Added: 0139800 | |
| 2022-08-02 10:02 | hgbot | Note Added: 0139801 | |
| 2022-08-02 10:02 | hgbot | Note Added: 0139802 | |
| 2022-12-16 15:33 | aferraz | Assigned To | aferraz => francisco_ofarril |
| 2022-12-23 19:44 | francisco_ofarril | Status | new => acknowledged |
| 2022-12-26 15:54 | francisco_ofarril | Note Added: 0145009 | |
| 2022-12-27 16:23 | aferraz | Status | acknowledged => scheduled |
| 2022-12-27 16:23 | aferraz | Status | scheduled => resolved |
| 2022-12-27 16:23 | aferraz | Resolution | open => fixed |
| 2022-12-27 16:23 | aferraz | Review Assigned To | => aferraz |
| 2022-12-27 16:23 | aferraz | Note Added: 0145040 | |
| 2022-12-27 16:23 | aferraz | Status | resolved => closed |
|
Notes |
|
|
|
|
Exclude pmods/org.openbravo.idl as it is a legacy module and the number of warnings is too high |
|
|
|
|
|
Split SPLP related issues in 0048091 |
|
|
|
|
|
Split WMS/Reporting related issues in 0048092 |
|
|
|
(0139619)
|
|
hgbot
|
|
2022-07-26 18:29
|
|
|
|
|
(0139620)
|
|
hgbot
|
|
2022-07-26 18:39
|
|
|
|
|
(0139622)
|
|
hgbot
|
|
2022-07-26 18:55
|
|
|
|
|
(0139628)
|
|
hgbot
|
|
2022-07-27 09:51
|
|
|
|
|
(0139629)
|
|
hgbot
|
|
2022-07-27 10:05
|
|
|
|
|
(0139630)
|
|
hgbot
|
|
2022-07-27 10:08
|
|
|
|
|
(0139631)
|
|
hgbot
|
|
2022-07-27 10:14
|
|
|
|
|
(0139632)
|
|
hgbot
|
|
2022-07-27 10:32
|
|
|
|
|
(0139634)
|
|
hgbot
|
|
2022-07-27 10:58
|
|
|
|
|
(0139785)
|
|
hgbot
|
|
2022-08-02 09:24
|
|
|
|
|
(0139786)
|
|
hgbot
|
|
2022-08-02 09:24
|
|
|
|
|
(0139787)
|
|
hgbot
|
|
2022-08-02 09:25
|
|
|
|
|
(0139788)
|
|
hgbot
|
|
2022-08-02 09:25
|
|
|
|
|
(0139789)
|
|
hgbot
|
|
2022-08-02 09:26
|
|
|
|
|
(0139790)
|
|
hgbot
|
|
2022-08-02 09:26
|
|
|
|
|
(0139791)
|
|
hgbot
|
|
2022-08-02 09:28
|
|
|
|
|
(0139792)
|
|
hgbot
|
|
2022-08-02 09:28
|
|
|
|
|
(0139793)
|
|
hgbot
|
|
2022-08-02 09:29
|
|
|
|
|
(0139794)
|
|
hgbot
|
|
2022-08-02 09:29
|
|
|
|
|
(0139795)
|
|
hgbot
|
|
2022-08-02 09:59
|
|
|
|
|
(0139796)
|
|
hgbot
|
|
2022-08-02 09:59
|
|
|
|
|
(0139797)
|
|
hgbot
|
|
2022-08-02 10:00
|
|
|
|
|
(0139798)
|
|
hgbot
|
|
2022-08-02 10:00
|
|
|
|
|
(0139799)
|
|
hgbot
|
|
2022-08-02 10:01
|
|
|
|
|
(0139800)
|
|
hgbot
|
|
2022-08-02 10:01
|
|
|
|
|
(0139801)
|
|
hgbot
|
|
2022-08-02 10:02
|
|
|
|
|
(0139802)
|
|
hgbot
|
|
2022-08-02 10:02
|
|
|
|
|
(0145009)
|
|
francisco_ofarril
|
|
2022-12-26 15:54
|
|
In these modules it is already solved...
mods/org.openbravo.module.einvoice
mods/org.openbravo.module.validto
mods/org.openbravo.utility.multiplebpselector
pmods/com.practicsbs.saftpt
pmods/com.practicsbs.saftpt.retail
pmods/org.openbravo.document.massinvoicing
pmods/org.openbravo.module.invoicematchingalgorithm
pmods/org.openbravo.module.resources
pmods/org.openbravo.sepa.iso20022.camt |
|
|
|
|
|
Fixed in every module but org.openbravo.idl as it is deprecated. |
|