Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047969ModulesSAP Connectorpublic2021-11-03 14:582021-11-11 09:39
Reportershuehner 
Assigned Tocaristu 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customer
Regression introduced in release
Summary0047969: org.openbravo.service.integration.sapecc use bad debug logging (System.out.println)
DescriptionThat logging looks like developer debugging code.

It should be moved to proper log4j usage to avoid bad code example
Steps To Reproducepmods/org.openbravo.service.integration.sapecc/src/org/openbravo/service/integration/sapecc/communication/jco/JCoErrorListener.java: System.out
pmods/org.openbravo.service.integration.sapecc/src/org/openbravo/service/integration/sapecc/communication/jco/JCoErrorListener.java: System.out
pmods/org.openbravo.service.integration.sapecc/src/org/openbravo/service/integration/sapecc/communication/jco/JCoTidHandler.java: System.out.println("checkTID called for TID=" + tid);
pmods/org.openbravo.service.integration.sapecc/src/org/openbravo/service/integration/sapecc/communication/jco/JCoTidHandler.java: System.out.println("commit called for TID=" + tid);
pmods/org.openbravo.service.integration.sapecc/src/org/openbravo/service/integration/sapecc/communication/jco/JCoTidHandler.java: System.out.println("confirmTID called for TID=" + tid);
pmods/org.openbravo.service.integration.sapecc/src/org/openbravo/service/integration/sapecc/communication/jco/JCoTidHandler.java: System.out.print("rollback called for TID=" + tid);
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks design defect 0036162 acknowledged Triage Platform Base Openbravo ERP clean up openbravo.log 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-11-03 14:58shuehnerNew Issue
2021-11-03 14:58shuehnerAssigned To => platform
2021-11-03 14:58shuehnerRelationship addedblocks 0036162
2021-11-05 09:12alostaleAssigned Toplatform => caristu
2021-11-09 09:18hgbotNote Added: 0132895
2021-11-11 09:39hgbotResolutionopen => fixed
2021-11-11 09:39hgbotStatusnew => closed
2021-11-11 09:39hgbotNote Added: 0132954
2021-11-11 09:39hgbotNote Added: 0132955

Notes
(0132895)
hgbot   
2021-11-09 09:18   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.integration.sapecc/-/merge_requests/3 [^]
(0132954)
hgbot   
2021-11-11 09:39   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.integration.sapecc [^]
Changeset: 88963a4cca21a26aab49de564a030fd2b8bef3b9
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 2021-11-09T09:15:52+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.integration.sapecc/-/commit/88963a4cca21a26aab49de564a030fd2b8bef3b9 [^]

fixes ISSUE-47969: use correct way of logging

---
M src/org/openbravo/service/integration/sapecc/communication/jco/JCoErrorListener.java
M src/org/openbravo/service/integration/sapecc/communication/jco/JCoTidHandler.java
---
(0132955)
hgbot   
2021-11-11 09:39   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.integration.sapecc/-/merge_requests/3 [^]