Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0047968 | Retail Modules | Web POS | public | 2021-11-03 14:55 | 2021-12-10 07:51 |
|
| Reporter | shuehner | |
| Assigned To | rqueralta | |
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0047968: org.openbravo.retail.avalaraconnector: uses bad logging (System.out.println and printStrace |
| Description | The PreOrderLoader has apparently some leftover developer debugging code
https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.avalaraconnector/-/blob/master/src/org/openbravo/retail/avalaraconnector/hooks/PreOrderLoader.java#L40 [^]
That should either be deleted to not have bad code example or alternatively moved to be log4j.debug
also is uses printStrace in 2 catch blocks to be moved to log4j.error |
| Steps To Reproduce | https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.avalaraconnector/-/blob/master/src/org/openbravo/retail/avalaraconnector/hooks/PreOrderLoader.java#L40 [^]
pmods/org.openbravo.retail.avalaraconnector/src/org/openbravo/retail/avalaraconnector/edl/OBAVCODataProcessor.java: e.printStackTrace();
pmods/org.openbravo.retail.avalaraconnector/src/org/openbravo/retail/avalaraconnector/edl/OBAVCODataProcessor.java: e.printStackTrace();
|
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2021-11-03 14:55 | shuehner | New Issue | |
| 2021-11-03 14:55 | shuehner | Assigned To | => Retail |
| 2021-11-03 14:55 | shuehner | Triggers an Emergency Pack | => No |
| 2021-11-03 14:56 | shuehner | Relationship added | blocks 0036162 |
| 2021-11-03 15:01 | shuehner | Summary | org.openbravo.retail.avalaraconnector: uses bad logging (System.out.println in commented out code) => org.openbravo.retail.avalaraconnector: uses bad logging (System.out.println and printStrace |
| 2021-11-03 15:01 | shuehner | Description Updated | bug_revision_view_page.php?rev_id=23266#r23266 |
| 2021-11-03 15:01 | shuehner | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=23268#r23268 |
| 2021-11-04 08:17 | marvintm | Status | new => scheduled |
| 2021-11-04 08:17 | marvintm | Assigned To | Retail => justin_patterson |
| 2021-11-10 15:54 | marvintm | Assigned To | justin_patterson => Retail |
| 2021-11-16 16:42 | rqueralta | Assigned To | Retail => rqueralta |
| 2021-11-26 07:57 | marvintm | Status | scheduled => acknowledged |
| 2021-11-26 07:57 | marvintm | Status | acknowledged => scheduled |
| 2021-11-26 07:57 | marvintm | Status | scheduled => feedback |
| 2021-11-26 07:58 | marvintm | Assigned To | rqueralta => Retail |
| 2021-11-26 07:58 | marvintm | Status | feedback => new |
| 2021-12-01 15:58 | rqueralta | Assigned To | Retail => rqueralta |
| 2021-12-10 04:18 | hgbot | Note Added: 0133593 | |
| 2021-12-10 07:51 | hgbot | Resolution | open => fixed |
| 2021-12-10 07:51 | hgbot | Status | new => closed |
| 2021-12-10 07:51 | hgbot | Note Added: 0133594 | |
| 2021-12-10 07:51 | hgbot | Note Added: 0133595 | |