Openbravo Issue Tracking System - Openbravo ERP | |||||||||||||||||||
| View Issue Details | |||||||||||||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||||||||||||
| 0047963 | Openbravo ERP | A. Platform | public | 2021-11-03 13:17 | 2021-11-04 10:16 | ||||||||||||||
| Reporter | shuehner | ||||||||||||||||||
| Assigned To | alostale | ||||||||||||||||||
| Priority | normal | Severity | minor | Reproducibility | have not tried | ||||||||||||||
| Status | closed | Resolution | fixed | ||||||||||||||||
| Platform | OS | 5 | OS Version | ||||||||||||||||
| Product Version | |||||||||||||||||||
| Target Version | Fixed in Version | PR22Q1 | |||||||||||||||||
| Merge Request Status | |||||||||||||||||||
| Review Assigned To | |||||||||||||||||||
| OBNetwork customer | |||||||||||||||||||
| Web browser | |||||||||||||||||||
| Modules | Core | ||||||||||||||||||
| Support ticket | |||||||||||||||||||
| Regression level | |||||||||||||||||||
| Regression date | |||||||||||||||||||
| Regression introduced in release | |||||||||||||||||||
| Regression introduced by commit | |||||||||||||||||||
| Triggers an Emergency Pack | No | ||||||||||||||||||
| Summary | 0047963: HostNameTask should not use System.out.println,System.err.println, printStackTrace for its output | ||||||||||||||||||
| Description | That custom ant task is not using log4j at all but all of: - System.out.println - System.err.println - e.printStackTrace The comment explaining the reason: // using System.out instead of log4j to be able to run this tasks without // having compiled defined appenders is most likely obsolete. As custom compiled appenders from Openbravo where removed with the "MMC Rebuild/Restart removal" project. Today that code should be able to just use log4j and avoid being a bad example. | ||||||||||||||||||
| Steps To Reproduce | https://gitlab.com/openbravo/product/openbravo/-/commit/893bc475e92232ed0e71aee050848dab458d62e8#320d411275551c3035b76c3ab909e6c86a0b53e7_116_139 [^] | ||||||||||||||||||
| Proposed Solution | Either a.) Remove the if/else block having the System.out.println in connection cannot be null b.) if that is not possible change it to proper log4j error usage | ||||||||||||||||||
| Additional Information | |||||||||||||||||||
| Tags | No tags attached. | ||||||||||||||||||
| Relationships |
| ||||||||||||||||||
| Attached Files | |||||||||||||||||||
| Issue History | |||||||||||||||||||
| Date Modified | Username | Field | Change | ||||||||||||||||
| 2021-11-03 13:17 | shuehner | New Issue | |||||||||||||||||
| 2021-11-03 13:17 | shuehner | Assigned To | => platform | ||||||||||||||||
| 2021-11-03 13:17 | shuehner | Modules | => Core | ||||||||||||||||
| 2021-11-03 13:17 | shuehner | Triggers an Emergency Pack | => No | ||||||||||||||||
| 2021-11-03 13:17 | shuehner | Issue generated from | 0047962 | ||||||||||||||||
| 2021-11-03 13:17 | shuehner | Relationship added | blocks 0036162 | ||||||||||||||||
| 2021-11-04 08:07 | alostale | Relationship added | related to 0044269 | ||||||||||||||||
| 2021-11-04 08:19 | hgbot | Note Added: 0132824 | |||||||||||||||||
| 2021-11-04 08:32 | alostale | Status | new => scheduled | ||||||||||||||||
| 2021-11-04 08:32 | alostale | Assigned To | platform => alostale | ||||||||||||||||
| 2021-11-04 10:16 | hgbot | Resolution | open => fixed | ||||||||||||||||
| 2021-11-04 10:16 | hgbot | Status | scheduled => closed | ||||||||||||||||
| 2021-11-04 10:16 | hgbot | Note Added: 0132829 | |||||||||||||||||
| 2021-11-04 10:16 | hgbot | Fixed in Version | => PR22Q1 | ||||||||||||||||
| 2021-11-04 10:16 | hgbot | Note Added: 0132830 | |||||||||||||||||
| Notes | |||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||