Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047953Retail ModulesGift cards and gift voucherspublic2021-10-29 16:372022-01-27 17:15
Reporterlbressan 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in VersionRR22Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047953: Gift Card Data not saved
DescriptionWhen selecting a gift card, the line is not inserted, so the code that fills its data is not executed.

Video of the explained behavior: https://watch.screencastify.com/v/sQcClseFrBhxQdkYjoDT [^]

Steps To Reproduce1) Open web POS in Live Build https://livebuilds.openbravo.com/retail_modules_pgsql_pi/web/org.openbravo.retail.posterminal/?terminal=VBS-1 [^] .

2) Open Developer tools and go to "Sources" tab

3) Select the js file in livebuilds.openbravo.com/retail_modules_pgsql_pi/web/js/gen

4) Set a breakpoint at line "if (this.currentLine) { " .

Codeblock :
if (this.currentLine) {
  gcowner.bPartnerId = this.currentLine.get('giftcardobqcneGCOwner');
  gcowner.bPartnerName = this.currentLine.get(gcowner_name);
  ...

5) In web POS search "Voucher" in product search box

6) Select the Gift Card

7) Observe that the line is not inserted, so "this.currentLine" is undefined and therefore, the fields inside the if block are not filled.

8) Continue execution (play button)

9) Click on Gift Card Owner and select a customer

10) Complete the identifier (e.g: "test") and click Apply.

11) Go to "Checkout", click on "Pay total" and then on "Done"

12) Go to Menu -> Gift / Credit Notes and click on the search icon

13) Observe that the gift card data was not saved
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-10-29 16:37lbressanNew Issue
2021-10-29 16:37lbressanAssigned To => Retail
2021-10-29 16:37lbressanRegression date => 2021-10-15
2021-10-29 16:37lbressanTriggers an Emergency Pack => No
2021-10-29 17:36PracticsIssue Monitored: Practics
2021-11-02 17:49justin_pattersonAssigned ToRetail => justin_patterson
2021-11-10 07:18marvintmRegression date2021-10-15 =>
2021-11-11 07:38marvintmAssigned Tojustin_patterson => ranjith_qualiantech_com
2021-11-15 15:01ranjith_qualiantech_comNote Added: 0133050
2021-11-19 07:28marvintmNote Added: 0133199
2021-11-19 07:28marvintmStatusnew => closed
2021-11-19 07:28marvintmResolutionopen => unable to reproduce
2021-11-19 07:43PracticsNote Added: 0133200
2022-01-13 18:12marvintmStatusclosed => new
2022-01-13 18:12marvintmResolutionunable to reproduce => open
2022-01-17 10:37ranjith_qualiantech_comStatusnew => acknowledged
2022-01-19 06:19hgbotNote Added: 0134371
2022-01-21 08:27hgbotResolutionopen => fixed
2022-01-21 08:27hgbotStatusacknowledged => closed
2022-01-21 08:27hgbotNote Added: 0134449
2022-01-21 08:27hgbotNote Added: 0134450
2022-01-21 18:24dromeroNote Added: 0134499
2022-01-21 18:24dromeroStatusclosed => new
2022-01-21 18:24dromeroResolutionfixed => open
2022-01-27 13:54dromeroNote Added: 0134612
2022-01-27 17:15marvintmStatusnew => scheduled
2022-01-27 17:15marvintmStatusscheduled => resolved
2022-01-27 17:15marvintmFixed in Version => RR22Q2
2022-01-27 17:15marvintmResolutionopen => fixed
2022-01-27 17:15marvintmReview Assigned To => marvintm
2022-01-27 17:15marvintmStatusresolved => closed

Notes
(0133050)
ranjith_qualiantech_com   
2021-11-15 15:01   
Checked and confirmed with Reporter.
Issue is not reproducible in livebuilds.
(0133199)
marvintm   
2021-11-19 07:28   
We have been unable to reproduce the issue. We tried contacting the reporter several times, but we got no response.
(0133200)
Practics   
2021-11-19 07:43   
Hi, this is not's true, we explain all in the suport ticket 31068
(0134371)
hgbot   
2022-01-19 06:19   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/106 [^]
(0134449)
hgbot   
2022-01-21 08:27   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 6269c94d6a30f88b0a86cdc9eb407b012ce54628
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 18-01-2022 12:06:29
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/6269c94d6a30f88b0a86cdc9eb407b012ce54628 [^]

Fixed ISSUE-47953: GiftCard owner should be updated with Ticket customer
* When add new gift card/voucher, owner should be updated with ticket customer,
  if ticket customer is not a anonymous customer

---
M web/org.openbravo.retail.giftcards/js/components/GCNewEntitiesGCOwner.js
---
(0134450)
hgbot   
2022-01-21 08:27   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/106 [^]
(0134499)
dromero   
2022-01-21 18:24   
Add video with the error
https://watch.screencastify.com/v/FseEoujuH5bWzoHKzpWZ [^]
(0134612)
dromero   
2022-01-27 13:54   
The issues is resolved. The customer was wrong.