Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047950Retail ModulesDiscounts Combopublic2021-10-29 13:472021-11-17 08:02
Reportermartinsdan 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS30OS VersionUbuntu 18.04.1 LTS
Product VersionRR21Q3.4 
Target VersionFixed in VersionRR22Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047950: Error in prices adding several Combos Fixed Price
DescriptionWhen more than one Combo Fixed Price with different prices are added to the ticket, the total amount is wrong.

This only happens for some combinations.
Steps To ReproduceChange the currency price and POS precision to 4.
Create several combos fixed price with different prices where some products are common to more than one combo.
Add 2 combos to the ticket, see the price is wrong.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0048083RR21Q4.2 closed ranjith_qualiantech_com Error in prices adding several Combos Fixed Price 
depends on backport 0048084RR21Q3.6 closed ranjith_qualiantech_com Error in prices adding several Combos Fixed Price 
Attached Filespng ComboPOSPrice.png (152,426) 2021-10-29 13:47
https://issues.openbravo.com/file_download.php?file_id=16318&type=bug
png

diff 47950.diff (849) 2021-11-10 14:47
https://issues.openbravo.com/file_download.php?file_id=16337&type=bug
Issue History
Date ModifiedUsernameFieldChange
2021-10-29 13:47martinsdanNew Issue
2021-10-29 13:47martinsdanAssigned To => Retail
2021-10-29 13:47martinsdanFile Added: ComboPOSPrice.png
2021-10-29 13:47martinsdanTriggers an Emergency Pack => No
2021-11-02 06:05ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2021-11-10 14:47ranjith_qualiantech_comFile Added: 47950.diff
2021-11-11 11:24marvintmTarget VersionRR21Q3.5 =>
2021-11-12 06:40hgbotNote Added: 0132988
2021-11-12 06:53hgbotResolutionopen => fixed
2021-11-12 06:53hgbotStatusnew => closed
2021-11-12 06:53hgbotNote Added: 0132989
2021-11-12 06:53hgbotNote Added: 0132990
2021-11-17 08:02marvintmStatusclosed => new
2021-11-17 08:02marvintmResolutionfixed => open
2021-11-17 08:02marvintmStatusnew => scheduled
2021-11-17 08:02marvintmStatusscheduled => resolved
2021-11-17 08:02marvintmFixed in Version => RR22Q1
2021-11-17 08:02marvintmResolutionopen => fixed
2021-11-17 08:02marvintmReview Assigned To => marvintm
2021-11-17 08:02marvintmStatusresolved => closed

Notes
(0132988)
hgbot   
2021-11-12 06:40   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/15 [^]
(0132989)
hgbot   
2021-11-12 06:53   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: 3f77b9d2701b3b477f8f7f7a533100ff109f9f16
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-11-10T19:15:00+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/3f77b9d2701b3b477f8f7f7a533100ff109f9f16 [^]

Fixed ISSUE-47950: OriginalLinePrice should be used to calculate multiple combo discount

---
M web/org.openbravo.retail.discounts.combo/app/model/business-logic/discounts-engine/engine/rules/combo-discount.js
---
(0132990)
hgbot   
2021-11-12 06:53   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/15 [^]